From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <radu.nicolau@intel.com>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by dpdk.org (Postfix) with ESMTP id 032F51B171;
Mon, 21 May 2018 15:33:19 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
21 May 2018 06:33:18 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.49,426,1520924400"; d="scan'208";a="57087975"
Received: from rnicolau-mobl.ger.corp.intel.com (HELO [10.237.221.67])
([10.237.221.67])
by fmsmga001.fm.intel.com with ESMTP; 21 May 2018 06:33:17 -0700
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, dev@dpdk.org
Cc: thomas@monjalon.net, ferruh.yigit@intel.com, stable@dpdk.org
References: <1526902547-12710-1-git-send-email-radu.nicolau@intel.com>
<d175bfc8-d0e0-4cd5-c944-ce38488e5678@intel.com>
From: Radu Nicolau <radu.nicolau@intel.com>
Message-ID: <a4173f10-e7ad-6754-09b7-f93b55c52e9e@intel.com>
Date: Mon, 21 May 2018 14:33:16 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <d175bfc8-d0e0-4cd5-c944-ce38488e5678@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] test: fix hang on FreeBSD
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 21 May 2018 13:33:20 -0000
On 5/21/2018 2:28 PM, Burakov, Anatoly wrote:
> On 21-May-18 12:35 PM, Radu Nicolau wrote:
>> Fixes: af75078fece3 ("first public release")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
>> ---
>> test/test/test_debug.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/test/test/test_debug.c b/test/test/test_debug.c
>> index faf2cf5..56fadce 100644
>> --- a/test/test/test_debug.c
>> +++ b/test/test/test_debug.c
>> @@ -34,7 +34,8 @@ test_panic(void)
>> printf("Fork Failed\n");
>> return -1;
>> }
>> - wait(&status);
>> + sleep(1);
>> + waitpid(pid, &status, WNOHANG);
>> if(status == 0){
>> printf("Child process terminated normally!\n");
>> return -1;
>>
>
> I'd be curious to see which specific problem you are addressing as
> well. FreeBSD hanging on abort is a known issue, and a workaround is
> already available:
>
> http://dpdk.org/dev/patchwork/patch/40256/
>
> FreeBSD doesn't really "hang" here, it just spends a
> looooooooooooooong time doing the core dump because FreeBSD, unlike
> Linux, doesn't ignore hugepage and zero-page anonymous memory for core
> dumps, resulting in it trying to dump the entire 128 gigabytes of VA
> space that we preallocate.
>
> Setting resource limits will address the immediate issue, a more
> complete fix (some memory subsystem refactor) will be coming for 18.08.
>
So it seems my "fix" only hides the issue and doesn't actually fix
anything - so I will remove it from patchwork