From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AA14341CB0 for ; Thu, 16 Feb 2023 11:28:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A13F842D0B; Thu, 16 Feb 2023 11:28:42 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7458840EE3 for ; Thu, 16 Feb 2023 11:28:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676543319; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GuSJTsNNkw51tZHZc49kj4F35aMNRJPn+agLHHog4+g=; b=FfQ5ynrif+sdNXbCCPK9CBWW7LFJ4PF7mHyhRHzOmOYNOkFbyBr7Vghc0DZ30VDLFL/n+x gaW4IhJtcDi+zr4VF3zL3iRGc8FViJq4smF/XPfrYIOhygBoDdLN5vbtO9ktj+5+DW1xRn 62p419mmNibloi+Qk2Y1z0Jl8hFr/0s= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-439-KJKID4BZO_Olg2a69uTIGQ-1; Thu, 16 Feb 2023 05:28:37 -0500 X-MC-Unique: KJKID4BZO_Olg2a69uTIGQ-1 Received: by mail-wm1-f70.google.com with SMTP id n7-20020a05600c3b8700b003dc55dcb298so902062wms.8 for ; Thu, 16 Feb 2023 02:28:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GuSJTsNNkw51tZHZc49kj4F35aMNRJPn+agLHHog4+g=; b=2nyYYgpBU+bq7HiNjY9ftSWl95pQ3tVmVkjStztA8uSomdSTLhtFp9+z+ifwq+xz2B AmEfpsAwaRcH6+TLq1nFVJPavNKCR2LzDTyChLNgbCQXLV53vHSvk7fd2AEZPOhKrRmx E7ehx6pHiJhe7Hisdj8++UudapoTLYcxHRW6Kxj+razIBVA+zCJs9iMpmN1um74mV5JD 835fZ9sN9VscTVMdvWh1ITIcHnEDQLqTCHH9pYmFC2thdYonEJyK//zPhRZzqn4YeFCY 4nL7l1377YFhUGYApj0iKyTy2jIwkR8w1eQq0qEcVEk6XFgIyXJpP0rkXQ400kaRn+fg cH0Q== X-Gm-Message-State: AO0yUKUpC735rz+NItJl9PgfCwNYOy/GX8NWqGDf+UsB21O4tp8LEeSZ gp+dRAtSO4d0i+LEqepW+InQzVJJXe3kuBPiQviAk6I3N7CyTabPAnUd0yxF9C4R6ELa4g2dWIk rEB3fM4c= X-Received: by 2002:adf:f98b:0:b0:2c5:46f1:bdb2 with SMTP id f11-20020adff98b000000b002c546f1bdb2mr4357777wrr.14.1676543316540; Thu, 16 Feb 2023 02:28:36 -0800 (PST) X-Google-Smtp-Source: AK7set+U2U27lTD7ql9wHwHKNyBj7/tydRfDfFwgUkXVKrpUBRM3+ThCXLQazbJtaD2ZbVuQgGFxQw== X-Received: by 2002:adf:f98b:0:b0:2c5:46f1:bdb2 with SMTP id f11-20020adff98b000000b002c546f1bdb2mr4357760wrr.14.1676543316225; Thu, 16 Feb 2023 02:28:36 -0800 (PST) Received: from [192.168.0.36] ([78.16.251.63]) by smtp.gmail.com with ESMTPSA id e4-20020a5d5004000000b002c5706f7c6dsm1106981wrt.94.2023.02.16.02.28.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 02:28:35 -0800 (PST) Message-ID: Date: Thu, 16 Feb 2023 10:28:34 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 To: Ferruh Yigit , =?UTF-8?Q?Niklas_S=c3=b6derlund?= , "Xueming(Steven) Li" Cc: Chaoyong He , dev@dpdk.org, Luca Boccassi , oss-drivers@corigine.com, Peng Zhang , jin.liu@corigine.com, stable@dpdk.org References: <20230208091544.22122-1-chaoyong.he@corigine.com> <1856a555-e7d5-6dfa-6cf0-c4e170b81482@amd.com> From: Kevin Traynor Subject: Re: [PATCH] net/nfp: support 48-bit DMA address for firmware with NFDk In-Reply-To: <1856a555-e7d5-6dfa-6cf0-c4e170b81482@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 15/02/2023 18:28, Ferruh Yigit wrote: > On 2/15/2023 5:47 PM, Niklas Söderlund wrote: >> Hi Ferruh, >> >> Thanks for your continues effort in dealing with NFP patches. >> >> On 2023-02-15 13:42:01 +0000, Ferruh Yigit wrote: >>> On 2/8/2023 9:15 AM, Chaoyong He wrote: >>>> From: Peng Zhang >>>> >>>> 48-bit DMA address is supported in the firmware with NFDk, so enable >>>> this feature in PMD now. But the firmware with NFD3 still just >>>> support 40-bit DMA address. >>>> >>>> RX free list descriptor, used by both NFD3 and NFDk, is also modified >>>> to support 48-bit DMA address. That's OK because the top bits is always >>>> set to 0 when assigned with 40-bit DMA address. >>>> >>>> Fixes: c73dced48c8c ("net/nfp: add NFDk Tx") >>>> Cc: jin.liu@corigine.com >>>> Cc: stable@dpdk.org >>>> >>> >>> Why a backport is requested? As far as I understand this is not fixing >>> anything but extending device capability. Is this a fix? >> >> I agree this is a bit of a grey zone. We reasoned this was a fix as we >> should have done this from the start in the commit that added support >> for NFDk. Are you OK moving forward with this as a fix or would you >> prefer we resubmit without the request to backport? >> > > I am not sure, is this change have any potential to change behavior for > existing users? > Like if one of your user is using 22.11.1 release, and if this patch > backported to next LTS version, 22.11.2, will user notice any difference? > > > @Luca, @Kevin, what is your comment as LTS maintainers? > A bit difficult to know. If NFDk is not practicably usable without it, then it could be considered a fix. If it's just extending to add nice-to-have functionality then probably it is not a fix. It would need to ensure that it is tested on 22.11 branch and there are no regressions. It is only relevant to DPDK 22.11 LTS so Cc Xueming who will ultimately decide. A guide below on some things to consider for this type of backport is here: http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported >>> >>>> Signed-off-by: Peng Zhang >>>> Reviewed-by: Chaoyong He >>>> Reviewed-by: Niklas Söderlund >>> >> >