From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E78C45E2E for ; Wed, 4 Dec 2024 12:33:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8884140A87; Wed, 4 Dec 2024 12:33:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 461AA40A87 for ; Wed, 4 Dec 2024 12:33:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733311994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=odr4XjM3svEF3Kj+LWBSpAWId4iaqI2WcrQj0bwwP0g=; b=TW7l9Uhnbfx77cj2ZOGgG/tyq5wnuvxcWCk4uZ9YPTXYhzybJTOFRsRVYF+PefjBszbnM1 5lxE7KY6+hLaY+2bV0JJEjQl0ijlbniYfgV7mPXomsOD1/NzTwOu7nU0kzDwJlAj9WlTup XMk3CxJlUo9btd11dghXOuxUfmUZ03A= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-115-9-j914ygNFiyLPkDs0yvHg-1; Wed, 04 Dec 2024 06:33:13 -0500 X-MC-Unique: 9-j914ygNFiyLPkDs0yvHg-1 X-Mimecast-MFC-AGG-ID: 9-j914ygNFiyLPkDs0yvHg Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-434a467e970so47320635e9.2 for ; Wed, 04 Dec 2024 03:33:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733311992; x=1733916792; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=odr4XjM3svEF3Kj+LWBSpAWId4iaqI2WcrQj0bwwP0g=; b=hDRtGkidJIAjEnXLEy8Ybr1ERvgreNBldgJ3PM6/WwzAv6+NV7pd0KPm+1kewXLBls 0EBbT0+REE2L0MWb6l/WzI29yhl0172yqATNO5LEYH+AfawJxLp8wyUsRxO0AX4/hHLw 5yynfNgK5Xx54Lj3zbqwIqX6lVtU38ONjKTfUJb+ld4zRU68oY7rXTFc+vKBFRmiJQUI RyY1jhR7BMkO0TRktbjYAvBiZtEG9G4krhq1+vtW9hC6Q6FtF7LlLDrIEfM3gaO0dsD+ mLQBmseRJPrYsC1PSWc2twlo+qYlHuQblKXrC4UiuSJRJp+64XbR/fVsoRLPWPVM6LuK RupQ== X-Forwarded-Encrypted: i=1; AJvYcCWW5ep6jxbPFP/YmKUTl6CsFhr0Y/BVPtviH7EBSDeM/oDXiEopWURelPQ6SqpbFwPPFxry6M4=@dpdk.org X-Gm-Message-State: AOJu0Ywde0VN+BvWKsx91iHEGNQGnC9fk3FSIocdxLsajrI2ml5dAKBV 7DfvB71M6rQID3qvwd1hB6Z5iUJuIOkjDV3tC5z9ZNHHyvznxTeYhazCWsq+bLSV4aY3viOuS3C nl/pax7zYq+OLn5t4lBLsVm7HAnw9FhbMllVI1ZnTTbcK X-Gm-Gg: ASbGnctxHdk4EuqWteIR2q9IhrDAQlMOc17MVgRZGM6mW0S/RvLCiBlOJX5V1Y9bcGP 1RaEUlk1BgFzQyWYUkDqWDcbPiCx224tMkJ/g3Qsi+tdU/9jbalgFvFTO1H+V3kZCIBE7EnxwSX IzopFIjVvC2OmSKVmmACvSC4SotXPUBp6NSPOJ4yRtlxbs4AVytHgTljZ9+vYT+J0W3iJaxOa94 cTaXQE0vyvbg2tK+lSLRaPD88o+9ZusxfuNNY/2SWlMfSs3Ng== X-Received: by 2002:a05:600c:3151:b0:434:9936:c828 with SMTP id 5b1f17b1804b1-434d09b64e4mr55609825e9.12.1733311992426; Wed, 04 Dec 2024 03:33:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IERLaIXxUrMPoAM4vpjvz+KOwKP6w4jJdurRoh7zs/SWwNn8ImWXvzhvDOqBKPNs0AogvcZIQ== X-Received: by 2002:a05:600c:3151:b0:434:9936:c828 with SMTP id 5b1f17b1804b1-434d09b64e4mr55609605e9.12.1733311992025; Wed, 04 Dec 2024 03:33:12 -0800 (PST) Received: from [192.168.0.36] ([78.17.46.22]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434d52cbefasm21909105e9.43.2024.12.04.03.33.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2024 03:33:11 -0800 (PST) Message-ID: Date: Wed, 4 Dec 2024 11:33:09 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 21.11] common/mlx5: fix error CQE handling for 128 bytes CQE From: Kevin Traynor To: Alexander Kozyrev , "stable@dpdk.org" Cc: Slava Ovsiienko References: <20241127174839.1770671-1-akozyrev@nvidia.com> <4c30bab5-9f6f-4b68-a569-ab3e34cd27ad@redhat.com> Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: K5D_POHFxBJxxmRHPLDkuI7XcTkWEcvdUEiporoSBTg_1733311992 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 03/12/2024 19:17, Kevin Traynor wrote: > On 03/12/2024 19:08, Alexander Kozyrev wrote: >>> On 03/12/2024 18:43, Kevin Traynor wrote: >>>> On 27/11/2024 18:48, Alexander Kozyrev wrote: >>>>> [ upstream commit 3cddeba0ca38b00c7dc646277484d08a4cb2d862 ] >>>>> >>>>> The completion queue element size can be independently configured >>>>> to report either 64 or 128 bytes CQEs by programming cqe_sz parameter >>>>> at CQ creation. This parameter depends on the cache line size and >>>>> affects both regular CQEs and error CQEs. But the error handling >>>>> assumes that an error CQE is 64 bytes and doesn't take the padding >>>>> into consideration on platforms with 128-byte cache lines. >>>>> Fix the error CQE size in all error handling routines in mlx5. >>>>> >>>> Hi Alexander, >>>> >>>> This is causing a build error [1] on windows in the crypto code [2]. >>>> >>>> ref >>>> https://dpdkdashboard.iol.unh.edu/results/dashboard/testruns/logs/1475543/ >>>> >>>> I didn't spend time to analyse. If you have a fix I can apply, or else >>>> we can drop the patch. >>>> >>>> thanks, >>>> Kevin. >>>> >>>> [1] >>>> ../drivers/crypto/mlx5/mlx5_crypto.c >>>> ../drivers/crypto/mlx5/mlx5_crypto.c:480:52: error: incomplete >>>> definition of type 'struct mlx5_err_cqe' >>>> DRV_LOG(ERR, "CQE ERR:%x.\n", rte_be_to_cpu_32(cqe->syndrome)); >>>> ~~~^ >>>> [2] >>>> mlx5_crypto_cqe_err_handle(struct mlx5_crypto_qp *qp, struct >>>> rte_crypto_op *op) >>>> { >>>> const uint32_t idx = qp->ci & (qp->entries_n - 1); >>>> volatile struct mlx5_err_cqe *cqe = (volatile struct mlx5_err_cqe *) >>>> &qp->cq_obj.cqes[idx]; >>>> >>>> op->status = RTE_CRYPTO_OP_STATUS_ERROR; >>>> qp->stats.dequeue_err_count++; >>>> DRV_LOG(ERR, "CQE ERR:%x.\n", rte_be_to_cpu_32(cqe->syndrome)); >>>> } >>>> >>> >>> btw, the code that was run is ahead of the 21.11 branch. >>> >>> It is at: https://dpdk.org/git/dpdk-stable on branch 21.11-staging >> >> Sorry, somehow missed the crypto driver on 21.11. Attaching the proper patch. >> >> > > Thanks for the quick fix! I've pushed to the 21.11-staging branch and > the ci will be re-run overnight. > CI passed. Thanks for rebasing. Applied and pushed to 21.11 branch. Kevin. > thanks, > Kevin.