From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8A21A0524 for ; Tue, 1 Jun 2021 11:19:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C0A5C40041; Tue, 1 Jun 2021 11:19:35 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id 186CE40041 for ; Tue, 1 Jun 2021 11:19:34 +0200 (CEST) Received: from dggeme756-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FvRPC1fJ2zYmWG; Tue, 1 Jun 2021 17:16:47 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by dggeme756-chm.china.huawei.com (10.3.19.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 1 Jun 2021 17:19:30 +0800 To: Christian Ehrhardt , dpdk stable , Yisen Zhuang , Lijun Ou References: From: "Min Hu (Connor)" Message-ID: Date: Tue, 1 Jun 2021 17:19:30 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggeme756-chm.china.huawei.com (10.3.19.102) X-CFilter-Loop: Reflected Subject: Re: [dpdk-stable] "net/hns3: fix reporting undefined speed" is incompatible with 19.11.x X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi，Christian, Agreed, this patch can be abandoned in 19.11x， It can backport to 20.11.x. 在 2021/6/1 16:05, Christian Ehrhardt 写道: > Hi, > this was targeted for dpdk stable releases. > > commit b6579e3db794be36637a66e009199a1e7451e995 > Author: Huisong Li > Date: Tue Mar 23 21:45:51 2021 +0800 > > net/hns3: fix reporting undefined speed > > It introduced > > [ 403s] /home/abuild/rpmbuild/BUILD/dpdk-1622533160.757d17c4c/drivers/net/hns3/hns3_ethdev.c: > In function 'hns3_dev_link_update': > [ 403s] /home/abuild/rpmbuild/BUILD/dpdk-1622533160.757d17c4c/drivers/net/hns3/hns3_ethdev.c:2618:26: > error: 'ETH_SPEED_NUM_UNKNOWN' undeclared (first use in this function) > [ 403s] new_link.link_speed = ETH_SPEED_NUM_UNKNOWN; > [ 403s] ^ > > But that requires this change from 20.11: > > commit 810b17d116f03783843d23ac900a3794675f6616 > Author: Thomas Monjalon > Date: Tue Aug 11 11:52:20 2020 +0300 > > ethdev: allow unknown link speed > > I'm unsure if introducing ETH_SPEED_NUM_UNKNOWN in 19.11 might break > other bits not aware of it so for now I have removed that formerly > queued patch from 19.11.9. > > If you want it applied to 19.11.9 or later please have a look and > consider providing a backport for it - or alternatively if you think it > is not important for 19.11.x let me know about that. >