patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH 1/4] net/bnx2x: fix build with gcc11
@ 2021-05-10 15:03 Ferruh Yigit
  2021-05-10 15:03 ` [dpdk-stable] [PATCH 2/4] " Ferruh Yigit
                   ` (4 more replies)
  0 siblings, 5 replies; 25+ messages in thread
From: Ferruh Yigit @ 2021-05-10 15:03 UTC (permalink / raw)
  To: Rasesh Mody, Shahed Shaikh
  Cc: Ferruh Yigit, dev, stable, Kevin Traynor, Ajit Khaparde

Reproduced with '--buildtype=debugoptimized' config,
compiler version: gcc (GCC) 12.0.0 20210509 (experimental)

Build error:
In file included from ../drivers/net/bnx2x/bnx2x_rxtx.c:8:
../drivers/net/bnx2x/bnx2x_rxtx.c: In function ‘bnx2x_upd_rx_prod_fast’:
../drivers/net/bnx2x/bnx2x.h:1528:35:
    warning: ‘rx_prods’ is used uninitialized [-Wuninitialized]
 #define REG_WR32(sc, offset, val) bnx2x_reg_write32(sc, (offset), val)
                                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../drivers/net/bnx2x/bnx2x.h:1531:33:
	note: in expansion of macro ‘REG_WR32’
 1531 | #define REG_WR(sc, offset, val) REG_WR32(sc, offset, val)
      |                                 ^~~~~~~~
../drivers/net/bnx2x/bnx2x_rxtx.c:331:9:
	note: in expansion of macro ‘REG_WR’
  331 |         REG_WR(sc, fp->ustorm_rx_prods_offset, val[0]);
      |         ^~~~~~
../drivers/net/bnx2x/bnx2x_rxtx.c:324:40: note: ‘rx_prods’ declared here
  324 |         struct ustorm_eth_rx_producers rx_prods = { 0 };
      |                                        ^~~~~~~~

REG_WR32 requires 'uint32_t', use union instead of cast to 'uint32_t'.

Fixes: 38dff79ba736 ("net/bnx2x: update HSI")
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: rmody@marvell.com
Cc: Kevin Traynor <ktraynor@redhat.com>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnx2x/bnx2x_rxtx.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c
index 57e2ce504587..fdd6eeed8c1a 100644
--- a/drivers/net/bnx2x/bnx2x_rxtx.c
+++ b/drivers/net/bnx2x/bnx2x_rxtx.c
@@ -321,14 +321,15 @@ static inline void
 bnx2x_upd_rx_prod_fast(struct bnx2x_softc *sc, struct bnx2x_fastpath *fp,
 		uint16_t rx_bd_prod, uint16_t rx_cq_prod)
 {
-	struct ustorm_eth_rx_producers rx_prods = { 0 };
-	uint32_t *val = NULL;
+	union {
+		struct ustorm_eth_rx_producers rx_prods;
+		uint32_t val;
+	} val = { 0 };
 
-	rx_prods.bd_prod  = rx_bd_prod;
-	rx_prods.cqe_prod = rx_cq_prod;
+	val.rx_prods.bd_prod  = rx_bd_prod;
+	val.rx_prods.cqe_prod = rx_cq_prod;
 
-	val = (uint32_t *)&rx_prods;
-	REG_WR(sc, fp->ustorm_rx_prods_offset, val[0]);
+	REG_WR(sc, fp->ustorm_rx_prods_offset, val.val);
 }
 
 static uint16_t
-- 
2.31.1


^ permalink raw reply	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2021-05-12 13:04 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-10 15:03 [dpdk-stable] [PATCH 1/4] net/bnx2x: fix build with gcc11 Ferruh Yigit
2021-05-10 15:03 ` [dpdk-stable] [PATCH 2/4] " Ferruh Yigit
2021-05-10 15:03 ` [dpdk-stable] [PATCH 3/4] net/ice/base: " Ferruh Yigit
2021-05-10 17:04   ` [dpdk-stable] [dpdk-dev] " Wang, Haiyue
2021-05-10 17:13     ` Wang, Haiyue
2021-05-10 17:31       ` Ferruh Yigit
2021-05-10 17:55         ` Stillwell Jr, Paul M
2021-05-10 17:28     ` Ferruh Yigit
2021-05-11  1:59       ` Wang, Haiyue
2021-05-11  9:33         ` Ferruh Yigit
2021-05-11  9:08       ` Kevin Traynor
2021-05-10 15:03 ` [dpdk-stable] [PATCH 4/4] net/tap: " Ferruh Yigit
2021-05-11 12:28   ` [dpdk-stable] [dpdk-dev] " Kevin Traynor
2021-05-11 11:44 ` [dpdk-stable] [PATCH v2 1/4] net/bnx2x: " Ferruh Yigit
2021-05-11 11:44   ` [dpdk-stable] [PATCH v2 2/4] " Ferruh Yigit
2021-05-11 12:27     ` Kevin Traynor
2021-05-11 11:44   ` [dpdk-stable] [PATCH v2 3/4] net/ice/base: " Ferruh Yigit
2021-05-11 11:44   ` [dpdk-stable] [PATCH v2 4/4] net/tap: " Ferruh Yigit
2021-05-11 12:26   ` [dpdk-stable] [PATCH v2 1/4] net/bnx2x: " Kevin Traynor
2021-05-11 13:14 ` [dpdk-stable] [PATCH v3 " Ferruh Yigit
2021-05-11 13:14   ` [dpdk-stable] [PATCH v3 2/4] " Ferruh Yigit
2021-05-11 13:14   ` [dpdk-stable] [PATCH v3 3/4] net/ice/base: " Ferruh Yigit
2021-05-12  7:43     ` Wang, Haiyue
2021-05-11 13:14   ` [dpdk-stable] [PATCH v3 4/4] net/tap: " Ferruh Yigit
2021-05-12 13:04   ` [dpdk-stable] [PATCH v3 1/4] net/bnx2x: " Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).