patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ranjit Menon <ranjit.menon@intel.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, dev@dpdk.org
Cc: Olivier Matz <olivier.matz@6wind.com>,
	Bruce Richardson <bruce.richardson@intel.com>,
	stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] build: fix using ELF-only linker flags with COFF
Date: Wed, 13 Jan 2021 12:27:18 -0800	[thread overview]
Message-ID: <abda0119-628e-8874-d7ff-abc57265c0a8@intel.com> (raw)
In-Reply-To: <20210112003602.29004-1-dmitry.kozliuk@gmail.com>

On 1/11/2021 4:36 PM, Dmitry Kozlyuk wrote:
> The --export-dynamic linker option is only applicable to ELF.
> On Windows, where COFF is used, it causes warnings:
>
>      x86_64-w64-mingw32-ld: warning: --export-dynamic is not supported
>      for PE+ targets, did you mean --export-all-symbols? (MinGW)
>
>      LINK : warning LNK4044: unrecognized option '/-export-dynamic';
>      ignored (clang)
>
> Don't add --export-dynamic on Windows anywhere.
>
> Fixes: b031e13d7f0d ("build: fix plugin load on static build")
> Cc: stable@dpdk.org
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
> Using TLS variables with DLLs is problematic on Windows for now,
> so not attempting to check or solve the issue with plugin load.
>
>   app/meson.build                   | 2 +-
>   buildtools/pkg-config/meson.build | 6 +++++-
>   examples/meson.build              | 2 +-
>   3 files changed, 7 insertions(+), 3 deletions(-)

Acked-by: Ranjit Menon <ranjit.menon@intel.com>



  reply	other threads:[~2021-01-13 20:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12  0:36 [dpdk-stable] " Dmitry Kozlyuk
2021-01-13 20:27 ` Ranjit Menon [this message]
2021-01-13 20:55   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2021-01-14  9:27     ` Tal Shnaiderman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=abda0119-628e-8874-d7ff-abc57265c0a8@intel.com \
    --to=ranjit.menon@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).