From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62912A09E4 for ; Sun, 25 Apr 2021 04:07:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 527F94112E; Sun, 25 Apr 2021 04:07:42 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 9AF784013F; Sun, 25 Apr 2021 04:07:39 +0200 (CEST) IronPort-SDR: R4WeiOu6P2+4RlZyqUWPaMmuxdEI6a+y1bnzQMFN6+iqr6Qzrs5LWE4k1yHL2lundkS/8rj/nK wo1tHc4w1+ew== X-IronPort-AV: E=McAfee;i="6200,9189,9964"; a="260160270" X-IronPort-AV: E=Sophos;i="5.82,249,1613462400"; d="scan'208";a="260160270" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2021 19:07:38 -0700 IronPort-SDR: x/dnpzyBCCZbGfPfZslSuJGTjlwt7wzgaFqZeOT56rUhaiYYRCws6ABMwcab2ZutR9b/k5yZfQ SJh1yh7jPlYw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,249,1613462400"; d="scan'208";a="464721657" Received: from irsmsx605.ger.corp.intel.com ([163.33.146.138]) by orsmga001.jf.intel.com with ESMTP; 24 Apr 2021 19:07:37 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by IRSMSX605.ger.corp.intel.com (163.33.146.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Sun, 25 Apr 2021 03:07:35 +0100 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Sun, 25 Apr 2021 10:07:32 +0800 From: "Zhang, Qi Z" To: "Xu, Rosen" , "Huang, Wei" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Zhang, Tianfei" , "Yigit, Ferruh" Thread-Topic: [PATCH v1] raw/ifpga: fix ifpga device name format Thread-Index: AQHXN1IhlmxP/yopIE6imx0Db2ZfPaq/3EQAgASkbpA= Date: Sun, 25 Apr 2021 02:07:32 +0000 Message-ID: References: <20210422082716.4734-1-wei.huang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH v1] raw/ifpga: fix ifpga device name format X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Xu, Rosen > Sent: Thursday, April 22, 2021 7:13 PM > To: Huang, Wei ; dev@dpdk.org; Zhang, Qi Z > > Cc: stable@dpdk.org; Zhang, Tianfei ; Yigit, Fer= ruh > > Subject: RE: [PATCH v1] raw/ifpga: fix ifpga device name format >=20 > Hi, >=20 > > -----Original Message----- > > From: Huang, Wei > > Sent: Thursday, April 22, 2021 16:27 > > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > > > Cc: stable@dpdk.org; Zhang, Tianfei ; Yigit, > > Ferruh ; Huang, Wei > > Subject: [PATCH v1] raw/ifpga: fix ifpga device name format > > > > The device name format used in ifpga_rawdev_create() was changed to > > "IFPGA:%02x:%02x.%x", but the format used in ifpga_rawdev_destroy() > > was left as "IFPGA:%x:%02x.%x", it should be changed synchronously. > > > > Fixes: 9c006c45d0c5 ("raw/ifpga: scan PCIe BDF device tree") > > Cc: stable@dpdk.org > > > > Signed-off-by: Wei Huang > > --- > > drivers/raw/ifpga/ifpga_rawdev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/raw/ifpga/ifpga_rawdev.c > > b/drivers/raw/ifpga/ifpga_rawdev.c > > index d9a46ef915..f591a87b49 100644 > > --- a/drivers/raw/ifpga/ifpga_rawdev.c > > +++ b/drivers/raw/ifpga/ifpga_rawdev.c > > @@ -1551,7 +1551,7 @@ ifpga_rawdev_destroy(struct rte_pci_device > > *pci_dev) > > } > > > > memset(name, 0, sizeof(name)); > > -snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, "IFPGA:%x:%02x.%x", > > +snprintf(name, RTE_RAWDEV_NAME_MAX_LEN, > > "IFPGA:%02x:%02x.%x", > > pci_dev->addr.bus, pci_dev->addr.devid, pci_dev- > > >addr.function); > > > > IFPGA_RAWDEV_PMD_INFO("Closing %s on NUMA node %d", > > -- > > 2.29.2 >=20 > Acked-by: Rosen Xu Applied to dpdk-next-net-intel Thanks Qi