Re: [PATCH] app/testpmd: fix parsing for connection tracking item

[Ferruh Yigit <ferruh.yigit@amd.com>]

On 6/2/2024 11:23 AM, Maayan Kashani wrote:
> In command line translation there were missing fields for
> connection tracking item, as a result this item was not parsed
> and was missing from the items list received from test-pmd.
> 
> Fixes: 4d07cbefe3ba ("app/testpmd: add commands for conntrack")
> Cc: stable@dpdk.org
> Signed-off-by: Maayan Kashani <mkashani@nvidia.com>
>

Hi Maayan,

I can't really trace why .priv and 'parse_vc' is required, can you
please help understanding by providing more data?

What was the old testpmd command and what was old behavior with that
command, why it was wrong?
What is the new behavior and why this update was needed, how new code
solved the issue?

testpmd flow command is still somewhat cryptic to me, and without
running code and debugging it is very hard for me to detect the missing
parts.


> ---
>  app/test-pmd/cmdline_flow.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 60ee9337cf..1f9d5ebd05 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -5797,9 +5797,12 @@ static const struct token token_list[] = {
>  	[ITEM_CONNTRACK] = {
>  		.name = "conntrack",
>  		.help = "conntrack state",
> +		.priv = PRIV_ITEM(CONNTRACK,
> +				  sizeof(struct rte_flow_item_conntrack)),
>  		.next = NEXT(NEXT_ENTRY(ITEM_NEXT), NEXT_ENTRY(COMMON_UNSIGNED),
>  			     item_param),
>  		.args = ARGS(ARGS_ENTRY(struct rte_flow_item_conntrack, flags)),
> +		.call = parse_vc,
>  	},
>  	[ITEM_PORT_REPRESENTOR] = {
>  		.name = "port_representor",