From: Raslan Darawsheh <rasland@nvidia.com>
To: Rongwei Liu <rongweil@nvidia.com>,
dev@dpdk.org, matan@nvidia.com, viacheslavo@nvidia.com,
orika@nvidia.com, suanmingm@nvidia.com, thomas@monjalon.net
Cc: michaelba@nvidia.com, stable@dpdk.org,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Bing Zhao <bingz@nvidia.com>
Subject: Re: [PATCH v3] net/mlx5: fix age checking crash
Date: Thu, 16 Oct 2025 15:17:31 +0300 [thread overview]
Message-ID: <b41cbaeb-09e0-4333-98d8-4662fc7f515e@nvidia.com> (raw)
In-Reply-To: <20251009091810.174004-1-rongweil@nvidia.com>
Hi,
On 09/10/2025 12:18 PM, Rongwei Liu wrote:
> When aging is configured, there is a background thread
> which queries all the counters in the pool.
>
> Meantime, per queue flow insertion/deletion/update changes
> the counter pool too. It introduces a race condition between
> resetting counters's in_used and age_idx fields during flow deletion
> and reading them in the background thread.
>
> To resolve it, all key members of counter's struct
> are placed in a single uint32_t and they are accessed atomically.
>
> To avoid the occasional timestamp equalization with age_idx,
> query_gen_when_free is moved out of the union. The total memory
> size is kept the same.
>
> Fixes: 04a4de756e14 ("net/mlx5: support flow age action with HWS")
> Cc: michaelba@nvidia.com
> Cc: stable@dpdk.org
> Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
>
> v3: fix windows compilation error.
> v2: fix clang compilation error.
> ---
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
prev parent reply other threads:[~2025-10-16 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 6:29 [PATCH v2] " Rongwei Liu
2025-10-09 9:18 ` [PATCH v3] " Rongwei Liu
2025-10-16 12:17 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b41cbaeb-09e0-4333-98d8-4662fc7f515e@nvidia.com \
--to=rasland@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=michaelba@nvidia.com \
--cc=orika@nvidia.com \
--cc=rongweil@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).