patches for DPDK stable branches
 help / color / mirror / Atom feed
* [PATCH v3] net/vmxnet3: fix a missing vmxnet3 register command
@ 2024-04-22 18:10 Ronak Doshi
  2024-04-26 13:51 ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Ronak Doshi @ 2024-04-22 18:10 UTC (permalink / raw)
  To: Jochen Behrens, Ronak Doshi; +Cc: dev, Ronak Doshi, stable

Vmxnet3 uses capability registers to advertise the supported
capabilities of UPT device. It uses DCR0_REG command register
for this purpose. However, the register command enum misses
one command which technically is not used by dpdk vmxnet3
driver yet. This can cause issue for commands added later.
For example, DCR0_REG and MAX_CAPABILITIES register commands
when issued will lead to incorrect command being executed in
the hypervisor. The return values can be unexpected and can
result in some capabilities being disabled and affect vnics
requesting Uniform Passthroguh (UPT) mode.

This patch fixes this issue by adding a reserved
command in its place.

Fixes: 5241d61bd865 ("net/vmxnet3: support capability registers")
Cc: stable@dpdk.org

Signed-off-by: Ronak Doshi <ronak.doshi@broadcom.com>
--
Change log
 v2: fixed typo
 v3: updated commit message with more information
---
 drivers/net/vmxnet3/base/vmxnet3_defs.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/vmxnet3/base/vmxnet3_defs.h b/drivers/net/vmxnet3/base/vmxnet3_defs.h
index 24c235876e..a6bb281d8d 100644
--- a/drivers/net/vmxnet3/base/vmxnet3_defs.h
+++ b/drivers/net/vmxnet3/base/vmxnet3_defs.h
@@ -126,6 +126,7 @@ typedef enum {
    VMXNET3_CMD_RESERVED7,
    VMXNET3_CMD_RESERVED8,
    VMXNET3_CMD_GET_MAX_QUEUES_CONF,
+   VMXNET3_CMD_RESERVED11,
    VMXNET3_CMD_GET_MAX_CAPABILITIES,
    VMXNET3_CMD_GET_DCR0_REG,
 } Vmxnet3_Cmd;
-- 
2.11.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] net/vmxnet3: fix a missing vmxnet3 register command
  2024-04-22 18:10 [PATCH v3] net/vmxnet3: fix a missing vmxnet3 register command Ronak Doshi
@ 2024-04-26 13:51 ` Ferruh Yigit
  2024-04-26 13:55   ` Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Ferruh Yigit @ 2024-04-26 13:51 UTC (permalink / raw)
  To: Ronak Doshi, Jochen Behrens, Ronak Doshi; +Cc: dev, stable

On 4/22/2024 7:10 PM, Ronak Doshi wrote:
> Vmxnet3 uses capability registers to advertise the supported
> capabilities of UPT device. It uses DCR0_REG command register
> for this purpose. However, the register command enum misses
> one command which technically is not used by dpdk vmxnet3
> driver yet. This can cause issue for commands added later.
> For example, DCR0_REG and MAX_CAPABILITIES register commands
> when issued will lead to incorrect command being executed in
> the hypervisor. The return values can be unexpected and can
> result in some capabilities being disabled and affect vnics
> requesting Uniform Passthroguh (UPT) mode.
> 
> This patch fixes this issue by adding a reserved
> command in its place.
> 
> Fixes: 5241d61bd865 ("net/vmxnet3: support capability registers")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ronak Doshi <ronak.doshi@broadcom.com>
>

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v3] net/vmxnet3: fix a missing vmxnet3 register command
  2024-04-26 13:51 ` Ferruh Yigit
@ 2024-04-26 13:55   ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2024-04-26 13:55 UTC (permalink / raw)
  To: Jochen Behrens, Ajit Khaparde
  Cc: dev, stable, Thomas Monjalon, Ali Alnubani, Ronak Doshi

On 4/26/2024 2:51 PM, Ferruh Yigit wrote:
> On 4/22/2024 7:10 PM, Ronak Doshi wrote:
>> Vmxnet3 uses capability registers to advertise the supported
>> capabilities of UPT device. It uses DCR0_REG command register
>> for this purpose. However, the register command enum misses
>> one command which technically is not used by dpdk vmxnet3
>> driver yet. This can cause issue for commands added later.
>> For example, DCR0_REG and MAX_CAPABILITIES register commands
>> when issued will lead to incorrect command being executed in
>> the hypervisor. The return values can be unexpected and can
>> result in some capabilities being disabled and affect vnics
>> requesting Uniform Passthroguh (UPT) mode.
>>
>> This patch fixes this issue by adding a reserved
>> command in its place.
>>
>> Fixes: 5241d61bd865 ("net/vmxnet3: support capability registers")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ronak Doshi <ronak.doshi@broadcom.com>
>>
> 
> Applied to dpdk-next-net/main, thanks.
>

Hi Jochen, Ajit,

Independent from this patch.

Do you want to handle this driver in the next-net-brcm tree?

If so a maintainers file update and update to CI & patchwork script
required to select correct tree for driver.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-04-26 13:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-22 18:10 [PATCH v3] net/vmxnet3: fix a missing vmxnet3 register command Ronak Doshi
2024-04-26 13:51 ` Ferruh Yigit
2024-04-26 13:55   ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).