From: "Mattias Rönnblom" <hofors@lysator.liu.se>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: stable@dpdk.org, "Jerin Jacob" <jerinj@marvell.com>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: Re: [PATCH] eventdev: fix symbol export for port maintenance
Date: Wed, 11 Oct 2023 08:46:57 +0200 [thread overview]
Message-ID: <b4dc2135-22b7-4119-ba49-e42459322fb5@lysator.liu.se> (raw)
In-Reply-To: <20231010140029.66159-1-david.marchand@redhat.com>
On 2023-10-10 16:00, David Marchand wrote:
> Trying to call rte_event_maintain out of the eventdev library triggers
> a link failure, as the tracepoint symbol associated to this inline
> helper was not exported.
>
> Fixes: 54f17843a887 ("eventdev: add port maintenance API")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Caught by the CI when testing the dispatcher library.
> See for example:
> https://github.com/ovsrobot/dpdk/actions/runs/6460514355/job/17538348529#step:19:5506
>
> ---
> lib/eventdev/version.map | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
> index b03c10d99f..249eb115b1 100644
> --- a/lib/eventdev/version.map
> +++ b/lib/eventdev/version.map
> @@ -5,6 +5,7 @@ DPDK_24 {
> __rte_eventdev_trace_deq_burst;
> __rte_eventdev_trace_enq_burst;
> __rte_eventdev_trace_eth_tx_adapter_enqueue;
> + __rte_eventdev_trace_maintain;
> __rte_eventdev_trace_timer_arm_burst;
> __rte_eventdev_trace_timer_arm_tmo_tick_burst;
> __rte_eventdev_trace_timer_cancel_burst;
I can't say I know why it's needed, but the change seems consistent with
other Eventdev trace points.
Maybe Jerin can comment on this? If not, I can dig into the details.
next prev parent reply other threads:[~2023-10-11 6:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 14:00 David Marchand
2023-10-11 6:46 ` Mattias Rönnblom [this message]
2023-10-11 7:03 ` David Marchand
2023-10-11 7:21 ` David Marchand
2023-10-12 12:32 ` Jerin Jacob
2023-10-11 6:51 ` Jerin Jacob
2023-10-11 7:03 ` David Marchand
2023-10-11 12:11 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4dc2135-22b7-4119-ba49-e42459322fb5@lysator.liu.se \
--to=hofors@lysator.liu.se \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).