From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30B03A0548 for ; Wed, 16 Jun 2021 17:47:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 26A8040140; Wed, 16 Jun 2021 17:47:22 +0200 (CEST) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mails.dpdk.org (Postfix) with ESMTP id 4E85240140 for ; Wed, 16 Jun 2021 17:47:21 +0200 (CEST) Received: by mail-wr1-f49.google.com with SMTP id q5so3256057wrm.1 for ; Wed, 16 Jun 2021 08:47:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=aRPoIa77kYijFp98D6YlAHG8hoA3Ogp2wFEyVmacRZw=; b=qACmwQCsWBFXSvyReY6sqAziHLS65TTG5W1Imba6AQ7l8PkrBCPkNuOvosOs8zLqvG b/vksLE6cylV9KHe7bRxP8t3qcjSzrJO2OGMPeYix6suNdj/8CJR++/nSiluDhKFiawM fIuq5Lfz4/q4+8aFKgveRfNYA28F63jY58+/6IkY9G1crTJ20A1dlSIz081dC8BHVBZV ++LglfCpPy+53n5RpPRxzSPv78+CxnjP063ip85wciCliz+t/DUkczXTvJaPbyLFKIhk IS5pNaNxPMZkA/Umopc08CBzT/Ci63p4i4FHfmV8R9gAEPCbk+dgPBybKeepGqjp6rqg 1fGg== X-Gm-Message-State: AOAM530wA4ZgfhJ6tJZ0qjm/pKdP7obDn+7jKtw3vZUctCgwyDim4iTB OtmiIVfp9hTt7ADJHRiw1rk= X-Google-Smtp-Source: ABdhPJyHa8OcmzUI82PExGVR/gx6MJboo0g3clrlfWi12NvVM8rmMsMrsJonSMDDVZpqUzSt9IJLJg== X-Received: by 2002:adf:fb92:: with SMTP id a18mr84910wrr.182.1623858440213; Wed, 16 Jun 2021 08:47:20 -0700 (PDT) Received: from localhost ([137.220.125.106]) by smtp.gmail.com with ESMTPSA id o26sm2116402wms.27.2021.06.16.08.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Jun 2021 08:47:19 -0700 (PDT) Message-ID: From: Luca Boccassi To: Haiyue Wang , stable@dpdk.org Cc: xuemingl@nvidia.com, thomas@monjalon.net, christian.ehrhardt@canonical.com, ktraynor@redhat.com, qi.z.zhang@intel.com Date: Wed, 16 Jun 2021 16:47:19 +0100 In-Reply-To: <20210611071531.48411-1-haiyue.wang@intel.com> References: <20210611065825.47678-1-haiyue.wang@intel.com> <20210611071531.48411-1-haiyue.wang@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.2 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 20.11 v2 00/18] Backport the new VLAN design for Intel ice PMD X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, 2021-06-11 at 15:15 +0800, Haiyue Wang wrote: > When LTS 20.11 was released, the Intel ice PMD has a basic VLAN offload, > which can only handle single VLAN mode for firmware limitation. Now the > firmware is updated to support double VLAN mode and single VLAN mode at > the same time. It depends on the driver to do selection at the boot time. >=20 > As VLAN protocol handling like strip, filter, flow is very common use, we > request to support the ice PMD can run on the latest firmware for enablin= g > the new design. This is compatible backport as the main tree. >=20 > v2: Fix the subject fix with messy code like : PATCH=C3=82 >=20 > Haiyue Wang (4): > net/ice/base: do not set VLAN mode in DCF mode > net/ice: fix VLAN strip for double VLAN > net/ice: fix VLAN 0 adding based on VLAN mode > net/ice: update QinQ switch filter handling >=20 > Junfeng Guo (1): > net/ice: enable QinQ filter for switch >=20 > Qi Zhang (12): > net/ice/base: align add VSI and update VSI AQ command buffer > net/ice/base: add interface to support configuring VLAN mode > net/ice/base: fix outer VLAN related macro > net/ice/base: add VLAN TPID for VLAN filters > net/ice/base: support checking double VLAN mode > net/ice/base: support configuring device in double VLAN mode > net/ice/base: update boost TCAM for DVM > net/ice/base: change protocol ID for VLAN in DVM > net/ice/base: refactor post DDP download VLAN mode config > net/ice/base: log if DDP/FW do not support QinQ > net/ice/base: add inner VLAN protocol type for QinQ filter > net/ice/base: fix QinQ PPPoE dummy packet selection >=20 > Yuying Zhang (1): > net/ice/base: add ethertype offset for QinQ dummy packet >=20 > drivers/net/ice/base/ice_adminq_cmd.h | 268 ++++++++----- > drivers/net/ice/base/ice_bitops.h | 45 +++ > drivers/net/ice/base/ice_common.c | 38 ++ > drivers/net/ice/base/ice_common.h | 4 + > drivers/net/ice/base/ice_flex_pipe.c | 302 +++++++++++++-- > drivers/net/ice/base/ice_flex_pipe.h | 12 + > drivers/net/ice/base/ice_flex_type.h | 39 ++ > drivers/net/ice/base/ice_protocol_type.h | 1 + > drivers/net/ice/base/ice_switch.c | 124 +++++- > drivers/net/ice/base/ice_switch.h | 15 + > drivers/net/ice/base/ice_type.h | 4 + > drivers/net/ice/base/ice_vlan_mode.c | 451 ++++++++++++++++++++++ > drivers/net/ice/base/ice_vlan_mode.h | 16 + > drivers/net/ice/base/meson.build | 1 + > drivers/net/ice/ice_ethdev.c | 455 +++++++++++++---------- > drivers/net/ice/ice_ethdev.h | 10 +- > drivers/net/ice/ice_generic_flow.c | 8 + > drivers/net/ice/ice_generic_flow.h | 1 + > drivers/net/ice/ice_switch_filter.c | 114 +++++- > 19 files changed, 1545 insertions(+), 363 deletions(-) > create mode 100644 drivers/net/ice/base/ice_vlan_mode.c > create mode 100644 drivers/net/ice/base/ice_vlan_mode.h Hi, At 1.9k diffstat, this series is quite large. Given it's a new feature, rather than a series of bug fixes, this would seem a bit risky to me. Final word of course belongs to Xueming, since he's managing this one. See: https://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be= -backported --=20 Kind regards, Luca Boccassi