From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B44EA04B7 for ; Tue, 13 Oct 2020 12:32:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 326B31D9F3; Tue, 13 Oct 2020 12:32:41 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2E87A1D9CF; Tue, 13 Oct 2020 12:32:36 +0200 (CEST) IronPort-SDR: /1ceY/qmuLoLpc+uGK9PuDsWFEvKgyPErvSzt+TSjngdYst0R0niHLlLwVEQk5TuVoYpjvq0GQ Pc5XTq6tx4Mw== X-IronPort-AV: E=McAfee;i="6000,8403,9772"; a="183362264" X-IronPort-AV: E=Sophos;i="5.77,370,1596524400"; d="scan'208";a="183362264" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 03:32:32 -0700 IronPort-SDR: ifcHnYmD0BQMBUTnLfVQ7vkAxw3X3ZIgTrEwlN4aKcGTiiJ2Ikl3jNOpXdq1x+IH1McOyijJKj eqAkFfzmFD+A== X-IronPort-AV: E=Sophos;i="5.77,370,1596524400"; d="scan'208";a="530341617" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.214.64]) ([10.213.214.64]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 03:32:29 -0700 To: Honnappa Nagarahalli , dev@dpdk.org, phil.yang@arm.com, thomas@monjalon.net, arybchenko@solarflare.com, ZY Qiu , Konstantin Ananyev , "jerinj@marvell.com" Cc: abhinandan.gujjar@intel.com, nd@arm.com, bruce.richardson@intel.com, john.mcnamara@intel.com, reshma.pattan@intel.com, stable@dpdk.org References: <20201002000711.41511-1-honnappa.nagarahalli@arm.com> <20201002000711.41511-2-honnappa.nagarahalli@arm.com> From: Ferruh Yigit Message-ID: Date: Tue, 13 Oct 2020 11:32:28 +0100 MIME-Version: 1.0 In-Reply-To: <20201002000711.41511-2-honnappa.nagarahalli@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] [PATCH 2/2] lib/ethdev: fix memory ordering for call back functions X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 10/2/2020 1:07 AM, Honnappa Nagarahalli wrote: > Call back functions are registered on the control plane. They > are accessed from the data plane. Hence, correct memory orderings > should be used to avoid race conditions. > > Fixes: 4dc294158cac ("ethdev: support optional Rx and Tx callbacks") > Fixes: c8231c63ddcb ("ethdev: insert Rx callback as head of list") > Cc: bruce.richardson@intel.com > Cc: john.mcnamara@intel.com > Cc: reshma.pattan@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Ola Liljedahl +Konstantin & Jerin, Can you please help reviewing this one too? @Honnappa, Is this patch supersedes the following one in the queue by ZY Qiu: https://patches.dpdk.org/patch/66301/