* [PATCH] net/ena: fix deadlock in RSS reta update
@ 2023-01-05 13:57 David Marchand
2023-01-05 14:05 ` Zhang, Fan
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2023-01-05 13:57 UTC (permalink / raw)
To: dev
Cc: stable, Marcin Wojtas, Michal Krawczyk, Shai Brandes,
Evgeny Schemeilin, Igor Chauskin, Stanislaw Kardach,
Dawid Gorecki
Add missing lock release in case of internal failure.
Fixes: e3595539e0e0 ("net/ena: proxy AQ calls to primary process")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/ena/ena_rss.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ena/ena_rss.c b/drivers/net/ena/ena_rss.c
index b682d01c20..d0ba9d5c0a 100644
--- a/drivers/net/ena/ena_rss.c
+++ b/drivers/net/ena/ena_rss.c
@@ -105,6 +105,7 @@ int ena_rss_reta_update(struct rte_eth_dev *dev,
if (unlikely(rc != 0)) {
PMD_DRV_LOG(ERR,
"Cannot fill indirection table\n");
+ rte_spinlock_unlock(&adapter->admin_lock);
return rc;
}
}
--
2.39.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/ena: fix deadlock in RSS reta update
2023-01-05 13:57 [PATCH] net/ena: fix deadlock in RSS reta update David Marchand
@ 2023-01-05 14:05 ` Zhang, Fan
2023-01-06 20:58 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Fan @ 2023-01-05 14:05 UTC (permalink / raw)
To: David Marchand, dev
Cc: stable, Marcin Wojtas, Michal Krawczyk, Shai Brandes,
Evgeny Schemeilin, Igor Chauskin, Stanislaw Kardach,
Dawid Gorecki
On 1/5/2023 1:57 PM, David Marchand wrote:
> Add missing lock release in case of internal failure.
>
> Fixes: e3595539e0e0 ("net/ena: proxy AQ calls to primary process")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> drivers/net/ena/ena_rss.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ena/ena_rss.c b/drivers/net/ena/ena_rss.c
> index b682d01c20..d0ba9d5c0a 100644
> --- a/drivers/net/ena/ena_rss.c
> +++ b/drivers/net/ena/ena_rss.c
> @@ -105,6 +105,7 @@ int ena_rss_reta_update(struct rte_eth_dev *dev,
> if (unlikely(rc != 0)) {
> PMD_DRV_LOG(ERR,
> "Cannot fill indirection table\n");
> + rte_spinlock_unlock(&adapter->admin_lock);
> return rc;
> }
> }
Acked-by: Fan Zhang <fanzhang.oss@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/ena: fix deadlock in RSS reta update
2023-01-05 14:05 ` Zhang, Fan
@ 2023-01-06 20:58 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2023-01-06 20:58 UTC (permalink / raw)
To: Zhang, Fan, David Marchand, dev
Cc: stable, Marcin Wojtas, Michal Krawczyk, Shai Brandes,
Evgeny Schemeilin, Igor Chauskin, Stanislaw Kardach,
Dawid Gorecki
On 1/5/2023 2:05 PM, Zhang, Fan wrote:
>
> On 1/5/2023 1:57 PM, David Marchand wrote:
>> Add missing lock release in case of internal failure.
>>
>> Fixes: e3595539e0e0 ("net/ena: proxy AQ calls to primary process")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>> ---
>> drivers/net/ena/ena_rss.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/ena/ena_rss.c b/drivers/net/ena/ena_rss.c
>> index b682d01c20..d0ba9d5c0a 100644
>> --- a/drivers/net/ena/ena_rss.c
>> +++ b/drivers/net/ena/ena_rss.c
>> @@ -105,6 +105,7 @@ int ena_rss_reta_update(struct rte_eth_dev *dev,
>> if (unlikely(rc != 0)) {
>> PMD_DRV_LOG(ERR,
>> "Cannot fill indirection table\n");
>> + rte_spinlock_unlock(&adapter->admin_lock);
>> return rc;
>> }
>> }
> Acked-by: Fan Zhang <fanzhang.oss@gmail.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-06 20:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-05 13:57 [PATCH] net/ena: fix deadlock in RSS reta update David Marchand
2023-01-05 14:05 ` Zhang, Fan
2023-01-06 20:58 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).