From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B24D7A00C4 for ; Fri, 6 Jan 2023 21:58:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A983C40A82; Fri, 6 Jan 2023 21:58:37 +0100 (CET) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2070.outbound.protection.outlook.com [40.107.92.70]) by mails.dpdk.org (Postfix) with ESMTP id CE0F9400EF; Fri, 6 Jan 2023 21:58:35 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xz4s+umOj7+XiVWehef2RHwfAKkTnw21VvlpOod/cFokNUx1QNa8SxDWRfqXmlAoh+SHpzjG0q/hX0TisNepAbpJaDwKhwychMw/wK9AA84YSdjOOUPGHTRWsuGC6kFywJl79ItDUFYbH5pbcCEoTEzSz14spQCnBmtHWnz33xLhDM+6TtsizAjU5CSAEoHNYUe0CNywn/rwj6lQSCGim9mtfr+bLH8+38w7wKtaS/RZ7dBpyk6z3fNkDQlkLlf6wdq4eeWLnGYWnUzg7nMosIAtofV/iJZkJ+ToZC7wvR3y2SxAfMVJUPgoAtSbduODCRNX0TM+Tj4yoQ0c+07GKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AVLrAWWGrdDPXPYye1FD+AmoCTZL0b9hL9LxE9A7Ur4=; b=SCn60JDfYvQ5jp3Lnycj5QW0LRR6rcblcdQA+SqOS4ln3qrb5VpxUD6aeuY2iQ2jjvdw4mlqiLNqGvdmLveAqDojuLa2kB2v9v+Ghi4D/ex5tq+lL+r1oRXE9BlspVZojCsoH8Sa/fMy/1JBnWjQPAFlKA/7XUEVmIee7MEeGUdxvq2CbD8ntDazVFYyMRjwfnBqk1IoR9vnL+XD5V3kCvaTnCZ4s4F3VtpKtebjxb6iLvE+kHTZc3L+D143Dw+saW4rZ1y0rS1R9jU30wloUQ9exrRwr5p4paMIwAM44ALfUCPwAOrvSC8NOJdwZIPke48/gXsROsB3//RCUdf6JQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AVLrAWWGrdDPXPYye1FD+AmoCTZL0b9hL9LxE9A7Ur4=; b=TwgiyFuoSCOawlZDSuPOdDqwCEbj545XM/nBgapFEb91FoixuMhczylPFV+AFvlboLwEGQa3Qd2RwKNGah6ffsf78tCZbxNr8UrXxBhRjqlPP3wUgJskYsRjwUAaSP6lQcwf2z6bv9WzIPGeUO5CVRjMi1HITBpCkXJG7eJ99Jo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CY5PR12MB6036.namprd12.prod.outlook.com (2603:10b6:930:2c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 20:58:33 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::4807:1f44:5e04:e05a%9]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 20:58:33 +0000 Message-ID: Date: Fri, 6 Jan 2023 20:58:26 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] net/ena: fix deadlock in RSS reta update To: "Zhang, Fan" , David Marchand , dev@dpdk.org Cc: stable@dpdk.org, Marcin Wojtas , Michal Krawczyk , Shai Brandes , Evgeny Schemeilin , Igor Chauskin , Stanislaw Kardach , Dawid Gorecki References: <20230105135733.4162954-1-david.marchand@redhat.com> <4d77aa17-5ea7-cdd7-fc5b-308348b2f3c2@gmail.com> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <4d77aa17-5ea7-cdd7-fc5b-308348b2f3c2@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0433.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a9::6) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CY5PR12MB6036:EE_ X-MS-Office365-Filtering-Correlation-Id: 7437120d-fb6c-4765-bb9a-08daf028c5cc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x9QP6dbrsoyTKFG1EouLQvMG2XqqlsNmCH4NiMzdS6HvV7708PnItSIfuRnsj+Qrw4dtIJK17fmvBqlg2sqk2Cs5rI4vR+gw4w6bokhaR81o7/ml+5pLpiWe+ML9Utf6m4LRGfDGgeGP5c2ukIyeazhyID85U2PPGHIKIUdjbwHXUvCY1pYjGSPJ3v0Mn9j/cD2nAleCNxBVOXuvM83c9hg9ykTtVB5BbYp6GuugiAW/mxQ4bSaQLTvbZJcTrOMJEdSbnrfjn2srSIsPVdOzerOIjdw3M/3b7xw604i2gmFMfWimXmBZB1srwA9++bJRmTmJEgkZf4psTxkIL2szHNybNWA1mzcio7E3OGskxr5BRmT43HBZHXa5uPfCWo0k+lL8vQjBauM0Vqh8W1kTNteyBrk3wTKR6sTmYU8bbJ4C3JAzu0sPJMJlX1sKbC+P+hJFtS0s+ZMJT61vud8mKWgKZuU087vyyh5lqePSi2LBsEEzybRWEZeM1TAWwSPrsBRrEwpxHLqPhZDJ4glWQuUtu2jB9TqV4CYQjmL9v+iuqzPXwUNQkTu3S0Q3VZtigU3o5HwCogUnTzPOV8kXauchbe6BoYBeqQYjk/Iwu+hYIB2XFjoariZmcGopQHGXvRIY0qSKACIarEpAl5FdMCyGKzuGrQcEADCCTHqv9q34u52ioO9YdALq15oj2jZEb5F0p2g6A3i8GbGrSqKBU/QTSfw1pAKBHLu+zowJDqI= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(346002)(396003)(39860400002)(136003)(376002)(366004)(451199015)(8676002)(4326008)(66476007)(5660300002)(6666004)(66946007)(41300700001)(8936002)(7416002)(66556008)(316002)(110136005)(54906003)(2906002)(478600001)(6486002)(6506007)(38100700002)(26005)(186003)(6512007)(2616005)(53546011)(4744005)(31696002)(31686004)(44832011)(36756003)(83380400001)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFFHdHpCdGJaT2dIazlxNlVJbml5cFBUdENSdFpSMjg3dmZ6aUhNUkZRa1Rn?= =?utf-8?B?NWpOYzdQcHpVYjEvY0haQ1hTcU5vQXNZUDZsaXpXUFp3dWtOWitiaytNeXQz?= =?utf-8?B?QTN2QWUvaGNDMWI2ZTFxT3F2aWk3STFYVHVzWCs5YXNhZ1ZIZjBPQXg5a0FC?= =?utf-8?B?bEh1ZER5MG51TW5MOW50K0llVC9GTTI0OG1XMTRJZ0FwN1ZKK3cxMWhOYjMw?= =?utf-8?B?RmJPZU9iYTNlNVJDajNVZ0ZBclpLVFB6N2RhTkV4V0hIa1lmQTEzUzZ4cDcr?= =?utf-8?B?dE9OUGdjeU9zeVBTV20yK1NzME1DQVlkY3J2d3IrQmltc05MOGpqcm9zVisv?= =?utf-8?B?eCt2dExKZmpUK01JVXJRVnFESVZSUTNvQjZMWmxtTGFhaTdhZXA2YVZ1QUh4?= =?utf-8?B?Y0xDVFJwd25obWQ3VUhHRnRBdUxnQ2NuR1I0K0x5V3VHdEUwZjFVNUNFUTIy?= =?utf-8?B?aWJtc0gxVVhEUVA1Zlpha2tUaW12ajg5aUUxczhOZlBuWDZoczBucVhNdmpR?= =?utf-8?B?L2ZyMUpsNUt3VDVIcnM2Q3hFM2ZPRVVrUVF1b0ZqV0M3aGZ1YS9SdU1qVTZB?= =?utf-8?B?TnNKSVdLQ3RRb1dzQlk3bU8xZjgrZFF6RG02WCtMem1vVy91elYraXVad1kv?= =?utf-8?B?RGpIUWpwMkM3QmlvQk5EeGZqQWxXUmlQMGNzYXNUbHVnSFJmRFk5amlnN0Q5?= =?utf-8?B?SGEvL1M0Z3hma3dodUx0TTNEWjk2YnhVdDYydkhOUzVuWnViQUdkVno4TWN5?= =?utf-8?B?dVU1V0x1dzNLUXFvcUhXN2owbWFFMDIyZTMwR0V5MU9jZTdqU3lrOHVFT0Yw?= =?utf-8?B?N0tHUE4zUHJYbWVyUk1HSWJ5Z3loWHFoVURQKzZ3TEVQWUN3bFN1REsveEdr?= =?utf-8?B?MS8rbkRBcHljdHZ1NHBhZjZTdnhnTjNzYmxKeUVHbFVydmZYWmRRMnQ5a3h2?= =?utf-8?B?WVJWSGZZNG9ROG1zQk9nOVBCa3VXNzlLS0NKZ2E4aGhxeTk0Yk85SmtQZ0RH?= =?utf-8?B?Q3oxT0o0aTJMNis0bC9ySDc5SVBxYm5GL01UanFablljaDg0M09BSXBtUUFC?= =?utf-8?B?bnUwS2NHempCWTBkbERzVncwRiticXA2MWluRUJ1amdLYTdESFROeHpNdmJ6?= =?utf-8?B?YVJlVkp2Z2R6VVNKR3VWU1FWaG9ENDliVDlGWDBaRjlxTFovTGR6ckVGdEov?= =?utf-8?B?SnVCcGFzZEE4ZDFONWUvUmRTVVF1T1lxUHBxTUVlUk0xN1BObEtXL3BDYzl3?= =?utf-8?B?dEdyeVBKNmZDL0xKdzY1N0drUlQ3OUZHM1ZXelUwTFFIMTRkcnBqa0JsV050?= =?utf-8?B?NVBBMElKWWNNazlMZ1RjTTBYKy9QYnU1NG9lM3FUajFZYlhtMzlleExaKzF3?= =?utf-8?B?WDVVMlBhQW5Ed29DMUZKeTVDbmJTckhrT01OZE5QMHE0d2d5R0F1OEFzdHpW?= =?utf-8?B?TWVnVCt5YWQwTS81aC83cTJaeldqZ0dQeitKSG5iUk9WcjFlcE15NlBOVGlE?= =?utf-8?B?STBwREhVLy9FdTBra1VKaEpaTmYrOVAxREZwdVBoZnd1NmJUMzI2MjFiVDVt?= =?utf-8?B?cVhzTDBmcVVKNWNaaXNoMk1Bdk9CbzY0QnpoSXprWVcrM2pURVJ1U1o1NXVj?= =?utf-8?B?anZJOGlsemdDMHc2aStsM0JYMUx2OHY1dXhWQ00wd3p3MFpQZ25HMjlZVUsy?= =?utf-8?B?NHQzTUFXd2ROSWIrRFVMeUZYN0JKMUVERmh4aGsrdGRkOFkrcGVxT3N0V1Fv?= =?utf-8?B?b0ZFTHZ0YUNMYzRkU2FNdTIrYklOTTE1LzBQcU9sQ3pWQmFVK2FTdUNiakhr?= =?utf-8?B?aHJZeWRyTkhpYlROSXNVa0YzZFhhRWtpVkxSb3c4dURDdkZhamg0b0pXWEJw?= =?utf-8?B?RlVuSHdKOENmYnJEMExEUGc5NDBnMFhBdHRrQlhXVFpmMkd4VU40eW5NR3U2?= =?utf-8?B?eitwVzYzUDVRQ2lyUTFadzFPNXM0eVJybjFvdEFXeGE2UnBzYkZ3QTJRdmly?= =?utf-8?B?YmhKL1k2ZEVHOXJvbFZtY3RmTmdsUVJvUldDTThta0ZMdzZ4bUIvT3V2RXVX?= =?utf-8?B?WDRZZGxZTFhmNkVyck1BZ3VrLzFsYlNmdzM2SUVRaVA5aDFxbTJPSXJodTRE?= =?utf-8?Q?xr+G2i8q41gOtvgzUT/deIgJp?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7437120d-fb6c-4765-bb9a-08daf028c5cc X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jan 2023 20:58:33.6733 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B7LDjQL89QMyZXKLfLr02RjqsHLGC42rL3fUxamCw/HtPaOEekfAneUA2avW3cU4 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6036 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 1/5/2023 2:05 PM, Zhang, Fan wrote: > > On 1/5/2023 1:57 PM, David Marchand wrote: >> Add missing lock release in case of internal failure. >> >> Fixes: e3595539e0e0 ("net/ena: proxy AQ calls to primary process") >> Cc: stable@dpdk.org >> >> Signed-off-by: David Marchand >> --- >>   drivers/net/ena/ena_rss.c | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/ena/ena_rss.c b/drivers/net/ena/ena_rss.c >> index b682d01c20..d0ba9d5c0a 100644 >> --- a/drivers/net/ena/ena_rss.c >> +++ b/drivers/net/ena/ena_rss.c >> @@ -105,6 +105,7 @@ int ena_rss_reta_update(struct rte_eth_dev *dev, >>               if (unlikely(rc != 0)) { >>                   PMD_DRV_LOG(ERR, >>                       "Cannot fill indirection table\n"); >> +                rte_spinlock_unlock(&adapter->admin_lock); >>                   return rc; >>               } >>           } > Acked-by: Fan Zhang Applied to dpdk-next-net/main, thanks.