patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] net/i40e: fix register setting for hash enable
@ 2021-01-26  9:52 dapengx.yu
  2021-01-27  1:44 ` Xing, Beilei
  2021-01-27  3:07 ` Xing, Beilei
  0 siblings, 2 replies; 5+ messages in thread
From: dapengx.yu @ 2021-01-26  9:52 UTC (permalink / raw)
  To: beilei.xing, jia.guo; +Cc: dev, Dapeng Yu, stable

From: Dapeng Yu <dapengx.yu@intel.com>

The original code causes wrong value to be set into PFQF_HENA
register because unnecessary calling to get translated pctype
value for X722 NIC. The result is RSS cannot work.

So remove the unnecessary translation.

Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow")
Cc: stable@dpdk.org

Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
---
 drivers/net/i40e/i40e_hash.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c
index 9271797a7..b1cb24f43 100644
--- a/drivers/net/i40e/i40e_hash.c
+++ b/drivers/net/i40e/i40e_hash.c
@@ -678,10 +678,6 @@ i40e_hash_enable_pctype(struct i40e_hw *hw,
 {
 	uint32_t reg, reg_val, mask;
 
-	/* For X722, get translated pctype in fd pctype register */
-	if (hw->mac.type == I40E_MAC_X722)
-		pctype = i40e_read_rx_ctl(hw, I40E_GLQF_FD_PCTYPES(pctype));
-
 	if (pctype < 32) {
 		mask = BIT(pctype);
 		reg = I40E_PFQF_HENA(0);
-- 
2.27.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] [PATCH] net/i40e: fix register setting for hash enable
  2021-01-26  9:52 [dpdk-stable] [PATCH] net/i40e: fix register setting for hash enable dapengx.yu
@ 2021-01-27  1:44 ` Xing, Beilei
  2021-01-27  2:16   ` Yu, DapengX
  2021-01-27  3:07 ` Xing, Beilei
  1 sibling, 1 reply; 5+ messages in thread
From: Xing, Beilei @ 2021-01-27  1:44 UTC (permalink / raw)
  To: Yu, DapengX, Guo, Jia; +Cc: dev, Yu, DapengX, stable



> -----Original Message-----
> From: dapengx.yu@intel.com <dapengx.yu@intel.com>
> Sent: Tuesday, January 26, 2021 5:52 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; Yu, DapengX <dapengx.yu@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/i40e: fix register setting for hash enable
> 
> From: Dapeng Yu <dapengx.yu@intel.com>
> 
> The original code causes wrong value to be set into PFQF_HENA register
> because unnecessary calling to get translated pctype value for X722 NIC. The
> result is RSS cannot work.
> 
> So remove the unnecessary translation.
> 
> Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
> ---
>  drivers/net/i40e/i40e_hash.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c index
> 9271797a7..b1cb24f43 100644
> --- a/drivers/net/i40e/i40e_hash.c
> +++ b/drivers/net/i40e/i40e_hash.c
> @@ -678,10 +678,6 @@ i40e_hash_enable_pctype(struct i40e_hw *hw,  {
>  	uint32_t reg, reg_val, mask;
> 
> -	/* For X722, get translated pctype in fd pctype register */
> -	if (hw->mac.type == I40E_MAC_X722)
> -		pctype = i40e_read_rx_ctl(hw,
> I40E_GLQF_FD_PCTYPES(pctype));
> -

Did you check the latest X722 datasheet to confirm the behavior?

>  	if (pctype < 32) {
>  		mask = BIT(pctype);
>  		reg = I40E_PFQF_HENA(0);
> --
> 2.27.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] [PATCH] net/i40e: fix register setting for hash enable
  2021-01-27  1:44 ` Xing, Beilei
@ 2021-01-27  2:16   ` Yu, DapengX
  0 siblings, 0 replies; 5+ messages in thread
From: Yu, DapengX @ 2021-01-27  2:16 UTC (permalink / raw)
  To: Xing, Beilei, Guo, Jia; +Cc: dev, stable

Hi Beilei,

The pctype translation is introduced by i40e RSS refactor commit: ef4c16fd9148 by mistake, its behavior is inconsistent with the implementation before the refactor. 

This inconsistency can be gotten from the comparison of the running of the code.

I have also confirmed with the author of commit: ef4c16fd9148 that the adding of the translation is a mistake. 

So actually even if without x722 datasheet, we can know the translation is unnecessary.

I cannot find x722 datasheet from Intel website. It will be great if you can share one. Thanks!

-----Original Message-----
From: Xing, Beilei 
Sent: Wednesday, January 27, 2021 9:44 AM
To: Yu, DapengX <dapengx.yu@intel.com>; Guo, Jia <jia.guo@intel.com>
Cc: dev@dpdk.org; Yu, DapengX <dapengx.yu@intel.com>; stable@dpdk.org
Subject: RE: [PATCH] net/i40e: fix register setting for hash enable



> -----Original Message-----
> From: dapengx.yu@intel.com <dapengx.yu@intel.com>
> Sent: Tuesday, January 26, 2021 5:52 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; Yu, DapengX <dapengx.yu@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/i40e: fix register setting for hash enable
> 
> From: Dapeng Yu <dapengx.yu@intel.com>
> 
> The original code causes wrong value to be set into PFQF_HENA register 
> because unnecessary calling to get translated pctype value for X722 
> NIC. The result is RSS cannot work.
> 
> So remove the unnecessary translation.
> 
> Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
> ---
>  drivers/net/i40e/i40e_hash.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_hash.c 
> b/drivers/net/i40e/i40e_hash.c index
> 9271797a7..b1cb24f43 100644
> --- a/drivers/net/i40e/i40e_hash.c
> +++ b/drivers/net/i40e/i40e_hash.c
> @@ -678,10 +678,6 @@ i40e_hash_enable_pctype(struct i40e_hw *hw,  {  
> uint32_t reg, reg_val, mask;
> 
> -/* For X722, get translated pctype in fd pctype register */ -if 
> (hw->mac.type == I40E_MAC_X722) -pctype = i40e_read_rx_ctl(hw, 
> I40E_GLQF_FD_PCTYPES(pctype));
> -

Did you check the latest X722 datasheet to confirm the behavior?

>  if (pctype < 32) {
>  mask = BIT(pctype);
>  reg = I40E_PFQF_HENA(0);
> --
> 2.27.0



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] [PATCH] net/i40e: fix register setting for hash enable
  2021-01-26  9:52 [dpdk-stable] [PATCH] net/i40e: fix register setting for hash enable dapengx.yu
  2021-01-27  1:44 ` Xing, Beilei
@ 2021-01-27  3:07 ` Xing, Beilei
  2021-01-28 13:31   ` Zhang, Qi Z
  1 sibling, 1 reply; 5+ messages in thread
From: Xing, Beilei @ 2021-01-27  3:07 UTC (permalink / raw)
  To: Yu, DapengX, Guo, Jia; +Cc: dev, Yu, DapengX, stable



> -----Original Message-----
> From: dapengx.yu@intel.com <dapengx.yu@intel.com>
> Sent: Tuesday, January 26, 2021 5:52 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; Yu, DapengX <dapengx.yu@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/i40e: fix register setting for hash enable
> 
> From: Dapeng Yu <dapengx.yu@intel.com>
> 
> The original code causes wrong value to be set into PFQF_HENA register
> because unnecessary calling to get translated pctype value for X722 NIC. The
> result is RSS cannot work.
> 
> So remove the unnecessary translation.
> 
> Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>

Acked-by: Beilei Xing <beilei.xing@intel.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-stable] [PATCH] net/i40e: fix register setting for hash enable
  2021-01-27  3:07 ` Xing, Beilei
@ 2021-01-28 13:31   ` Zhang, Qi Z
  0 siblings, 0 replies; 5+ messages in thread
From: Zhang, Qi Z @ 2021-01-28 13:31 UTC (permalink / raw)
  To: Xing, Beilei, Yu, DapengX, Guo, Jia; +Cc: dev, Yu, DapengX, stable



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xing, Beilei
> Sent: Wednesday, January 27, 2021 11:08 AM
> To: Yu, DapengX <dapengx.yu@intel.com>; Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; Yu, DapengX <dapengx.yu@intel.com>; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix register setting for hash enable
> 
> 
> 
> > -----Original Message-----
> > From: dapengx.yu@intel.com <dapengx.yu@intel.com>
> > Sent: Tuesday, January 26, 2021 5:52 PM
> > To: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>
> > Cc: dev@dpdk.org; Yu, DapengX <dapengx.yu@intel.com>; stable@dpdk.org
> > Subject: [PATCH] net/i40e: fix register setting for hash enable
> >
> > From: Dapeng Yu <dapengx.yu@intel.com>
> >
> > The original code causes wrong value to be set into PFQF_HENA register
> > because unnecessary calling to get translated pctype value for X722
> > NIC. The result is RSS cannot work.
> >
> > So remove the unnecessary translation.
> >
> > Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
> 
> Acked-by: Beilei Xing <beilei.xing@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-01-28 13:31 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-26  9:52 [dpdk-stable] [PATCH] net/i40e: fix register setting for hash enable dapengx.yu
2021-01-27  1:44 ` Xing, Beilei
2021-01-27  2:16   ` Yu, DapengX
2021-01-27  3:07 ` Xing, Beilei
2021-01-28 13:31   ` Zhang, Qi Z

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git