From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79698A04BB for ; Thu, 17 Sep 2020 14:37:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 459EF1D64A; Thu, 17 Sep 2020 14:37:33 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D862C1D639; Thu, 17 Sep 2020 14:37:29 +0200 (CEST) IronPort-SDR: RUlX0SqW40nL975hsg+qk7pAbs1qEXlSzCXpNwpVjeCTxN1RYyfMuSGVK4QngFMbRi8GFuzXnf ndBJgZcGEOfQ== X-IronPort-AV: E=McAfee;i="6000,8403,9746"; a="177779922" X-IronPort-AV: E=Sophos;i="5.76,436,1592895600"; d="scan'208";a="177779922" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 05:37:26 -0700 IronPort-SDR: Ij4gjp/YtZ3iH1mB4Kb4ZNliy0WUf3XOluE5eeK4iwhjHuaql9jfuiz6T3gxpsR/wVv6XdfRmF ta66pghQHxKw== X-IronPort-AV: E=Sophos;i="5.76,436,1592895600"; d="scan'208";a="483728603" Received: from dhunt5-mobl5.ger.corp.intel.com (HELO [10.213.228.49]) ([10.213.228.49]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Sep 2020 05:37:25 -0700 To: Lukasz Wojciechowski , Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org References: <20200915193449.13310-1-l.wojciechow@partner.samsung.com> <20200915193449.13310-5-l.wojciechow@partner.samsung.com> From: David Hunt Message-ID: Date: Thu, 17 Sep 2020 13:37:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200915193449.13310-5-l.wojciechow@partner.samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Subject: Re: [dpdk-stable] [PATCH v1 4/6] app/test: collect return mbufs in distributor test X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Lukasz, On 15/9/2020 8:34 PM, Lukasz Wojciechowski wrote: > During quit_workers function distributor's main core processes > some packets to wake up pending worker cores so they can quit. > As quit_workers acts also as a cleanup procedure for next test > case it should also collect these packages returned by workers' > handlers, so the cyclic buffer with returned packets > in distributor remains empty. > > Fixes: c3eabff124e6 ("distributor: add unit tests") > Cc: bruce.richardson@intel.com > Fixes: c0de0eb82e40 ("distributor: switch over to new API") > Cc: david.hunt@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Lukasz Wojciechowski > --- > app/test/test_distributor.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c > index da13a9a3f..13c6397cc 100644 > --- a/app/test/test_distributor.c > +++ b/app/test/test_distributor.c > @@ -599,6 +599,10 @@ quit_workers(struct worker_params *wp, struct rte_mempool *p) > rte_distributor_process(d, NULL, 0); > rte_distributor_flush(d); > rte_eal_mp_wait_lcore(); > + > + while (rte_distributor_returned_pkts(d, bufs, RTE_MAX_LCORE)) > + ; > + > quit = 0; > worker_idx = 0; > zero_idx = 0; Acked-by: David Hunt