From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 753B246150 for ; Thu, 30 Jan 2025 21:19:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6673740E2B; Thu, 30 Jan 2025 21:19:28 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mails.dpdk.org (Postfix) with ESMTP id 2B3B84025A; Thu, 30 Jan 2025 21:19:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738268365; x=1769804365; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=sIxv2alxokbNU9cqneK+i875ker6BZdgkbQEIZdu8xo=; b=ekYipFeZfvoSHtnd+mPNRA0TiE+tEuiYVs6j3bfbcXNqnZTXI7ceWmTt deVe3rmrRkshwDL9Si3zrU7sIr4RELfYvi5awJsV0GDXTUIHfQqS9QVVL JqpDKZp1BIoNcpTv8VzzhNgJEVyVAG3RL72Ds5DcLv346qGPgkHrSAurF r6Khb0YgPiG5Od/QzkUOdYFwOJ1MBVFJm3EkDA5ByKxSrKdfbffn8Wv29 MmlsBekn6vrdUdD1RAJw7+vT6LxWTz8aTy2i6k/nK5avH1j6+PKrHNynE KKEfTXiLS8L1qlTz/ICr6e1Ce82XzIDTvNpBmbTQDXVDWymuduE4ek5Bj Q==; X-CSE-ConnectionGUID: RfkYYnB7Q7if59SL5sVWAA== X-CSE-MsgGUID: He+RrzK0Q/WrWtjv4whekg== X-IronPort-AV: E=McAfee;i="6700,10204,11331"; a="41667751" X-IronPort-AV: E=Sophos;i="6.13,246,1732608000"; d="scan'208,217";a="41667751" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2025 12:19:24 -0800 X-CSE-ConnectionGUID: rTet/r/BSj+h5vP2+2cL8w== X-CSE-MsgGUID: sa5nrsTZQQ+Sd0mxnjHq/g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,246,1732608000"; d="scan'208,217";a="109582046" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmviesa008.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 30 Jan 2025 12:19:24 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44; Thu, 30 Jan 2025 12:19:23 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.44 via Frontend Transport; Thu, 30 Jan 2025 12:19:23 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.41) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.44; Thu, 30 Jan 2025 12:19:23 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wdLOsNM1ITeOB0X8p5GekeUR36dYHsfJemlo3ghAYdNsG0MI52hV1kpy7ZM+caHA7n2xu83f4Y1RTdwF95CQ0VEwzAN1WQjAA7yZE/roDeQrgJbyCNwxprkOkA7CmsCM0PQith8mTLY0TVe1dvRLpRciFyIHYbK8mVZOoHoaDRBAexRhbCasI7PEGVm8ccL7ew7pH6busTp4O+4IMvfPj3tGOpjCRNoZpRYq5hZNSujoU0lIjusnRuypcc3E4oNHJMFPJCyb7s19rPrPJ4li5Qk2qj3/KN9wqng/qy+5riyjcha3gPNAtO5Xp6cu+yOrGvnx2Wgh5LlkrSxiS5i11A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GMNBfMEYOZaKOExw/nFk71YTAs2fDAlaOd+kqBNW/PY=; b=hZPE4R7lEykB9soqbmOCiTxaSeFWgG8dGMbVb8UYN7+I5hG54bIKH5NKfnYCtN5p0cR3PzxfZ0O8KP9+HUE5GAa+1jydvCfvfZDtDTMs4Vc5EVaAXaI/bZWSIIqJ8KxJ0r0SOWciXxSP8JKnAfD0NBUtp+EzSyTe/s04gwJonDWrKRn00QCMJTBbhJCB0ouLxUW9PWmKagzJnC8q3Zv86Uj4wvpX7zH69TxDWX27tdk9qWOuuK8IBKOaBF0VHrTLbl8zTSKU7wlW5OaVW8wtIE8iUpJ/hI97kqi8hiAtITI8A0Zn8M/8jIGhk3Laz1IMJ52ChPVsQKG6r1mm/HMLLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8) by CY5PR11MB6413.namprd11.prod.outlook.com (2603:10b6:930:37::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8377.23; Thu, 30 Jan 2025 20:18:39 +0000 Received: from SJ0PR11MB5772.namprd11.prod.outlook.com ([fe80::5851:319:3da6:850b]) by SJ0PR11MB5772.namprd11.prod.outlook.com ([fe80::5851:319:3da6:850b%5]) with mapi id 15.20.8398.014; Thu, 30 Jan 2025 20:18:39 +0000 Content-Type: multipart/alternative; boundary="------------88AhQ9iVNC6sanAzJbpqJfnT" Message-ID: Date: Thu, 30 Jan 2025 20:18:35 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] net/ice: fix how ice driver handles flows To: Bruce Richardson CC: , , , , References: <20250130155011.2658800-1-vladimir.medvedkin@intel.com> <20250130161442.2730917-1-vladimir.medvedkin@intel.com> Content-Language: en-US From: "Medvedkin, Vladimir" In-Reply-To: X-ClientProxiedBy: DB9PR06CA0019.eurprd06.prod.outlook.com (2603:10a6:10:1db::24) To SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR11MB5772:EE_|CY5PR11MB6413:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f71a60b-f1c5-4a0e-df85-08dd416b48ce X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|8096899003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Qm9CblhlaUVnSzFnR0lydmpadnBEVXhIdUVqVjNYR3REZDc0dFNJcDVlaFkw?= =?utf-8?B?YkJRVEUvcmlha3lOdE5jTkFGSkpLMFgwOTVDWEk1cTJDNmZqT1p1UGpLL3Mx?= =?utf-8?B?ZEVjL25iQTIvVGdZTFlzT2ZKR3RiZ0dOWU5WQ2VCZ3Rwa0t5ZlpSQlF0Qjl6?= =?utf-8?B?OTA5K0s5MGFNdGV3bVg5L0ZiaStLZlZWWlRiV3A0T1MxV1QwUTRZMlNHNUw0?= =?utf-8?B?SHplMERmcnliTW8wNWlkMWsxbnh6VzlqcDRpeFQxc1hMelpXOXZBM3V6TVUw?= =?utf-8?B?NU5pdzZrNm1qS0ZveHVycllvaVVtcE5mMFhZUWp5aEhUYXUzazJpM1dRZjhs?= =?utf-8?B?R0FNOTZ4YWVlMnZ6V21sUnk5Tm5XeEtybTU3QXBacW00UkRZTVpmczBhNUIw?= =?utf-8?B?dS9MYnFPaUwrR3BDOUwxWVZVcU5FRlZjblVxSUVyWEp2U3hGSmp4RnVHOWFr?= =?utf-8?B?aWJKWjNiV3NCUE51TEREL2JWMllSN0VKdlV4Z0FEVGE3YkZScUtQaHJrZURH?= =?utf-8?B?Wmk5eVJjZkhQdTdwYWg5UXBHMlVVV2lMdnFzamlhb2dMUVVOcUJxeVlMaFFW?= =?utf-8?B?bkxFTWNZTEpMRE1yNDF0MzZvVEpGWmRPcTRtdy9QaVo4ajJKT2JGUGhCR1J3?= =?utf-8?B?RkNRME1UNGsvZlpYTUtxZEZFbFUrOE5xY0QybTQ1UnVvTWlqeUQ5QlFxVU9u?= =?utf-8?B?K3gwUzBBUjV6b0NpR2RNcEpWL05GTytyZ1hoakYxOGdnVFhLcTEvd1FMWjM3?= =?utf-8?B?bFVGc3ZNNHk4UU8rVjM5MXd6d1lxQ2hzR1ljUUlqcXpjUVJvK0pXWGVBVnJ6?= =?utf-8?B?bU5HbG9WV091MkNUbjA0dkhJOGpqK3Vld3A3ZER4bUN4OWRwcEZnaCtJWnF0?= =?utf-8?B?MC9FWUFRQ0E5cHRpMXVkYXlMaDNvYmZWOG5JUWVjWm1OVDIwdWR4SzhoRWRr?= =?utf-8?B?OEZ4dmJMTU0xVytUcTN4RlRtU2t5VHdvcHhrNHhNek9ad01KSVk4K3ozVXh6?= =?utf-8?B?enVDSFhneDA2NDlEc0d2WXNacmNoRDFvOUxQd2hZS2N0eDkyWXdNS3hVWVUr?= =?utf-8?B?cXpWZERhNXRvd2JLR1V1d2R2TjNySkptalNqL21YeWxrYWFYOGlCY0tIY1lw?= =?utf-8?B?T0MrQWp3MFhyejdKS0kvM3VvbmJTckJIbU1YWDlkdGR6Q2tNQ0lLczROaFNT?= =?utf-8?B?bHk1RkhlWHcwNVNHcGxwNXBJTXpIQWpqTDZ0T3JocE5ScG1zU0s1SEd2aE5i?= =?utf-8?B?MDZ0dHVqZ3dCYnJiQVVIKzZWQk9tQWRoY3NyYnJCQ0Y0WWNVbFRuci95eWtz?= =?utf-8?B?MkFYSnR6TDZlNGkzTm80bkdyYU5CYzZwMVQ3K3M1b3ZhQWdrQmZlbWQ5V25E?= =?utf-8?B?MVJLWHFvc0hISEFXRGZMV2ZyZS9sQ2dxQ2lwS2FJQkdpU0x1TVpHOTdZRDYv?= =?utf-8?B?ZjJ4Q1FrMkt3YWtLWEY4aE1WdHpEdmpMZWZqNnh2bDA4endDSmNqZGRLNW1m?= =?utf-8?B?Ui9yQmZWYThGd2dCR01ZL0xFSWU2clpWVDB1UWdOTXU1NWJVUWQ0L2drTnRY?= =?utf-8?B?OVo1ZjBUKzFRL2tGaFZ3NG1TRUM0OGplaVp2NUtzTHluMUsxZVJiNTRjTmh1?= =?utf-8?B?YUEzOGVlUUZPK3kycDVjWnJiYVI0bnhGU3VkV0g4aEdndERxTWJUUXRXa2JT?= =?utf-8?B?UkUyVHNRdDFRbGF4ZWxEZ2ZBWkdPY283KzFjNk5MYWlUMStMRDF5TkxTa09R?= =?utf-8?B?SnNTeEYrbFp3S2JhMUJKajNyUEZZdUJBa0lZQWZCWUUvZW1ySDlJWXRBbkln?= =?utf-8?B?dk5sWlFYcG9waDAvaTVjMUwyOXM5L0ZOUVV6Y3h3ZC95UXVDcjNwZlY1RVpp?= =?utf-8?Q?DhBqUqvnf9DHA?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5772.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(8096899003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTBXV0loRU1Pc2JpY2NpZHRsamxFUUw5Wng1SU5jYkdnK3FXck1WbjFMN3o4?= =?utf-8?B?N1R5VUhqUVpMRGh5MVMwNnN2dWFod2E3OXNIZlhCMUxGMU9JcEZLRnN1QjNa?= =?utf-8?B?WTVlRXlYeGlrMTBhei9Qa0VFbjcrN2RNTmRjd29NUHRLTWpkeDZ1ZW5UQy9n?= =?utf-8?B?TnJrM2laYytZT2M3eUNERk5uOHVsWStlbFJyRXRvNW54c2ZueC9HSloyQzZO?= =?utf-8?B?NkVQdTF5NXBwZGtOa25pNDhhU0R4cDRjcC9ZM0FsT3lqOU15UWowbjFvZ3Fm?= =?utf-8?B?VHI0c3NBWHY1UzU0UnhzNExKSU4rVEZBMTQwcVVwN3lLczBRUTVIS3BCL3Bp?= =?utf-8?B?Z0JadHhZL00rQTZMS2pWVnpPemZwdzNtR1VEaTlKdFVucFplWTdGd1NnQ0RD?= =?utf-8?B?Z1YxRWhRd1k5VU5INDV4ZkhLSjR1UmR6MFNEQzd3QklVN3IwSmladFBQRFpr?= =?utf-8?B?bFU5MFdtSVNaQmxtSkpLMUpvaXgyN25lMTJMWmdYcWZpbGdLWWxpQlZMTTU3?= =?utf-8?B?dFB1UGh5SVpEK0dSSFZpY3RBU1hiRlB4emxsMnVRVlBDK2xHVENOMWFrMVJi?= =?utf-8?B?OXNWZ3BCbFJyeW1CQlhvY0t4bzM3QjIzdkN0eVd5b25mUlpMbGhOaHR2V0Jr?= =?utf-8?B?V29MMzhYM3lTTmNnUVAyRHFyY3ZHdEUwSDFPc1BuQ0lUaHhuZzVucVdrbHZ2?= =?utf-8?B?c3o1N3VNSnZWNHZBWVV6Vi85VE1JQ3ljTG5PQ3dHWGVlNE42bFIvWnZkeVhM?= =?utf-8?B?VTV2UGtBYkNKS2ZCby9IN3FJMlh5YlBvQzZiakJDbHZYMVFjRUYvQXdod05R?= =?utf-8?B?eGxmRHRuQmJFYWVtU011UHZLTk43Q1RwZE9aRXR5NHRhTjlEcEtSL0ZESUNn?= =?utf-8?B?R0k0ZmRwRk95UlBTb3Q0Q054TGJlNGV0WU40NVVkOWpwenZVZUVYdE45SVU2?= =?utf-8?B?L3hQWWd4NUJIdXI5K3ZFNldOWVlTVmpxNFhML0hMQkR5cnVnV3I2R3Q3OHda?= =?utf-8?B?ZFBBNmNGUit0SHNMVjRZVzV4ZDU2OE5PTE5ZNjIzeUZXK2UrS0JKbjhiOUdL?= =?utf-8?B?UndvWVd0bk1pZXpCV3Bma2kwd0hqZUdHcTFvcnkxUVNvcXh2eHlJUDVlV09v?= =?utf-8?B?RnFYQnRHZEUzWDI5MVNadjJ3aXB5bEZkMXdtVmZHQUI3c1cwTUJlU3lUQkVN?= =?utf-8?B?Q1FSN21NdUJGOU9NMUd4VE1paHBTUWo0d28xSDdmMmtIcFFRK1FtVElSWkhP?= =?utf-8?B?bEtDTm84OVNJaE5HT1lnRmNoM2hwYllxL3k2RTNoczNXV1prRlhwaHZvWERa?= =?utf-8?B?bVBqNTZkNHFSOHFFaXFDY1NQeTA0UGR4dTJWODExMTMvNkZoaGU2am9IOWgy?= =?utf-8?B?VTllM2prMjFkNVN2ak9iTktGMTBNc3MyUG5TeWZMRnpIeTBHa1M0blFKOW8v?= =?utf-8?B?Y3R1Q1NTREdQU1Q0Rmw3OTN4YjdWbFdZYUxTSExlUXJwUFN5RUFHQzJVOW1T?= =?utf-8?B?M0hFa0gxYXVKemtwMVlNdmplUStRdHNFbEY3cHErSyt5RDY5bkw4Yi9NMHNK?= =?utf-8?B?TjVheFBJUitheFV1b05FOXBQSDRVc1duSjRZRGY1RWJnd2NweC9GaGNndDdR?= =?utf-8?B?elpiUHhDck5BcmRjMzErRHVWN0M1L2ZaeFpNUmJrakNoZldnMENlRWFkTjZn?= =?utf-8?B?aTgvcWZ0MFpmQktkZTd4VUxmUzNFSElBMHVhdnYwVldTWmZydUxzQ2hja0Rx?= =?utf-8?B?MnBBZEp0WTRXS1ZJV3N4QkNHSkkyZVNKblVBM2o1cmJ4SDhRQ0ZkYXZpYVZD?= =?utf-8?B?cWNSZDNDckJ5WjhRdC9RcWhyZ3VUaFhvUkFHc3lFNThVMUJXYnJwWGNhRUp0?= =?utf-8?B?SWdRNUwzR3VJTWFzSVEvWTBNV0hjd2JMMU5uYU5Hc08vOXFZRGg3QUdob3NI?= =?utf-8?B?NFlXSk9qN2xZeitHeTA5TEUzakNlN0hpY1ZISitidGlpdHc3b2dFdXZMV2lZ?= =?utf-8?B?Q291ZlMyd2ZiM3BPanlFRVB3M3hJSE5LRFZDRkdXWVY2bjJld3JiZmVuWWcz?= =?utf-8?B?V09tRGtkc1E3N0c2NGFxaWp4Vks3L3k1cEtvYmNDbDFHYkphZ0JVVDNMakIw?= =?utf-8?B?Uk8wZXAzaTZDOXVGK2EzR25JVnU0ZDNwOVJKYzdCZFBBNjRsQmZLcitpOU0v?= =?utf-8?B?cVE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1f71a60b-f1c5-4a0e-df85-08dd416b48ce X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5772.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jan 2025 20:18:39.7306 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I6m/AoL/vkM7EGQI2SVG0QbX7YXqRVnqlS/ggv0KfZrF2BQe5PhGV0Q0+VuNMgfKMyINHO0ZGxuci2sxQ0uwzlhA/BABQR1hUSS2wzTCkZM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6413 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org --------------88AhQ9iVNC6sanAzJbpqJfnT Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Hi Bruce, On 30/01/2025 17:54, Bruce Richardson wrote: > On Thu, Jan 30, 2025 at 04:14:42PM +0000, Vladimir Medvedkin wrote: >> Currently ICE PMD uses group attribute to select the appropriate HW engine >> to offload the flow. This behavior violates the rte_flow API, existing >> documentation/examples, and reveals hardware specific details. >> >> This patch eliminates the use of the group attribute and runs each engine >> parser in the order they work in the HW pipeline. >> >> Fixes: 9c5f0070fa3f ("net/ice: map group to pipeline stage") >> Cc:qi.z.zhang@intel.com >> Cc:stable@dpdk.org >> >> Signed-off-by: Vladimir Medvedkin > Thanks, this seems a great idea, to automatically put the flow in place. > > Question: is there ever a scenario where a user may need, or want, to > override the automatic choice made here? Or is it just the case that once > the flow is installed, it works the same whatever group it's added into? > I would assume the latter, but just want to confirm. I don't think a user might have to worry about the internals of the NIC filters. Thesefiltersperformdifferent lookups: ACL provides wildcard matching, when FDIR in an exact match, so it depends on what kind of mask is used for a particular field, for example: I want to install _exact_match_ rule: - I use FDIR engine: flow create 0 ingress group 2 pattern eth / ipv4 dst spec 192.168.0.1 dst mask 255.255.255.255 / end actions drop / end and it works as expected. - I use ACL engine: flow create 0 ingress group 2 pattern eth / ipv4 dst spec 192.168.0.1 dst mask 255.255.255.255 / end actions drop / end and parser throws an error: Invalid IPv4 mask.: Invalid argument I want to install _wildcard_match_ rule: - I use FDIR engine: flow create 0 ingress group 2 pattern eth / ipv4 dst spec 192.168.0.1 dst mask 255.255.255.254 / end actions drop / end doesn't work, Invalid action.: Invalid argument - I use ACL engine:flow create 0 ingress group 1 pattern eth / ipv4 dst spec 192.168.0.1 dst mask 255.255.0.255 / end actions drop / end and it works as expected > /Bruce -- Regards, Vladimir --------------88AhQ9iVNC6sanAzJbpqJfnT Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit

Hi Bruce,

On 30/01/2025 17:54, Bruce Richardson wrote:
On Thu, Jan 30, 2025 at 04:14:42PM +0000, Vladimir Medvedkin wrote:

Currently ICE PMD uses group attribute to select the appropriate HW engine
to offload the flow. This behavior violates the rte_flow API, existing
documentation/examples, and reveals hardware specific details.

This patch eliminates the use of the group attribute and runs each engine
parser in the order they work in the HW pipeline.

Fixes: 9c5f0070fa3f ("net/ice: map group to pipeline stage")
Cc: qi.z.zhang@intel.com
Cc: stable@dpdk.org

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>

Thanks, this seems a great idea, to automatically put the flow in place.

Question: is there ever a scenario where a user may need, or want, to
override the automatic choice made here? Or is it just the case that once
the flow is installed, it works the same whatever group it's added into?
I would assume the latter, but just want to confirm.

I don't think a user might have to worry about the internals of the NIC filters. These filters perform different lookups: ACL provides wildcard matching, when FDIR in an exact match, so it depends on what kind of mask is used for a particular field, for example:

I want to install _exact_match_ rule:

- I use FDIR engine: flow create 0 ingress group 2 pattern eth / ipv4 dst spec 192.168.0.1 dst mask 255.255.255.255 / end actions drop / end
and it works as expected.

- I use ACL engine: flow create 0 ingress group 2 pattern eth / ipv4 dst spec 192.168.0.1 dst mask 255.255.255.255 / end actions drop / end
and parser throws an error: Invalid IPv4 mask.: Invalid argument

I want to install _wildcard_match_ rule:

- I use FDIR engine: flow create 0 ingress group 2 pattern eth / ipv4 dst spec 192.168.0.1 dst mask 255.255.255.254 / end actions drop / end
doesn't work, Invalid action.: Invalid argument

- I use ACL engine:flow create 0 ingress group 1 pattern eth / ipv4 dst spec 192.168.0.1 dst mask 255.255.0.255 / end actions drop / end
and it works as expected

  

/Bruce

-- 
Regards,
Vladimir
--------------88AhQ9iVNC6sanAzJbpqJfnT--