patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] examples/vm_power_manager: fix string overflow
@ 2019-04-10 14:54 Reshma Pattan
  2019-04-15 14:45 ` Hunt, David
  0 siblings, 1 reply; 3+ messages in thread
From: Reshma Pattan @ 2019-04-10 14:54 UTC (permalink / raw)
  To: dev; +Cc: Reshma Pattan, david.hunt, stable

Use strlcpy instead of strcpy to fix string overflow.

Coverity issue: 337671
Fixes: a63504a90f ("examples/power: add JSON string handling")
CC: david.hunt@intel.com
CC: stable@dpdk.org

Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
 examples/vm_power_manager/channel_monitor.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
index 74df0fe20..0b44a74b5 100644
--- a/examples/vm_power_manager/channel_monitor.c
+++ b/examples/vm_power_manager/channel_monitor.c
@@ -159,7 +159,8 @@ parse_json_to_pkt(json_t *element, struct channel_packet *pkt)
 			if (ret)
 				return ret;
 		} else if (!strcmp(key, "name")) {
-			strcpy(pkt->vm_name, json_string_value(value));
+			strlcpy(pkt->vm_name, json_string_value(value),
+					sizeof(pkt->vm_name));
 		} else if (!strcmp(key, "command")) {
 			char command[32];
 			strlcpy(command, json_string_value(value), 32);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] examples/vm_power_manager: fix string overflow
  2019-04-10 14:54 [dpdk-stable] [PATCH] examples/vm_power_manager: fix string overflow Reshma Pattan
@ 2019-04-15 14:45 ` Hunt, David
  2019-04-22 21:09   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Hunt, David @ 2019-04-15 14:45 UTC (permalink / raw)
  To: Reshma Pattan, dev; +Cc: stable

On 10/4/2019 3:54 PM, Reshma Pattan wrote:
> Use strlcpy instead of strcpy to fix string overflow.
>
> Coverity issue: 337671
> Fixes: a63504a90f ("examples/power: add JSON string handling")
> CC: david.hunt@intel.com
> CC: stable@dpdk.org
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
>   examples/vm_power_manager/channel_monitor.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c
> index 74df0fe20..0b44a74b5 100644
> --- a/examples/vm_power_manager/channel_monitor.c
> +++ b/examples/vm_power_manager/channel_monitor.c
> @@ -159,7 +159,8 @@ parse_json_to_pkt(json_t *element, struct channel_packet *pkt)
>   			if (ret)
>   				return ret;
>   		} else if (!strcmp(key, "name")) {
> -			strcpy(pkt->vm_name, json_string_value(value));
> +			strlcpy(pkt->vm_name, json_string_value(value),
> +					sizeof(pkt->vm_name));
>   		} else if (!strcmp(key, "command")) {
>   			char command[32];
>   			strlcpy(command, json_string_value(value), 32);


Acked-by: David Hunt <david.hunt@intel.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] examples/vm_power_manager: fix string overflow
  2019-04-15 14:45 ` Hunt, David
@ 2019-04-22 21:09   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2019-04-22 21:09 UTC (permalink / raw)
  To: Reshma Pattan; +Cc: stable, Hunt, David, dev

15/04/2019 16:45, Hunt, David:
> On 10/4/2019 3:54 PM, Reshma Pattan wrote:
> > Use strlcpy instead of strcpy to fix string overflow.
> >
> > Coverity issue: 337671
> > Fixes: a63504a90f ("examples/power: add JSON string handling")
> > CC: david.hunt@intel.com
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> 
> Acked-by: David Hunt <david.hunt@intel.com>

Applied, thanks




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-04-22 21:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-10 14:54 [dpdk-stable] [PATCH] examples/vm_power_manager: fix string overflow Reshma Pattan
2019-04-15 14:45 ` Hunt, David
2019-04-22 21:09   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).