From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75C8FA32A1 for ; Thu, 24 Oct 2019 10:48:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1CE2E1E888; Thu, 24 Oct 2019 10:48:52 +0200 (CEST) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 265E01E888 for ; Thu, 24 Oct 2019 10:48:51 +0200 (CEST) Received: by mail-wm1-f65.google.com with SMTP id g24so1814094wmh.5 for ; Thu, 24 Oct 2019 01:48:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=2Mxe3soCNC2BCL2iCbWbnMlWiB/7638bS6kprlW4Yqc=; b=LAVmBSFjOI9MFoezB7MeqfP4tL3ZWM1LQnbCZNFsCxqi9TM3m0rGCfpo/taOZWixJV iGHs+VrDcn2RWVt8lR3tN4hrtsiLxFBKxpJTtRd9LWGScSMulcWeERuXouBYtzsuz8Sv su8OV79mMGEhCok6mhji1DonKPDhZmLaFDeE+WMK5VxOHnyIIsxFQLloIfJ2HH9BHN0V ErRXT+YzaYZOTIWGHWx37AXKeh+SoszaKaTKnDT24XuGpIjASQAS/vbEKPqussdTfiM2 DQ+dz8p6zpXyFFKrDvyJK7jGE5fPCVfbMWfqMVR1w+KnV/oypWwXnSe/33jRuaM/Mqm2 GrrA== X-Gm-Message-State: APjAAAVe2172swWDpKHz9o/d8yf2vMoOgRTFL0GRQknug76z1RXhi3UT PefOqfKCEV+YNccQ+Df8R8w= X-Google-Smtp-Source: APXvYqyzaIpIhpa5ZlctQuLUTwN+/UpDVwe0OldmoDNSRucAxYlaoY6AWkq3L+Ty6NzEjbBbaGtbag== X-Received: by 2002:a1c:10b:: with SMTP id 11mr3646003wmb.118.1571906930530; Thu, 24 Oct 2019 01:48:50 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id v11sm1679475wml.30.2019.10.24.01.48.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2019 01:48:49 -0700 (PDT) Message-ID: From: Luca Boccassi To: patrick.fu@intel.com, stable@dpdk.org Cc: ktraynor@redhat.com, maxime.coquelin@redhat.com, zhihong.wang@intel.com, tiwei.bie@intel.com Date: Thu, 24 Oct 2019 09:48:49 +0100 In-Reply-To: <1570775742-413094-1-git-send-email-patrick.fu@intel.com> References: <1570775742-413094-1-git-send-email-patrick.fu@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 17.11] net/virtio: init MTU in case no control channel X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Fri, 2019-10-11 at 14:35 +0800, patrick.fu@intel.com wrote: > From: Patrick Fu < > patrick.fu@intel.com > > >=20 > [backport from commit id: 240da8b2143b7be372cf6388f028b26b15f16776] >=20 > The max_mtu is kept as zero in case no CRTL channel, which leads > to failure when calling virtio_mtu_set(). >=20 > Signed-off-by: Patrick Fu < > patrick.fu@intel.com > > > --- > drivers/net/virtio/virtio_ethdev.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/net/virtio/virtio_ethdev.c > b/drivers/net/virtio/virtio_ethdev.c > index e0328f6..c9076ea 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -1508,6 +1508,8 @@ static int virtio_dev_xstats_get_names(struct > rte_eth_dev *dev, > } else { > PMD_INIT_LOG(DEBUG, "config->max_virtqueue_pairs=3D1"); > hw->max_queue_pairs =3D 1; > + hw->max_mtu =3D VIRTIO_MAX_RX_PKTLEN - ETHER_HDR_LEN - > + VLAN_TAG_LEN - hw->vtnet_hdr_size; > } > =20 > ret =3D virtio_alloc_queues(eth_dev); >=20 Acked-by: Luca Boccassi Thanks, applied --=20 Kind regards, Luca Boccassi