From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
by dpdk.org (Postfix) with ESMTP id E36C4201;
Mon, 12 Nov 2018 10:18:17 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
12 Nov 2018 01:18:16 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.54,494,1534834800"; d="scan'208";a="99535302"
Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.9.8])
([10.252.9.8])
by orsmga003.jf.intel.com with ESMTP; 12 Nov 2018 01:18:15 -0800
To: Rami Rosen <roszenrami@gmail.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org,
john.mcnamara@intel.com, stable@dpdk.org
References: <d2749a0c9f18188c56e02e61c602e65ca88e099d.1541598755.git.anatoly.burakov@intel.com>
<e6f3dbb8-8cea-515e-e872-50be49edd3d0@intel.com>
<b544afca-9f01-331c-d8a6-9b85e2c1a8bd@intel.com>
<CAKoUArmSpd7wz6d-ho-dcbWPpSnW01-Nd_wX8x_y_Jy_Lp5_xw@mail.gmail.com>
<9e7f9bd5-b71b-4758-133e-16b1c8e6abbe@intel.com>
<CAKoUAr=EkD34X4jXRTp=bMBkCvp79GaqtpEr9VLRfg7ztQ3pqw@mail.gmail.com>
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <be99e233-7994-8059-c2b1-31825161991c@intel.com>
Date: Mon, 12 Nov 2018 09:18:14 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CAKoUAr=EkD34X4jXRTp=bMBkCvp79GaqtpEr9VLRfg7ztQ3pqw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] devbind: check for lspci
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Nov 2018 09:18:18 -0000
On 10-Nov-18 11:03 AM, Rami Rosen wrote:
> HI Anatoly,
>
>> Do all other distros have lspci in package called pciutils? If not, i
>> prefer to keep it the way it is.
>
> Your original patch have:
>
> + if ret != 0:
> + print("'lspci' not found - please install 'lspci'")
>
> And I suggest to consider changing it to:
>
> >> + if ret != 0:
> >> + print("'lspci' not found - please install pciutils')
>>
>
> Sorry about my ignorance: which distro has a package named "lspci", if at all?
>
> The official project that include the lspci utility is called
> "pciutils": see: http://mj.ucw.cz/sw/pciutils/
> You can see that a package named "pciutils" is available in great many
> distros, like:
> Fedora, OpenSuSE, CentOS, RHEL, Ubuntu, Debian, Mandriva and Mageia,
> according to the following links:
>
> http://www.rpmfind.net/linux/rpm2html/search.php?query=pciutils&submit=Search+...
> https://packages.ubuntu.com/trusty/pciutils
> https://packages.debian.org/search?keywords=pciutils
> https://rpms.remirepo.net/rpmphp/zoom.php?rpm=pciutils
>
> Regards,
> Rami Rosen
>
Hi,
Thanks, that's good to know, will fix in v2.
--
Thanks,
Anatoly