From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <anatoly.burakov@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id CF2841B4AB;
 Fri,  1 Feb 2019 11:28:51 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga006.jf.intel.com ([10.7.209.51])
 by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 01 Feb 2019 02:28:50 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.56,548,1539673200"; d="scan'208";a="112885153"
Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.94])
 ([10.237.220.94])
 by orsmga006.jf.intel.com with ESMTP; 01 Feb 2019 02:28:48 -0800
To: Kevin Traynor <ktraynor@redhat.com>, dev@dpdk.org
Cc: John McNamara <john.mcnamara@intel.com>,
 Marko Kovacevic <marko.kovacevic@intel.com>, thomas@monjalon.net,
 "stable@dpdk.org" <stable@dpdk.org>
References: <93e6481f516c2549308e0745388a0bd80b44e783.1548954304.git.anatoly.burakov@intel.com>
 <f2c7592f-b1f9-36be-f913-fb55c7d01a3d@redhat.com>
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Message-ID: <bf5f4f4e-6415-71d2-5e47-501634613d8d@intel.com>
Date: Fri, 1 Feb 2019 10:28:44 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <f2c7592f-b1f9-36be-f913-fb55c7d01a3d@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] doc: document libnuma
 requirement for NUMA systems
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Feb 2019 10:28:52 -0000

On 31-Jan-19 6:14 PM, Kevin Traynor wrote:
> On 01/31/2019 05:05 PM, Anatoly Burakov wrote:
>> Since 18.05, libnuma is pretty much required on Linux when using
>> non-legacy mode, because without it, we cannot know where our
>> hugepages are located [1].
>>
>> In legacy mode, libnuma is not required because we can still sort
>> pages by sockets, as we use pagemap lookup method to figure out
>> socket ID's for pages.
>>
>> So, document libnuma as required for NUMA systems and non-legacy
>> mode.
>>
>> [1] https://mails.dpdk.org/archives/dev/2018-December/120490.html
>>
> 
> Might as well add to the stable docs also. Picking this commit as it's
> where both mode are available
> 
> Fixes: 6b42f75632f0 ("eal: enable non-legacy memory mode")
> Cc: stable@dpdk.org

Yup, thought of that right after leaving office yesterday! :)

> 
>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>> ---
>>   doc/guides/linux_gsg/sys_reqs.rst | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/doc/guides/linux_gsg/sys_reqs.rst b/doc/guides/linux_gsg/sys_reqs.rst
>> index 8ec3af491..23cfc27ab 100644
>> --- a/doc/guides/linux_gsg/sys_reqs.rst
>> +++ b/doc/guides/linux_gsg/sys_reqs.rst
>> @@ -70,6 +70,14 @@ Compilation of the DPDK
>>   
>>       * libnuma-dev in Debian/Ubuntu;
>>   
>> +    .. note::
>> +
>> +        On systems with NUMA support, `libnuma-dev` (aka `numactl-devel`) is a
>> +        recommended dependency when `--legacy-mem` switch is used, and a
>> +        *required* dependency if default memory mode is used. While DPDK will
>> +        compile and run without `libnuma` even on NUMA-enabled systems, both
>> +        usability and performance will be degraded.
>> +
>>   *   Python, version 2.7+ or 3.2+, to use various helper scripts included in the DPDK package.
>>   
>>   
>>
> 
> Acked-by: Kevin Traynor <ktraynor@redhat.com>
> 


-- 
Thanks,
Anatoly