patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Loftus, Ciara" <ciara.loftus@intel.com>,
	"Wang, Xiao W" <xiao.w.wang@intel.com>,
	"Ye, Xiaolong" <xiaolong.ye@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/af_xdp: fix redundant check for NEED WAKEUP
Date: Fri, 10 Jan 2020 14:44:45 +0000
Message-ID: <c05a6e91-e709-d373-5e70-ece2e9f89b73@intel.com> (raw)
In-Reply-To: <74F120C019F4A64C9B78E802F6AD4CC279297B77@IRSMSX106.ger.corp.intel.com>

On 1/8/2020 3:57 PM, Loftus, Ciara wrote:
>>
>> Function kick_tx() has built-in detection on NEED_WAKEUP flag, so just
>> call it directly, like elsewhere in the driver.
>>
>> Fixes: d8a210774e1d ("net/af_xdp: support unaligned umem chunks")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
>> ---
>>  drivers/net/af_xdp/rte_eth_af_xdp.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
>> b/drivers/net/af_xdp/rte_eth_af_xdp.c
>> index 2b1245ee4..d903e6c28 100644
>> --- a/drivers/net/af_xdp/rte_eth_af_xdp.c
>> +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
>> @@ -480,10 +480,7 @@ af_xdp_tx_zc(void *queue, struct rte_mbuf **bufs,
>> uint16_t nb_pkts)
>>  		tx_bytes += mbuf->pkt_len;
>>  	}
>>
>> -#if defined(XDP_USE_NEED_WAKEUP)
>> -	if (xsk_ring_prod__needs_wakeup(&txq->tx))
>> -#endif
>> -		kick_tx(txq);
>> +	kick_tx(txq);
>>
>>  out:
>>  	xsk_ring_prod__submit(&txq->tx, count);
>> --
>> 2.15.1
> 
> 
> Thanks for the patch.
> 
> Tested-by: Ciara Loftus <ciara.loftus@intel.com>
> 

Applied to dpdk-next-net/master, thanks.

      reply	other threads:[~2020-01-10 14:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-06 14:09 [dpdk-stable] " Xiao Wang
2020-01-08 15:57 ` [dpdk-stable] [dpdk-dev] " Loftus, Ciara
2020-01-10 14:44   ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c05a6e91-e709-d373-5e70-ece2e9f89b73@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=xiao.w.wang@intel.com \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git