From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC19545E30 for ; Wed, 4 Dec 2024 16:56:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D353140A6D; Wed, 4 Dec 2024 16:56:42 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1172A40A6D for ; Wed, 4 Dec 2024 16:56:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733327800; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pha0CQGHrA3Q8Hco6BjQGYKHEl4JJOBwxF1MCO74kbI=; b=LjdQiGeIqmVHNQPeqyMqX25UEWaJUvoOLhmsfRc84qyr24YAaXmL8bsO4zjtQgSI5XnJO3 Ai9Q/3UT57YEUdfE2piHJzYevV07XxGvlAiiog4sUT7oLIbtx6BiWqPVpdyQFdJLURf5SB Iom2KPQVqP9om6UM8MHLdqE0niKk03Q= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-372-JRT6aUnwPn-TASu4lEjOfg-1; Wed, 04 Dec 2024 10:56:39 -0500 X-MC-Unique: JRT6aUnwPn-TASu4lEjOfg-1 X-Mimecast-MFC-AGG-ID: JRT6aUnwPn-TASu4lEjOfg Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-5d0c9402f82so3604810a12.3 for ; Wed, 04 Dec 2024 07:56:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733327798; x=1733932598; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pha0CQGHrA3Q8Hco6BjQGYKHEl4JJOBwxF1MCO74kbI=; b=uZ4LY3+0JwqDzX8UfXqD5QRruDH/RJJmwya8to+JQqPK4ReNvXXNJpbmFvOUAFafCm tNrMCfRvevu5BBjRNc9RzgiLCK54+NAP8Mbyu0z2W8bt/5Q1dsaVut7FScXQRs9CcZeh O4x2Lmw8tsDbXpG9un08nvW0HyJdrNd9wbWwWxNLT/mwBm8j7XmvKeO41p13EZngjyOq l8qE+dc4OnwS5W6c5au3j4c64N8vsQefHHyTYySVUVpdiuAhj2jx9PefzEIKIGQA+3V7 qhfEKx+IC2Bkw7qW9JSIh8O9waWbo5tUxvkjVIvuH4aVl6N4XQsdwdXeEr90ng/irkxD C8Ig== X-Forwarded-Encrypted: i=1; AJvYcCVlpv7/1MURQxuVe5ialfgEwPMx2lKfQ0KHmQYp5OqZiHeGDozRypwQiX8HbEUXxyfduTQHGto=@dpdk.org X-Gm-Message-State: AOJu0Yy4p2kN3M1QRsK1LxdnmruDDS8UtMlJIZBUGrthvcKRQB8UZPEZ VRnIrSyS4DtxfSqT4owxrMAMfTqdHEJP8RCaQgvSNOGxieJODGiUqBTQk4jM1Wot6O3uttIX+lS 6faMui0/D9ttmaUatI/kY7td3CzBeOKRvv/ZqrAlglLcO X-Gm-Gg: ASbGncu2cEuMpbzO04SmbBnqQUp/k3U3dJ92oIJyDa+c+w9jSQif+T3A17oyaDlVGVI 0JFA7eKoxIT1z3tJ35bko4KVXrGHDqJ2N7xc81Kjmb37e0Sg/M2ik1UsiqLVharRfdiLvlY+AIU rFcKvAFh8b6t+8/WTLbNJouqsjbJYtJPMSf3ZlhPhJMtzZtfYfGInWSepMRS5LCFJcq1gkWsiwE R/z8RZCQZk6UQOrM1Xa3BGpIp2IfceqlmAuwcuDNtoKVNC30g== X-Received: by 2002:a50:ed0c:0:b0:5d1:1024:978d with SMTP id 4fb4d7f45d1cf-5d110249b99mr4630395a12.7.1733327797969; Wed, 04 Dec 2024 07:56:37 -0800 (PST) X-Google-Smtp-Source: AGHT+IEF5fqN3nlV8/CR+MHwk6Fe2+q8CCMUp6X5amO1W3BwWtcyRjh+3cHMhVgLDLWNFWRIWonQJQ== X-Received: by 2002:a50:ed0c:0:b0:5d1:1024:978d with SMTP id 4fb4d7f45d1cf-5d110249b99mr4630319a12.7.1733327797178; Wed, 04 Dec 2024 07:56:37 -0800 (PST) Received: from [192.168.0.36] ([78.17.46.22]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d121d603dasm206957a12.86.2024.12.04.07.56.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2024 07:56:36 -0800 (PST) Message-ID: Date: Wed, 4 Dec 2024 15:56:35 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 21.11] net/ice/base: fix iteration of TLVs in Preserved Fields Area To: Bruce Richardson , stable@dpdk.org Cc: Fabio Pricoco , Jacob Keller , Soumyadeep Hore References: <20241204135625.2841607-1-bruce.richardson@intel.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: <20241204135625.2841607-1-bruce.richardson@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2_z1iSN8JKRIS1QV3rKFQBpvTmoByx9_Et3CZWwR0CM_1733327798 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 04/12/2024 14:56, Bruce Richardson wrote: > From: Fabio Pricoco > > Backport of commit dcb760bf0f95 ("net/ice/base: fix iteration of TLVs in > Preserved Fields Area"), for 21.11 release, replacing the use of > __builtin_add_overflow with an inline function to avoid breaking > RHEL/Centos 7. > > The ice_get_pfa_module_tlv() function iterates over the Preserved Fields > Area to read data from the Shadow RAM, including the Part Board Assembly > data, among others. > > If the specific TLV being requested is not found in the current NVM, the > code will read past the end of the PFA, misinterpreting the last word of > the PFA and the word just after the PFA as another TLV. This typically > results in one extra iteration before the length check of the while loop > is triggered. > > Correct the logic for determining the maximum PFA offset to include the > extra last word. Additionally, make the driver robust against overflows > by using check_add_overflow. This ensures that even if the NVM provides > bogus data, the driver will not overflow, and will instead log a useful > warning message. The check for whether the TLV length exceeds the PFA > length is also removed, in favor of relying on the overflow warning > instead. > > Fixes: 5d0b7b5fc491 ("net/ice/base: add read PBA module function") > Cc: stable@dpdk.org > > Signed-off-by: Fabio Pricoco > Signed-off-by: Jacob Keller > Signed-off-by: Soumyadeep Hore > Signed-off-by: Bruce Richardson > --- > drivers/net/ice/base/ice_nvm.c | 43 ++++++++++++++++++++++++---------- > 1 file changed, 31 insertions(+), 12 deletions(-) > Thanks Bruce - applied and pushed to 21.11 branch.