From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A722142B6F for ; Mon, 22 May 2023 12:21:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A242140EE7; Mon, 22 May 2023 12:21:44 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2062.outbound.protection.outlook.com [40.107.101.62]) by mails.dpdk.org (Postfix) with ESMTP id D4FF840EE5; Mon, 22 May 2023 12:21:43 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E4hhUfIdtZ/MmS+Wz9loRjtGVZScpLn4jd9ht8qVuUEa8ZBg8hxthKc1zZvkyRqOKHqyZAhyPdHkOh6/1nrpCaH5I2MSyF+3iAOu89qI9X3ZN8mbMCovy8ouYde+MaB2X4ozDjSzDzm3Fk/shAlpigjvvcl2NqIql0s95QL1dMIu86WyLahkR+unVbfvbGZ/3EvJq99FjtGi2Y0rPdfE7/MNKf+xzEB0AMVCpghXlPdp6xvossQNZ7Uea+xJU1/Ovde5GDFB/+7feKPHJbNfDt9Awv77VWhJKhiVOYk8t8Qu8zLpSwG6BGrqO8aOl6LzzpCEeDBhQxK9ixxZFU/CrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SwvN4OojiwNanmKBVvKAJ9y4OWRfOPUDsIalllJfxe4=; b=bjYzGoqHxlunWLyPilbRhwluNWWdsMxONcLKvZU1JGfobno1W/x65CNhXPML02ZoGD0ELq5bASqwQ25E2Kda/oIP/zcuq5Ba53bW3DwE5D2Mha6ZLgFl/koz2kl+jEYFnuKm7MpMACs4Dmj1JrLkgMG23UB8kfGUsw8YXgiHyr0fSVV6I2M+WgXP29GYHxBsrEPjH62XHd3OKC28YyiMeljrHEdKI/HX1K+LdwZYjcXidu8CIaODHSC/te1lyf+IFCaXW4iVDI16ZlE8KIFxdxmv+H1iAlOhQXz1lkhmzmXMWAs/tVQlnTkFzoHGXppmlwg1JUGncdF7cxGZI7hdXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SwvN4OojiwNanmKBVvKAJ9y4OWRfOPUDsIalllJfxe4=; b=Zij5TUMQo0QlUQ0UkJjHhaSl5X2GFuTIQZYoPQ0DzA4uJMtHmaGzRg+EVpkUS4GpMGlW/QurGVAX3HVcuh+Uts6t1PjwpMjRn2OCJkV+Z7CdjurO/s4l6Ip8q5I52qQOy/49KqeRpuNtY/xOacPUGj2/NHjSbhh3Dh3Uxe9JpvE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW4PR12MB5644.namprd12.prod.outlook.com (2603:10b6:303:189::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Mon, 22 May 2023 10:21:41 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::7957:641d:6aba:3f9a%4]) with mapi id 15.20.6411.028; Mon, 22 May 2023 10:21:41 +0000 Message-ID: Date: Mon, 22 May 2023 11:21:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 1/2] common/sfc_efx/base: add API to drop MAE action resource IDs Content-Language: en-US To: Ivan Malov Cc: dev@dpdk.org, Andrew Rybchenko , stable@dpdk.org, Andy Moreton , Denis Pryazhennikov References: <20230424143046.6487-1-ivan.malov@arknetworks.am> <18f3e3aa-1fc1-24a8-50c5-90e45e9cd688@amd.com> <9b77c98f-222f-566e-ec5a-8cf256d98d62@amd.com> <53d49ef-1370-b51d-4b67-3757718cedc6@arknetworks.am> From: Ferruh Yigit In-Reply-To: <53d49ef-1370-b51d-4b67-3757718cedc6@arknetworks.am> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0080.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2bd::10) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW4PR12MB5644:EE_ X-MS-Office365-Filtering-Correlation-Id: e8bc0c00-8b2a-4c77-6f7a-08db5aae55d3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 3ehXex+u1Sj0zdYOeE1a8xg94+n/ncc8WqZ/Rg+w8jFCmHr7VnJL3uvHRfjX/vXDLe/oyeYLAF14Cct1adKPLa9kCKM/nJ/1K0wO4XVJB3mTGEhy4XTuwJVEt6O38ax1upU4tfNGVsw6axRncLGF+857xeKzSDqLyvNBval12fwUxZVoaJdhg/YZle52BVj3uQw6NlsSVxxPW4K2jZ2ux2W8Tdr1UKL0umhrY59m05bdWfQn148zjql60wJGd9q9FL9oh/H+9ufoumF1vMolFJcSk6tmtk8+ASZwAafUS871EhgZKmgkDuL2Nl7oVUBPMCbB6hygu78DS1VU4XZGFn+81zrePd8Ymg2vjM5jBUPHOuzfMirflt9W3eLLSka3OrBzxB9QFSAmLLrPGUR3B7J0Qwe++LBWSXAyo5je3z9fFjSQDPM1g41vnPge2GGVA+QjpCHrnRa/ircqclAvGDzgeIn6iZSw1XvJHJoXuw0i5nAELv4/gzwLuXLv9FjLjbQINE9bgYUwzyJOntZxrGRn45JBvRQVyseruKqBa/SQPdfr54HYEBXwsEGqlaxRer0P8vTIJzJEdz9xYsE1fkYn6/QF5Kr7ksZOxy7NdZ53cZh7MbBNBm5cEy3FBWJhYGSCscdlDDRFdlr5JQpm6Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(366004)(396003)(346002)(376002)(136003)(39860400002)(451199021)(8676002)(8936002)(5660300002)(44832011)(83380400001)(186003)(26005)(53546011)(6506007)(6512007)(31696002)(86362001)(2616005)(38100700002)(41300700001)(6666004)(6486002)(66476007)(66556008)(66946007)(316002)(6916009)(4326008)(36756003)(478600001)(54906003)(2906002)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmtET2dETTlLbTUwTEJRQ2xUbE9RWTg5NkRlMnNvVEk2WUVvUWlsWVRDOXhO?= =?utf-8?B?UmpGM29Fd01YbVp5TnN2S2dlTG5TVDBZL0czZXNmSmVoRm04dkVVOTdqNUdt?= =?utf-8?B?ZnFTMkZxU2o2Mk84ZVljUE05WGp4ODhZZ2c0S0d0TjNhZU4xMkF0Mk9KZS9t?= =?utf-8?B?cXIwdHgzWFA5a3kyeExXeEs4MGZJTEZqbDFRNzVQcjJrenR3MjRiQnB0MC9m?= =?utf-8?B?Skg3dkd6aVRBNjczcVRjb3FxVnVZZGpqdGIrd25SR0p6REUxblJjV1ZENHU4?= =?utf-8?B?eWJXc2tTMlB5a1M4eGtTa25tSzhRQmk5c0dHMzVxS05SS0pHRUZMYVljZzhG?= =?utf-8?B?LzVkS3E5aWdzTDF3TXdJYnNwM1FjYnlzanNDQmFXUzVlSk53YUVDSVlEaDJi?= =?utf-8?B?N0tSNTEvUEZUK0J6eGNkYUxiN08vS2sraCtsMVh2Wmo1cWNyNWtEbVNKYTNH?= =?utf-8?B?OWs5bUFDUUdDUUFPemhqajE3MDdibWhrRVh6OW5XNFdCN2IxcVJmcFlUb0lC?= =?utf-8?B?OEUrVm1WdGtSWWRLcms1NzQyWnZRd1UwSXl5VEVtT2dwMFRObUtkZW9nSjFr?= =?utf-8?B?dEJySXVYSzMyM3ovd3BIYy8wZDVLdUFVbk1iRVh2TmozWVFYaTh4dllHQlUx?= =?utf-8?B?aFdCelQvK0FiNDdPZHZMUFlQT2dvVHB2U3dHL29hR1ZRbGQrcTRBdCtXUy9p?= =?utf-8?B?cFdRK1J2T3dCc3BTV0VlVmh4NDBIRFVIblBlVjNXYnRCYktwME56aEc3Yy83?= =?utf-8?B?dmtZdmgzZUxYRE9PcVNYdXJrRFBDeitmTFdISWJtSkJ0eTB1QkhXdEs0akUz?= =?utf-8?B?SHNxdk9GK3ExZm1QZU8weWMwUS9Gek9LbERnMGlneUl1Yk9Uc054dnhaOEFu?= =?utf-8?B?TzFXSEZLanNxUHZlSTNsRzc0MnJqR0QwMFZ6cXpyQk5NMm5tdzZzczYzN0tm?= =?utf-8?B?cEtEL2dpRThidnZjQzdjYW5HSUdhOUNmRVdRMmVYdHIxMHJReXgxVlB2S0Mx?= =?utf-8?B?QVkrSXBKSW5mUFNOSU44OStrWE1hR2kyYjZJbjFSdDVXSWZqclRNNFdqSmRM?= =?utf-8?B?bTdHNG0xK3pWOVFlMzhFbGx0YUJMSXdnc1JnZDlvNGx0SitaSGJJTnRhdmlq?= =?utf-8?B?UnBkUFNhZEo4SHNvYUd4NWJ3YTkxWUU1aC9DcEtkSHRZTVMvc2U2aUlqdEJ3?= =?utf-8?B?MnBhTzdXUVZ2UWplamtRVHVMZTd3aVdlS2FHU1M5ODdTZWk1ZU9yNEcyaFBS?= =?utf-8?B?VXF3dllpVXlidjdnM3EzRURxU1JGeFM4cDZ4dlNlRVQ1Q2lPbncyek5rWEdE?= =?utf-8?B?byttTEpJQjhaUEtDQ1V0ejBmZytEWk5SajMwOGo4cUhDczVLbklwTTBjWjh4?= =?utf-8?B?NzdSMm1IbkN6andUeWlzN3dYWXQ3Y0NvYVIxRVpMajR2NnBQQXBlMnNLbHZi?= =?utf-8?B?aVU3YytoNUhObHc2NGRuTlB3RVlVOURPVjg2WHRtNytmS0VVbjdsYkJsakxk?= =?utf-8?B?MUk0N2dMZ1p5RS9YYWhHOGFjQmpXZ3VXUXM5MCsrWkVBNloxaVV6RGxFY0JV?= =?utf-8?B?c3F3Y0U3cjVkRU52MG8rcmJ5dFQ1NTdVZm9LaHExTThsU1hEMmRBdThXdU9k?= =?utf-8?B?aXZYM0ZvYUJCNitOMFlVTVJ5aHRTalZIZXJmVDIvU3JVeWl3eEFpdVhIMVBF?= =?utf-8?B?cC83NWgxU2wyOUF3RFRBUXBIdTA0TDU3K05CYmxIRnJJZFhSc3piNE5PL0Vk?= =?utf-8?B?M0RvVmJ5K2lsdkllWFY1TWI3MVZvZXk4dlhQeTBrRDZKUEEwNjFlVW95dXAz?= =?utf-8?B?Q01xYmQ5NmZSUjhyR1NWQ1RyeGRqKzBZMUplVDE5bTRyY3dGOGJ3OWViaVBs?= =?utf-8?B?bkI1Nit0TCtzY1hEdzVHSHEwUlZHaDZIbWVVMnNKYVV2cCttVjd1L2cxRzFq?= =?utf-8?B?NGVrckpTcGN4ZjhaMmxDNjdTZE5lRUpUTWdvOEpYQWM3Mm8ydjgwUW1lUTZS?= =?utf-8?B?TjZNM3pYNG5aQjJCVzZZTWJpS3o3L1EwWXIxSmsvVE9tUnBHTzFacFkvamZv?= =?utf-8?B?UXRRaGxZOXJ5SzVabjkrRFlmQjFJM3JoT3VPVEpuK05LVkhkMFVLQ1QzSHVs?= =?utf-8?Q?B6hkjb/jmDXu5b87KA7hxLaJh?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: e8bc0c00-8b2a-4c77-6f7a-08db5aae55d3 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2023 10:21:41.6072 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 099nsglmOTaRFC/Wi7pT2mrsaHqB17etvtlgd/qzM4vq6KPDhJIfRF2u3JRLMgxo X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB5644 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 5/19/2023 10:01 AM, Ivan Malov wrote: > Hi Ferruh, > > On Fri, 19 May 2023, Ferruh Yigit wrote: > >> On 5/18/2023 6:21 PM, Ivan Malov wrote: >>> Hi Ferruh, >>> >>> Thanks for reviewing this. PSB. >>> >>> On Thu, 18 May 2023, Ferruh Yigit wrote: >>> >>>> On 4/24/2023 3:30 PM, Ivan Malov wrote: >>>>> When the client driver (the DPDK one, for instance) parses user flow >>>>> actions, it ends up with an action set specification. Next, in case >>>>> there are any FW resource-backed actions, like COUNT or SET_DST_MAC, >>>>> the driver allocates these resources and indicates their IDs in the >>>>> action set specification. The API used to set these IDs checks that >>>>> the current value of the target ID is INVALID, prior to the call. >>>>> >>>>> The latter check, however, prevents the driver from updating the >>>>> IDs on port restart. When the port goes down, the driver frees >>>>> the resources. When the port goes up, the driver reallocates >>>>> them, tries to set the IDs in the specification and fails. >>>>> >>>>> In order to address the problem, add an API to drop the >>>>> current resource IDs in the actions set specification. >>>>> >>>>> Fixes: 3907defa5bf0 ("common/sfc_efx/base: support adding encap >>>>> action to a set") >>>>> Cc: stable@dpdk.org> >>>> >>>> Hi Ivan, >>>> >>>> As far as I understand this patch extracts some code into a >>>> function, so >>>> I expect no functional change in this patch. So not clear what this >>>> patch is fixing? >>>> >>>> And I can see this new API is used in next patch and it fixes an issue. >>>> But while backporting this fix to LTS we want both patch to backport >>>> because there is a dependency. >>>> >>>> If there is no functional change in this patch, what about merging >>>> these >>>> two patches, and explain what is fixed? This also helps backporting. >>>> >>> >>> As far as I know, changes to different trees (common/sfc_efx/base on the >>> one hand and drivers/net/sfc on the other) belong in separate patches. >>> Please correct me in case I've got that wrong. >>> >>> Anyway, if it's not that hard to backport the two patches in their >>> current state, I vote for keeping them like that. I don't insist. >>> >> >> I think changes are simple and can go into single patch to help >> dependency between two. >> >> > Thanks for perseverance. Now you mention it, what prefix in the summary > should I use? Just "drivers: "? For the unified patch, that is. > updated as 'net/sfc: ...' while merging.