From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 087DA45E5A for ; Mon, 9 Dec 2024 11:25:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D55564025D; Mon, 9 Dec 2024 11:25:05 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 82E124025D for ; Mon, 9 Dec 2024 11:25:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733739904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CzubW7uKf9YlqwzjHpvxdjO5KAddmbtaMTchwbZud4s=; b=f+e8vLqyjBckS8Wo82QapZOpM4AIeX+ZzMSphORuMgPj35kxvhGTRBQ6zVLe4reVr1PLJP 5hdEp775gLVAIq080HLLvf/ZZTCpy1Irr0htUrkgX2ojP3iGoZYmRqqasB4yJs8wa+ED9X FfEJsJnXQV6wCb5Ss/7p57FQgDp+U3A= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-155-P2Qmm8MhP7ygtfEBeR0iXQ-1; Mon, 09 Dec 2024 05:25:02 -0500 X-MC-Unique: P2Qmm8MhP7ygtfEBeR0iXQ-1 X-Mimecast-MFC-AGG-ID: P2Qmm8MhP7ygtfEBeR0iXQ Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-434f02ea82dso13123655e9.3 for ; Mon, 09 Dec 2024 02:25:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733739902; x=1734344702; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CzubW7uKf9YlqwzjHpvxdjO5KAddmbtaMTchwbZud4s=; b=GYl5RhANfxjlaXWxNZjVHAhW9FZ7oKPPWd8wZ+bOBFIJPRyDGGsGhl+6V0xDAFUZ7b 9PtElWMfG/p0swQJyDt9+F08pIpT1uv+kSWYKWizWZTo7ykqF3+LYvAJXF4NSJapnooX U6DOCKh1ZjLxL3klKjAhwobX1Imhusmo/ZsXjxtDTjc6HPPMHkM138yxfNPzaU74f2t/ OESltEwmTmLi9V8bgtW1umIxHx8A6xYlOr1WbIJ409jlYPhZbZmrtWPtyDwK/MAXNjHn qsNEGthI5Gr9KwpbCLlCaEY+j2E3pXSJMqA8q9/m0ghb27CNLMRHE/uKp7TOKmhQQBkq q3tw== X-Forwarded-Encrypted: i=1; AJvYcCVCXJJUpCwrC+3W907Z4dSKwMETVHh9S6dQB8viDMHAevgUS+r4k0A1Bgd574LHVEZhbTx3CFk=@dpdk.org X-Gm-Message-State: AOJu0YxrvP/DT8/gKMK6611UN+Q2pX8/guefOTdd5PGJqEWuPwrfDyhZ FASlunmbQ89M9zQtlbvXeDBUH7M340I71HSVgddd6jTevoT7lKweB4yDUtXPf+rZuL/fnoC1Om3 S1CVSk8rbsU8bvsXOZjQb4R3YNx+GA0Fe0XIMM5GQY9yz X-Gm-Gg: ASbGncs/3HpzV7u+44id/LZG1x+sBaXTsU2C0J8uXJ0jvc5cJ25PT/3SG/+iibEKXQt D3xMEp7uwvOm3AK/uvwLSDZ/eb2XojjU8bMHv7Q305/QW2+e6bjNQFnhUW1NDamwbF5JLELlJl2 nYlG/2elqRpW8z5zavgAj4/OtiqzZoQjzMp2dF2iWrn8drdo1kulbUC50k14eVSct//8+7RV+72 cXsEQxBnDP9TIWSlXMP3GpmDkl5j35y/sdIeYDngbusimqkxg== X-Received: by 2002:a05:600c:4ed4:b0:430:5887:c238 with SMTP id 5b1f17b1804b1-434ddeb367dmr88293935e9.11.1733739901801; Mon, 09 Dec 2024 02:25:01 -0800 (PST) X-Google-Smtp-Source: AGHT+IGr4iNVqO4z2gRsOiUAND3miyZ2l5Gr2wRvt839mYlZtsVjvWF4SW1ScVlABqGrcaEJBHxioA== X-Received: by 2002:a05:600c:4ed4:b0:430:5887:c238 with SMTP id 5b1f17b1804b1-434ddeb367dmr88293695e9.11.1733739901385; Mon, 09 Dec 2024 02:25:01 -0800 (PST) Received: from [192.168.0.36] ([78.17.46.44]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434f13f735csm66221145e9.16.2024.12.09.02.25.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Dec 2024 02:25:00 -0800 (PST) Message-ID: Date: Mon, 9 Dec 2024 10:25:00 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: patch 'power: fix mapped lcore ID' has been queued to stable release 21.11.9 To: "Tummala, Sivaprasad" , David Marchand Cc: Konstantin Ananyev , Huisong Li , dpdk stable References: <20241127171916.690404-1-ktraynor@redhat.com> <20241127171916.690404-69-ktraynor@redhat.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 198dELCmKqxWwbrpvnhk3ghYaNBa8YWCDf6n1s99F5k_1733739902 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 09/12/2024 10:21, Tummala, Sivaprasad wrote: > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi David, > >> -----Original Message----- >> From: David Marchand >> Sent: Monday, December 9, 2024 12:30 PM >> To: Kevin Traynor >> Cc: Tummala, Sivaprasad ; Konstantin Ananyev >> ; Huisong Li ; dpdk >> stable >> Subject: Re: patch 'power: fix mapped lcore ID' has been queued to stable release >> 21.11.9 >> >> Caution: This message originated from an External Source. Use proper caution >> when opening attachments, clicking links, or responding. >> >> >> On Wed, Nov 27, 2024 at 6:22 PM Kevin Traynor wrote: >>> Diff of the applied patch vs upstream commit (please double-check if non-empty: >>> --- >>> --- - 2024-11-27 17:17:40.435934249 +0000 >>> +++ 0069-power-fix-mapped-lcore-ID.patch 2024-11-27 17:17:38.262269565 >> +0000 >>> @@ -1 +1 @@ >>> -From 5c9b07eeba55d527025f1f4945e2dbb366f21215 Mon Sep 17 00:00:00 2001 >>> +From 939535ca3bed8f1c9013baba9691ca356cca6d3b Mon Sep 17 00:00:00 >> 2001 >>> @@ -5,0 +6,2 @@ >>> +[ upstream commit 5c9b07eeba55d527025f1f4945e2dbb366f21215 ] >>> + >>> @@ -25 +26,0 @@ >>> -Cc: stable@dpdk.org >>> @@ -31,8 +32,8 @@ >>> - app/test/test_power_cpufreq.c | 21 ++++++++++++++++++--- >>> - lib/power/power_acpi_cpufreq.c | 6 +++++- >>> - lib/power/power_amd_pstate_cpufreq.c | 6 +++++- >>> - lib/power/power_common.c | 23 +++++++++++++++++++++++ >>> - lib/power/power_common.h | 1 + >>> - lib/power/power_cppc_cpufreq.c | 6 +++++- >>> - lib/power/power_pstate_cpufreq.c | 6 +++++- >>> - 7 files changed, 62 insertions(+), 7 deletions(-) >>> + app/test/test_power_cpufreq.c | 21 ++++++++++++++++++--- >>> + lib/power/power_acpi_cpufreq.c | 6 +++++- >>> + lib/power/power_common.c | 23 +++++++++++++++++++++++ >>> + lib/power/power_common.h | 1 + >>> + lib/power/power_cppc_cpufreq.c | 6 +++++- >>> + lib/power/power_pstate_cpufreq.c | 6 +++++- >>> + lib/power/rte_power_pmd_mgmt.c | 4 ++-- >>> + 7 files changed, 59 insertions(+), 8 deletions(-) >>> @@ -41 +42 @@ >>> -index 619b2811c6..edbd34424e 100644 >>> +index 4d013cd7bb..051b9036dc 100644 >>> @@ -74 +75 @@ >>> -@@ -498,4 +500,17 @@ test_power_cpufreq(void) >>> +@@ -487,4 +489,17 @@ test_power_cpufreq(void) >>> @@ -93 +94 @@ >>> -index abad53bef1..ae809fbb60 100644 >>> +index 402ed8c99b..1bb74bdca6 100644 >>> @@ -101,16 +102 @@ >>> -+ POWER_LOG(ERR, "Cannot get CPU ID mapped for lcore %u", >> lcore_id); >>> -+ return -1; >>> -+ } >>> -+ >>> - /* Check and set the governor */ >>> - if (power_set_governor_userspace(pi) < 0) { >>> -diff --git a/lib/power/power_amd_pstate_cpufreq.c >> b/lib/power/power_amd_pstate_cpufreq.c >>> -index 4809d45a22..2b728eca18 100644 >>> ---- a/lib/power/power_amd_pstate_cpufreq.c >>> -+++ b/lib/power/power_amd_pstate_cpufreq.c >>> -@@ -383,5 +383,9 @@ power_amd_pstate_cpufreq_init(unsigned int lcore_id) >>> - } >>> - >>> -- pi->lcore_id = lcore_id; >>> -+ if (power_get_lcore_mapped_cpu_id(lcore_id, &pi->lcore_id) < 0) { >>> -+ POWER_LOG(ERR, "Cannot get CPU ID mapped for lcore %u", >> lcore_id); >>> ++ RTE_LOG(ERR, POWER, "Cannot get CPU ID mapped for lcore >> %u", lcore_id); >> >> A final \n is missing in the format string. >> >>> @@ -123 +109 @@ >>> -index 590986d5ef..b47c63a5f1 100644 >>> +index 1e09facb86..e2a8c33604 100644 >>> @@ -132 +118 @@ >>> -@@ -205,2 +206,24 @@ out: >>> +@@ -203,2 +204,24 @@ out: >>> @@ -143 +129 @@ >>> -+ POWER_LOG(ERR, >>> ++ RTE_LOG(ERR, POWER, >> >> Probably the same here, and other occurences in this patch. > LGTM! > Thanks for reporting David. I will send a patch to fix this. Kevin. >> >> >> -- >> David Marchand >