* Re: [dpdk-stable] [PATCH v2 1/2] net/pcap: multiple queues fix
[not found] <1529419046-95906-1-git-send-email-ido@cgstowernetworks.com>
@ 2018-06-20 18:22 ` Ferruh Yigit
2018-06-26 11:06 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Ferruh Yigit @ 2018-06-20 18:22 UTC (permalink / raw)
To: ido goshen; +Cc: dev, stable
On 6/19/2018 3:37 PM, ido goshen wrote:
> Fixes: 4c173302c307 ("pcap: add new driver")
> Cc: stable@dpdk.org
>
> Change open_rx/tx_pcap/iface functions to open only a single pcap/dumper
> and not loop num_of_queue times
> The num_of_queue loop is already acheived by the caller rte_kvargs_process
>
> Fixes:
> 1. Opens N requested pcaps/dumpers instead of N^2
> 2. Leak of pcap/dumper's which are being overwritten by
> the sequential calls to open_rx/tx_pcap/iface functions
> 3. Use the filename/iface args per queue and not just the last one
> that overwrites the previous names
>
> Signed-off-by: ido goshen <ido@cgstowernetworks.com>
For series,
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH v2 1/2] net/pcap: multiple queues fix
2018-06-20 18:22 ` [dpdk-stable] [PATCH v2 1/2] net/pcap: multiple queues fix Ferruh Yigit
@ 2018-06-26 11:06 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2018-06-26 11:06 UTC (permalink / raw)
To: ido goshen; +Cc: dev, stable
On 6/20/2018 7:22 PM, Ferruh Yigit wrote:
> On 6/19/2018 3:37 PM, ido goshen wrote:
>> Fixes: 4c173302c307 ("pcap: add new driver")
>> Cc: stable@dpdk.org
>>
>> Change open_rx/tx_pcap/iface functions to open only a single pcap/dumper
>> and not loop num_of_queue times
>> The num_of_queue loop is already acheived by the caller rte_kvargs_process
>>
>> Fixes:
>> 1. Opens N requested pcaps/dumpers instead of N^2
>> 2. Leak of pcap/dumper's which are being overwritten by
>> the sequential calls to open_rx/tx_pcap/iface functions
>> 3. Use the filename/iface args per queue and not just the last one
>> that overwrites the previous names
>>
>> Signed-off-by: ido goshen <ido@cgstowernetworks.com>
>
> For series,
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Series applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-26 11:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1529419046-95906-1-git-send-email-ido@cgstowernetworks.com>
2018-06-20 18:22 ` [dpdk-stable] [PATCH v2 1/2] net/pcap: multiple queues fix Ferruh Yigit
2018-06-26 11:06 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).