From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83DDF47165 for ; Fri, 2 Jan 2026 15:33:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77E08402F2; Fri, 2 Jan 2026 15:33:07 +0100 (CET) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by mails.dpdk.org (Postfix) with ESMTP id 5DC5140262; Fri, 2 Jan 2026 15:33:05 +0100 (CET) Received: from mail.maildlp.com (unknown [172.18.224.83]) by frasgout.his.huawei.com (SkyGuard) with ESMTPS id 4djR3W57DCzHnGfP; Fri, 2 Jan 2026 22:32:07 +0800 (CST) Received: from frapema500003.china.huawei.com (unknown [7.182.19.114]) by mail.maildlp.com (Postfix) with ESMTPS id 8B1404056F; Fri, 2 Jan 2026 22:33:04 +0800 (CST) Received: from frapema500003.china.huawei.com (7.182.19.114) by frapema500003.china.huawei.com (7.182.19.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 2 Jan 2026 15:33:04 +0100 Received: from frapema500003.china.huawei.com ([7.182.19.114]) by frapema500003.china.huawei.com ([7.182.19.114]) with mapi id 15.02.1544.011; Fri, 2 Jan 2026 15:33:04 +0100 From: Marat Khalili To: Stephen Hemminger , "dev@dpdk.org" CC: "stable@dpdk.org" , Anatoly Burakov , Cristian Dumitrescu , Pablo de Lara Subject: RE: [PATCH v10 5/9] test: fix format overflow warning in ACL test Thread-Topic: [PATCH v10 5/9] test: fix format overflow warning in ACL test Thread-Index: AQHceQ63RbMYqUoa4kyYsdyYmPvrW7U+9scw Date: Fri, 2 Jan 2026 14:33:04 +0000 Message-ID: References: <20251110182209.104087-1-stephen@networkplumber.org> <20251229220053.21981-1-stephen@networkplumber.org> <20251229220053.21981-6-stephen@networkplumber.org> In-Reply-To: <20251229220053.21981-6-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.206.137.70] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Monday 29 December 2025 21:59 > To: dev@dpdk.org > Cc: Stephen Hemminger ; stable@dpdk.org; Anat= oly Burakov > ; Cristian Dumitrescu ; Pablo de Lara > > Subject: [PATCH v10 5/9] test: fix format overflow warning in ACL test >=20 > This test has an array of input lines, but the two dimensional > array confuses compiler length checks. Convert to an array > of pointers to fixed strings which avoids the problem. > Make both variables static since not shared with other code. >=20 > Fixes: 5205954791cb ("app/test: packet framework unit tests") > Cc: stable@dpdk.org >=20 > Signed-off-by: Stephen Hemminger > Acked-by: Anatoly Burakov > --- > app/test/test_table_acl.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test/test_table_acl.c b/app/test/test_table_acl.c > index dff9bddfb9..94edf37234 100644 > --- a/app/test/test_table_acl.c > +++ b/app/test/test_table_acl.c > @@ -317,7 +317,7 @@ parse_cb_ipv4_rule_del(char *str, struct rte_table_ac= l_rule_delete_params *v) > * separated by ' : ', just ':'. It's a lot more readable and > * cleaner, IMO. > */ > -char lines[][128] =3D { > +static const char * const lines[] =3D { > "@0.0.0.0/0 0.0.0.0/0 0:65535 0:65535 2/0xff", /* Protocol check */ > "@192.168.3.1/32 0.0.0.0/0 0:65535 0:65535 0/0", /* Src IP checl */ > "@0.0.0.0/0 10.4.4.1/32 0:65535 0:65535 0/0", /* dst IP check */ > @@ -325,7 +325,7 @@ char lines[][128] =3D { > "@0.0.0.0/0 0.0.0.0/0 0:65535 206:206 0/0", /* dst port check */ > }; >=20 > -char line[128]; > +static char line[128]; >=20 >=20 > static int > -- > 2.51.0 I feel like both could also be made local to setup_acl_pipeline. With or without this optimization, Acked-by: Marat Khalili