From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E681A04B4 for ; Fri, 8 Nov 2019 15:47:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ABB9F1C20E; Fri, 8 Nov 2019 15:47:57 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 202561C1F2 for ; Fri, 8 Nov 2019 15:47:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573224474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BFa+0MNMbrMJI1BZtcfcfx1LznOVU0nTml66+5riizw=; b=UsOfMfp7uvaFWpnXBixUt4KJ/KW4tXfcHRhI2+c0nTMdJ9+WmnvvXektsPt3lygZbrqtMU kJUQaFfPvIH8l6s8O7TMwM4b/OG+wCXBjTabdu5VQfXiP/xA/tUibXP7ygbk+FagDMqDNr wmtjA72cTceg4Fa3gMWi9XMsrC6Lepc= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-391-0YKBclclP12ATnrec7qrRA-1; Fri, 08 Nov 2019 09:47:51 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 848C1180491C; Fri, 8 Nov 2019 14:47:50 +0000 (UTC) Received: from [10.36.118.56] (unknown [10.36.118.56]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4D57E6084E; Fri, 8 Nov 2019 14:47:46 +0000 (UTC) To: "Xu, Rosen" , David Marchand Cc: dev , dpdk stable , "Ye, Xiaolong" References: <20191001125315.6191-1-ktraynor@redhat.com> <20191001130405.7076-1-ktraynor@redhat.com> <20191001130405.7076-3-ktraynor@redhat.com> <36d7696c-f0ca-003c-cba5-e78734120375@redhat.com> <0E78D399C70DA940A335608C6ED296D73AB392C6@SHSMSX104.ccr.corp.intel.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: Date: Fri, 8 Nov 2019 14:47:45 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <0E78D399C70DA940A335608C6ED296D73AB392C6@SHSMSX104.ccr.corp.intel.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: 0YKBclclP12ATnrec7qrRA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit check logic X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On 08/11/2019 14:45, Xu, Rosen wrote: > Hi Kevin, >=20 > Too many things in these days, sorry for late reply. >=20 Hi Rosen, no problem, thanks for the Ack. Kevin. >> -----Original Message----- >> From: Kevin Traynor [mailto:ktraynor@redhat.com] >> Sent: Tuesday, November 05, 2019 23:42 >> To: David Marchand ; Xu, Rosen >> >> Cc: dev ; dpdk stable ; Ye, Xiaolong >> >> Subject: Re: [dpdk-dev] [PATCH 4/9] net/ipn3ke: fix incorrect commit che= ck >> logic >> >> On 30/10/2019 07:59, David Marchand wrote: >>> Hello Rosen, >>> >>> Review please. >>> >> >> Ping Rosen. >> >>> On Tue, Oct 1, 2019 at 3:04 PM Kevin Traynor >> wrote: >>>> >>>> Coverity is complaining about identical code regardless of which >>>> branch of the if else is taken. Functionally it means an error will >>>> always be returned if this if else is hit. Remove the else branch. >>>> >>>> CID 337928 (#1 of 1): Identical code for different branches >>>> (IDENTICAL_BRANCHES)identical_branches: The same code is executed >>>> regardless of whether n->level !=3D IPN3KE_TM_NODE_LEVEL_COS || >>>> n->n_children !=3D 0U is true, because the 'then' and 'else' branc= hes >>>> are identical. Should one of the branches be modified, or the enti= re >>>> 'if' statement replaced? >=20 > Yes, you are right. >=20 >>>> 1506 if (n->level !=3D IPN3KE_TM_NODE_LEVEL_COS || >>>> 1507 n->n_children !=3D 0) { >>>> 1508 return -rte_tm_error_set(error, >>>> 1509 EINVAL, >>>> 1510 RTE_TM_ERROR_TYPE_UNSPECIFIED, >>>> 1511 NULL, >>>> 1512 rte_strerror(EINVAL)); >>>> else_branch: The else branch, identical to the then branch. >>>> 1513 } else { >>>> 1514 return -rte_tm_error_set(error, >>>> 1515 EINVAL, >>>> 1516 RTE_TM_ERROR_TYPE_UNSPECIFIED, >>>> 1517 NULL, >>>> 1518 rte_strerror(EINVAL)); >>>> 1519 } >>>> >>>> Coverity issue: 337928 >>>> Fixes: c820468ac99c ("net/ipn3ke: support TM") >>>> Cc: rosen.xu@intel.com >>>> Cc: stable@dpdk.org >>>> >>>> Signed-off-by: Kevin Traynor >>>> --- >>>> drivers/net/ipn3ke/ipn3ke_tm.c | 6 ------ >>>> 1 file changed, 6 deletions(-) >>>> >>>> diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c >>>> b/drivers/net/ipn3ke/ipn3ke_tm.c index adf02c157..a93145d59 100644 >>>> --- a/drivers/net/ipn3ke/ipn3ke_tm.c >>>> +++ b/drivers/net/ipn3ke/ipn3ke_tm.c >>>> @@ -1511,10 +1511,4 @@ ipn3ke_tm_hierarchy_commit_check(struct >> rte_eth_dev *dev, >>>> NULL, >>>> rte_strerror(EINVAL)); >>>> - } else { >>>> - return -rte_tm_error_set(error, >>>> - EINVAL, >>>> - RTE_TM_ERROR_TYPE_UNSP= ECIFIED, >>>> - NULL, >>>> - rte_strerror(EINVAL)); >>>> } >>>> } >>>> -- >>>> 2.21.0 >>>> >>> >=20 > Reviewed-by: Rosen Xu >=20