[dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters

[dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters

[Stephen Hemminger]

In order to change RSS parameters, the host requires that RSS
is disable first.

Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
Cc: stable@dpdk.org
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 164e9ad174a7..575780ee5f26 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev *dev,
 			hv->rss_ind[i] = reta_conf[idx].reta[shift];
 	}
 
+	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+	if (err) {
+		PMD_DRV_LOG(NOTICE,
+			"rss disable failed");
+		return err;
+	}
+
 	err = hn_rndis_conf_rss(hv, 0);
 	if (err) {
 		PMD_DRV_LOG(NOTICE,
@@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev *dev)
 			return err;
 		}
 
+		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+		if (err) {
+			PMD_DRV_LOG(NOTICE,
+				"rss disable failed");
+			return err;
+		}
+
 		err = hn_rndis_conf_rss(hv, 0);
 		if (err) {
 			PMD_DRV_LOG(NOTICE,
-- 
2.20.1

Re: [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters

[Ferruh Yigit]

On 11/25/2019 5:13 PM, Stephen Hemminger wrote:
> In order to change RSS parameters, the host requires that RSS
> is disable first.
> 
> Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
> Cc: stable@dpdk.org
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Applied to dpdk-next-net/master, thanks.

[dpdk-stable] [PATCH v2 1/2] net/netvsc: fix RSS offload flag

[Stephen Hemminger]

The change to add OFFLOAD_RSS_HASH broke use of netvsc PMD
with testpmd. The netvsc driver fails during configure step:

	Configuring Port 1 (socket 0)
	hn_dev_configure(): unsupported RX offload: 0x80000

Fixes: 5d308972954c ("ethdev: add mbuf RSS update as an offload")
Cc: pbhagavatula@marvell.com
Cc: stable@dpdk.org
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/netvsc/hn_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 164e9ad174a7..5ef7a452cc69 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -42,7 +42,8 @@
 			    DEV_TX_OFFLOAD_VLAN_INSERT)
 
 #define HN_RX_OFFLOAD_CAPS (DEV_RX_OFFLOAD_CHECKSUM | \
-			    DEV_RX_OFFLOAD_VLAN_STRIP)
+			    DEV_RX_OFFLOAD_VLAN_STRIP | \
+			    DEV_RX_OFFLOAD_RSS_HASH)
 
 int hn_logtype_init;
 int hn_logtype_driver;
-- 
2.20.1

[dpdk-stable] [PATCH v2 2/2] net/netvsc: disable before changing RSS parameters

[Stephen Hemminger]

In order to change RSS parameters, the host requires that RSS
is disable first.

Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
Cc: stable@dpdk.org
Tested-by: Abhishek Marathe <abmarath@microsoft.com>
Signed-off-by: Dexuan Cui <decui@microsoft.com>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 5ef7a452cc69..159116f7f691 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -292,6 +292,13 @@ static int hn_rss_reta_update(struct rte_eth_dev *dev,
 			hv->rss_ind[i] = reta_conf[idx].reta[shift];
 	}
 
+	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+	if (err) {
+		PMD_DRV_LOG(NOTICE,
+			"rss disable failed");
+		return err;
+	}
+
 	err = hn_rndis_conf_rss(hv, 0);
 	if (err) {
 		PMD_DRV_LOG(NOTICE,
@@ -579,6 +586,13 @@ static int hn_dev_configure(struct rte_eth_dev *dev)
 			return err;
 		}
 
+		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
+		if (err) {
+			PMD_DRV_LOG(NOTICE,
+				"rss disable failed");
+			return err;
+		}
+
 		err = hn_rndis_conf_rss(hv, 0);
 		if (err) {
 			PMD_DRV_LOG(NOTICE,
-- 
2.20.1

Re: [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters

[Stephen Hemminger]

On Tue, 10 Dec 2019 02:31:31 +0000
"Donald_Lee@trendmicro.com" <Donald_Lee@trendmicro.com> wrote:

> Hi Dexuan, 
> 
> Yes! Can you please add my signed-off on it? Our mailing system will add extra space on the patch last time I did. Thank you.
> 
> Regards,
> Donald
>     

Thanks.

Re: [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters

[Donald_Lee]

On 10/12/2019, 5:29 AM, "Dexuan Cui" <decui@microsoft.com> wrote:

    
    This message was sent from outside of Trend Micro. Please do not click links or open attachments unless you recognise the source of this email and know the content is safe.
    
    
    > From: Dexuan Cui
    > Sent: Monday, November 25, 2019 7:29 PM
    > To: Stephen Hemminger <stephen@networkplumber.org>; dev@dpdk.org;
    > Donald_Lee@trendmicro.com
    > Cc: stable@dpdk.org
    > Subject: RE: [PATCH] net/netvsc: disable before changing RSS parameters
    >
    > > From: Stephen Hemminger <stephen@networkplumber.org>
    > > Sent: Monday, November 25, 2019 9:13 AM
    > > To: dev@dpdk.org
    > > Cc: Stephen Hemminger <stephen@networkplumber.org>;
    > stable@dpdk.org;
    > > Dexuan Cui <decui@microsoft.com>
    > >
    > > In order to change RSS parameters, the host requires that RSS
    > > is disable first.
    > >
    > > Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
    > > Cc: stable@dpdk.org
    > > Signed-off-by: Dexuan Cui <decui@microsoft.com>
    > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
    > > ---
    > >  drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
    > >  1 file changed, 14 insertions(+)
    > >
    > > diff --git a/drivers/net/netvsc/hn_ethdev.c
    > b/drivers/net/netvsc/hn_ethdev.c
    > > index 164e9ad174a7..575780ee5f26 100644
    > > --- a/drivers/net/netvsc/hn_ethdev.c
    > > +++ b/drivers/net/netvsc/hn_ethdev.c
    > > @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev
    > > *dev,
    > >                     hv->rss_ind[i] = reta_conf[idx].reta[shift];
    > >     }
    > >
    > > +   err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
    > > +   if (err) {
    > > +           PMD_DRV_LOG(NOTICE,
    > > +                   "rss disable failed");
    > > +           return err;
    > > +   }
    > > +
    > >     err = hn_rndis_conf_rss(hv, 0);
    > >     if (err) {
    > >             PMD_DRV_LOG(NOTICE,
    > > @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev
    > > *dev)
    > >                     return err;
    > >             }
    > >
    > > +           err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
    > > +           if (err) {
    > > +                   PMD_DRV_LOG(NOTICE,
    > > +                           "rss disable failed");
    > > +                   return err;
    > > +           }
    > > +
    > >             err = hn_rndis_conf_rss(hv, 0);
    > >             if (err) {
    > >                     PMD_DRV_LOG(NOTICE,
    > > --
    > > 2.20.1
    >
    > Hi, Stephen,
    > I think the patch originally came from Donald Lee (I added him to "To").
    >
    > IMO Donald's Signed-off-by should be added.
    >
    > And, can you please change my Signed-off-by to Tested-by?
    >
    > Thanks,
    > -- Dexuan
    
    Hi Donald,
    Since you originally made the patch, can you please confirm that your
    Signed-off-by
    "Signed-off-by: Donald Lee <Donald_Lee@trendmicro.com>"
    can be added into the patch's changelog?
    
    Thanks,
    -- Dexuan


Hi Dexuan, 

Yes! Can you please add my signed-off on it? Our mailing system will add extra space on the patch last time I did. Thank you.

Regards,
Donald
    


<table class="TM_EMAIL_NOTICE"><tr><td><pre>
TREND MICRO EMAIL NOTICE
The information contained in this email and any attachments is confidential 
and may be subject to copyright or other intellectual property protection. 
If you are not the intended recipient, you are not authorized to use or 
disclose this information, and we request that you notify us by reply mail or
telephone and delete the original message from your mail system.

For details about what personal information we collect and why, please see our Privacy Notice on our website at: [ https://www.trendmicro.com/privacy] 
</pre></td></tr></table>

Re: [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters

[Dexuan Cui]

> From: Dexuan Cui
> Sent: Monday, November 25, 2019 7:29 PM
> To: Stephen Hemminger <stephen@networkplumber.org>; dev@dpdk.org;
> Donald_Lee@trendmicro.com
> Cc: stable@dpdk.org
> Subject: RE: [PATCH] net/netvsc: disable before changing RSS parameters
> 
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Monday, November 25, 2019 9:13 AM
> > To: dev@dpdk.org
> > Cc: Stephen Hemminger <stephen@networkplumber.org>;
> stable@dpdk.org;
> > Dexuan Cui <decui@microsoft.com>
> >
> > In order to change RSS parameters, the host requires that RSS
> > is disable first.
> >
> > Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
> > Cc: stable@dpdk.org
> > Signed-off-by: Dexuan Cui <decui@microsoft.com>
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> >  drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/net/netvsc/hn_ethdev.c
> b/drivers/net/netvsc/hn_ethdev.c
> > index 164e9ad174a7..575780ee5f26 100644
> > --- a/drivers/net/netvsc/hn_ethdev.c
> > +++ b/drivers/net/netvsc/hn_ethdev.c
> > @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev
> > *dev,
> >  			hv->rss_ind[i] = reta_conf[idx].reta[shift];
> >  	}
> >
> > +	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
> > +	if (err) {
> > +		PMD_DRV_LOG(NOTICE,
> > +			"rss disable failed");
> > +		return err;
> > +	}
> > +
> >  	err = hn_rndis_conf_rss(hv, 0);
> >  	if (err) {
> >  		PMD_DRV_LOG(NOTICE,
> > @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev
> > *dev)
> >  			return err;
> >  		}
> >
> > +		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
> > +		if (err) {
> > +			PMD_DRV_LOG(NOTICE,
> > +				"rss disable failed");
> > +			return err;
> > +		}
> > +
> >  		err = hn_rndis_conf_rss(hv, 0);
> >  		if (err) {
> >  			PMD_DRV_LOG(NOTICE,
> > --
> > 2.20.1
> 
> Hi, Stephen,
> I think the patch originally came from Donald Lee (I added him to "To").
> 
> IMO Donald's Signed-off-by should be added.
> 
> And, can you please change my Signed-off-by to Tested-by?
> 
> Thanks,
> -- Dexuan

Hi Donald,
Since you originally made the patch, can you please confirm that your
Signed-off-by 
"Signed-off-by: Donald Lee <Donald_Lee@trendmicro.com>"
can be added into the patch's changelog? 

Thanks,
-- Dexuan

Re: [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters

[Dexuan Cui]

> From: Dexuan Cui
> Sent: Monday, November 25, 2019 7:29 PM
> To: Stephen Hemminger <stephen@networkplumber.org>; dev@dpdk.org;
> Donald_Lee@trendmicro.com
> Cc: stable@dpdk.org
> Subject: RE: [PATCH] net/netvsc: disable before changing RSS parameters
> 
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Monday, November 25, 2019 9:13 AM
> > To: dev@dpdk.org
> > Cc: Stephen Hemminger <stephen@networkplumber.org>;
> stable@dpdk.org;
> > Dexuan Cui <decui@microsoft.com>
> >
> > In order to change RSS parameters, the host requires that RSS
> > is disable first.
> >
> > Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
> > Cc: stable@dpdk.org
> > Signed-off-by: Dexuan Cui <decui@microsoft.com>
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> >  drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
> >  1 file changed, 14 insertions(+)
> >
> > diff --git a/drivers/net/netvsc/hn_ethdev.c
> b/drivers/net/netvsc/hn_ethdev.c
> > index 164e9ad174a7..575780ee5f26 100644
> > --- a/drivers/net/netvsc/hn_ethdev.c
> > +++ b/drivers/net/netvsc/hn_ethdev.c
> > @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev
> > *dev,
> >  			hv->rss_ind[i] = reta_conf[idx].reta[shift];
> >  	}
> >
> > +	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
> > +	if (err) {
> > +		PMD_DRV_LOG(NOTICE,
> > +			"rss disable failed");
> > +		return err;
> > +	}
> > +
> >  	err = hn_rndis_conf_rss(hv, 0);
> >  	if (err) {
> >  		PMD_DRV_LOG(NOTICE,
> > @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev
> > *dev)
> >  			return err;
> >  		}
> >
> > +		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
> > +		if (err) {
> > +			PMD_DRV_LOG(NOTICE,
> > +				"rss disable failed");
> > +			return err;
> > +		}
> > +
> >  		err = hn_rndis_conf_rss(hv, 0);
> >  		if (err) {
> >  			PMD_DRV_LOG(NOTICE,
> > --
> > 2.20.1
> 
> Hi, Stephen,
> I think the patch originally came from Donald Lee (I added him to "To").
> 
> IMO Donald's Signed-off-by should be added.
> 
> And, can you please change my Signed-off-by to Tested-by?
> 
> -- Dexuan

Also, please add Tested-by for 

Abhishek Marathe <abmarath@microsoft.com> (Cc'd).

Thanks,
-- Dexuan

Re: [dpdk-stable] [PATCH] net/netvsc: disable before changing RSS parameters

[Dexuan Cui]

> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Monday, November 25, 2019 9:13 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; stable@dpdk.org;
> Dexuan Cui <decui@microsoft.com>
> 
> In order to change RSS parameters, the host requires that RSS
> is disable first.
> 
> Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters")
> Cc: stable@dpdk.org
> Signed-off-by: Dexuan Cui <decui@microsoft.com>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/net/netvsc/hn_ethdev.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
> index 164e9ad174a7..575780ee5f26 100644
> --- a/drivers/net/netvsc/hn_ethdev.c
> +++ b/drivers/net/netvsc/hn_ethdev.c
> @@ -291,6 +291,13 @@ static int hn_rss_reta_update(struct rte_eth_dev
> *dev,
>  			hv->rss_ind[i] = reta_conf[idx].reta[shift];
>  	}
> 
> +	err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
> +	if (err) {
> +		PMD_DRV_LOG(NOTICE,
> +			"rss disable failed");
> +		return err;
> +	}
> +
>  	err = hn_rndis_conf_rss(hv, 0);
>  	if (err) {
>  		PMD_DRV_LOG(NOTICE,
> @@ -578,6 +585,13 @@ static int hn_dev_configure(struct rte_eth_dev
> *dev)
>  			return err;
>  		}
> 
> +		err = hn_rndis_conf_rss(hv, NDIS_RSS_FLAG_DISABLE);
> +		if (err) {
> +			PMD_DRV_LOG(NOTICE,
> +				"rss disable failed");
> +			return err;
> +		}
> +
>  		err = hn_rndis_conf_rss(hv, 0);
>  		if (err) {
>  			PMD_DRV_LOG(NOTICE,
> --
> 2.20.1

Hi, Stephen,
I think the patch originally came from Donald Lee (I added him to "To").

IMO Donald's Signed-off-by should be added.

And, can you please change my Signed-off-by to Tested-by?

Thanks,
-- Dexuan