patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Chenbo Xia <chenbo.xia@intel.com>,
	Andrew Rybchenko <arybchenko@solarflare.com>,
	Konstantin Ananyev <konstantin.ananyev@intel.com>,
	Shahaf Shuler <shahafs@mellanox.com>
Cc: dev@dpdk.org, Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>,
	stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v3] net/virtio: fix Rx scatter offload
Date: Tue, 20 Jul 2021 18:19:03 +0200	[thread overview]
Message-ID: <c6dd5f77-c4d9-231b-1be8-f67b202da95d@redhat.com> (raw)
In-Reply-To: <20210720075445.1146963-1-andrew.rybchenko@oktetlabs.ru>



On 7/20/21 9:54 AM, Andrew Rybchenko wrote:
> From: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>
> 
> Report Rx scatter offload capability depending on VIRTIO_NET_F_MRG_RXBUF.
> 
> If Rx scatter is not requested, ensure that provided Rx buffers on
> each Rx queue are big enough to fit Rx packets up to configured MTU.
> 
> Fixes: ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ivan Ilchenko <ivan.ilchenko@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> v3:
>  - fix segfault on MTU set if an Rx queue is not setup
> 
> v2:
>  - do not overwrite Rx offloads when Rx scatter is added
> 
>  drivers/net/virtio/virtio.h        |  2 +
>  drivers/net/virtio/virtio_ethdev.c | 65 ++++++++++++++++++++++++++++++
>  drivers/net/virtio/virtio_ethdev.h |  5 +++
>  drivers/net/virtio/virtio_rxtx.c   | 10 +++++
>  4 files changed, 82 insertions(+)
> 

Thanks for the fix.
I see my R-by is already there, but I confirm this is good to me.

Maxime


  reply	other threads:[~2021-07-20 16:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06 14:14 [dpdk-stable] [PATCH] " Andrew Rybchenko
2021-07-13  9:27 ` Maxime Coquelin
2021-07-19 19:15 ` [dpdk-stable] [PATCH v2] " Andrew Rybchenko
2021-07-19 19:38   ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2021-07-20  7:54 ` [dpdk-stable] [PATCH v3] " Andrew Rybchenko
2021-07-20 16:19   ` Maxime Coquelin [this message]
2021-07-21  9:29     ` Andrew Rybchenko
2021-07-22  7:37       ` Maxime Coquelin
2021-07-21  6:17   ` Xia, Chenbo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6dd5f77-c4d9-231b-1be8-f67b202da95d@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=arybchenko@solarflare.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=ivan.ilchenko@oktetlabs.ru \
    --cc=konstantin.ananyev@intel.com \
    --cc=shahafs@mellanox.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).