From: Kevin Traynor <ktraynor@redhat.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [18.11 6/7] pmdinfogen: fix freebsd build
Date: Thu, 9 Jan 2020 16:53:53 +0000 [thread overview]
Message-ID: <c7057a88-3a55-72b0-bc66-83a3354de2ea@redhat.com> (raw)
In-Reply-To: <20200109155349.GD11396@hmswarspite.think-freely.org>
On 09/01/2020 15:53, Neil Horman wrote:
> On Thu, Jan 09, 2020 at 01:34:32PM +0000, Kevin Traynor wrote:
>> rte_compat.h is needed as part of the fixed commit
>> but it could not be found with meson on FreeBSD causing
>> a build failure. Add it's include directory.
>>
>> This is not an issue on DPDK master branch since
>> rte_compat.h was moved under lib/eal.
>>
>> Fixes: 3e41c8bc7584 ("eal: add ack interrupt API")
>>
>> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
>> Cc: Neil Horman <nhorman@tuxdriver.com>
>> ---
>> buildtools/pmdinfogen/meson.build | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/buildtools/pmdinfogen/meson.build b/buildtools/pmdinfogen/meson.build
>> index a219a8e96..ab2b20032 100644
>> --- a/buildtools/pmdinfogen/meson.build
>> +++ b/buildtools/pmdinfogen/meson.build
>> @@ -4,4 +4,9 @@
>> pmdinfogen_inc = eal_inc
>> pmdinfogen_inc += include_directories('../../lib/librte_pci')
>> +
>> +if host_machine.system() == 'freebsd'
>> + pmdinfogen_inc += include_directories('../../lib/librte_compat')
>> +endif
>> +
> Actually, is there a corresponding Makefile change that needs to be made here
> too?
>
It is building ok with make, so the header seems to getting pulled in
already along the way with the make build system.
Kevin.
> Neil
>
>> pmdinfogen = executable('pmdinfogen',
>> 'pmdinfogen.c',
>> --
>> 2.21.1
>>
>>
>
next prev parent reply other threads:[~2020-01-09 16:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 13:34 [dpdk-stable] [18.11 0/7] Build fixes for 18.11 branch Kevin Traynor
2020-01-09 13:34 ` [dpdk-stable] [18.11 1/7] eal: drop unused macros for primary process check Kevin Traynor
2020-01-09 13:34 ` [dpdk-stable] [18.11 2/7] eventdev: use same log macro for all unsupported calls Kevin Traynor
2020-01-09 13:34 ` [dpdk-stable] [18.11 3/7] eal: remove legacy PMD log macro Kevin Traynor
2020-01-09 13:34 ` [dpdk-stable] [18.11 4/7] net/mlx: fix build with clang 9 Kevin Traynor
2020-01-09 13:34 ` [dpdk-stable] [18.11 5/7] kni: fix ethtool build for gcc 9 Kevin Traynor
2020-01-09 13:34 ` [dpdk-stable] [18.11 6/7] pmdinfogen: fix freebsd build Kevin Traynor
2020-01-09 15:50 ` Neil Horman
2020-01-09 15:53 ` Neil Horman
2020-01-09 16:53 ` Kevin Traynor [this message]
2020-01-09 13:34 ` [dpdk-stable] [18.11 7/7] net/mlx: allow build only on Linux Kevin Traynor
2020-01-13 16:16 ` [dpdk-stable] [18.11 0/7] Build fixes for 18.11 branch Kevin Traynor
2020-01-14 14:29 ` Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7057a88-3a55-72b0-bc66-83a3354de2ea@redhat.com \
--to=ktraynor@redhat.com \
--cc=nhorman@tuxdriver.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).