* [dpdk-stable] [PATCH] net/cxgbe: accept VLAN flow items without ethertype
@ 2020-12-20 22:44 Rahul Lakkireddy
2021-01-11 14:53 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Rahul Lakkireddy @ 2020-12-20 22:44 UTC (permalink / raw)
To: dev; +Cc: kaara.satwik, stable
From: Karra Satwik <kaara.satwik@chelsio.com>
When apps pass the RTE_FLOW_ITEM_TYPE_VLAN without setting the
ethertype field in RTE_FLOW_ITEM_TYPE_ETH, then assume 0x8100
VLAN by default and don't reject the rule.
Fixes: 55f003d8884c ("net/cxgbe: support flow API for matching QinQ VLAN")
Cc: stable@dpdk.org
Signed-off-by: Karra Satwik <kaara.satwik@chelsio.com>
Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
---
drivers/net/cxgbe/cxgbe_flow.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/cxgbe/cxgbe_flow.c b/drivers/net/cxgbe/cxgbe_flow.c
index f7c4f3696..520a5a5c9 100644
--- a/drivers/net/cxgbe/cxgbe_flow.c
+++ b/drivers/net/cxgbe/cxgbe_flow.c
@@ -245,11 +245,6 @@ ch_rte_parsetype_vlan(const void *dmask, const struct rte_flow_item *item,
/* If user has not given any mask, then use chelsio supported mask. */
mask = umask ? umask : (const struct rte_flow_item_vlan *)dmask;
- if (!fs->mask.ethtype)
- return rte_flow_error_set(e, EINVAL, RTE_FLOW_ERROR_TYPE_ITEM,
- item,
- "Can't parse VLAN item without knowing ethertype");
-
/* If ethertype is already set and is not VLAN (0x8100) or
* QINQ(0x88A8), then don't proceed further. Otherwise,
* reset the outer ethertype, so that it can be replaced by
@@ -275,7 +270,7 @@ ch_rte_parsetype_vlan(const void *dmask, const struct rte_flow_item *item,
fs->mask.ethtype = 0;
fs->val.ethtype = 0;
}
- } else if (fs->val.ethtype == RTE_ETHER_TYPE_VLAN) {
+ } else {
CXGBE_FILL_FS(1, 1, ivlan_vld);
if (spec) {
if (spec->tci || (umask && umask->tci))
--
2.24.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/cxgbe: accept VLAN flow items without ethertype
2020-12-20 22:44 [dpdk-stable] [PATCH] net/cxgbe: accept VLAN flow items without ethertype Rahul Lakkireddy
@ 2021-01-11 14:53 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2021-01-11 14:53 UTC (permalink / raw)
To: Rahul Lakkireddy, dev; +Cc: kaara.satwik, stable
On 12/20/2020 10:44 PM, Rahul Lakkireddy wrote:
> From: Karra Satwik <kaara.satwik@chelsio.com>
>
> When apps pass the RTE_FLOW_ITEM_TYPE_VLAN without setting the
> ethertype field in RTE_FLOW_ITEM_TYPE_ETH, then assume 0x8100
> VLAN by default and don't reject the rule.
>
> Fixes: 55f003d8884c ("net/cxgbe: support flow API for matching QinQ VLAN")
> Cc: stable@dpdk.org
>
> Signed-off-by: Karra Satwik <kaara.satwik@chelsio.com>
> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-11 14:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-20 22:44 [dpdk-stable] [PATCH] net/cxgbe: accept VLAN flow items without ethertype Rahul Lakkireddy
2021-01-11 14:53 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).