From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC3A2A0542 for ; Wed, 26 Oct 2022 11:53:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AAD040E28; Wed, 26 Oct 2022 11:53:02 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 27E0840041; Wed, 26 Oct 2022 11:53:00 +0200 (CEST) Received: from dggemv704-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4My3s53dqVzVjDK; Wed, 26 Oct 2022 17:48:09 +0800 (CST) Received: from kwepemm600004.china.huawei.com (7.193.23.242) by dggemv704-chm.china.huawei.com (10.3.19.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 26 Oct 2022 17:52:56 +0800 Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 26 Oct 2022 17:52:56 +0800 Message-ID: Date: Wed, 26 Oct 2022 17:52:55 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v4 1/2] app/testpmd: fix vlan offload of rxq To: Mingjin Ye , CC: , , Aman Singh , Yuying Zhang References: <20221026171007.654038-1-mingjinx.ye@intel.com> From: "lihuisong (C)" In-Reply-To: <20221026171007.654038-1-mingjinx.ye@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 在 2022/10/27 1:10, Mingjin Ye 写道: > After setting vlan offload in testpmd, the result is not updated > to rxq. Therefore, the queue needs to be reconfigured after > executing the "vlan offload" related commands. > > Fixes: a47aa8b97afe ("app/testpmd: add vlan offload support") > Cc: stable@dpdk.org > > Signed-off-by: Mingjin Ye > --- > app/test-pmd/cmdline.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 17be2de402..ce125f549f 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -4133,6 +4133,7 @@ cmd_vlan_offload_parsed(void *parsed_result, > else > vlan_extend_set(port_id, on); > > + cmd_reconfig_device_queue(port_id, 1, 1); This means that queue offloads need to upadte by re-calling dev_configure and setup all queues, right? If it is, this adds a usage limitation. > return; > } >