From: Luca Boccassi <bluca@debian.org>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>,
dpdk stable <stable@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-stable] [PATCH 1/1] kni: fix build with kernel 5.3
Date: Thu, 24 Oct 2019 09:05:44 +0100 [thread overview]
Message-ID: <c8d2ab7707436d4484ad29b530093899a20d4d8d.camel@debian.org> (raw)
In-Reply-To: <20191024073130.11217-2-christian.ehrhardt@canonical.com>
On Thu, 2019-10-24 at 09:31 +0200, Christian Ehrhardt wrote:
> The include of kni_fifo should be local as kni provides it.
> With newer kernels build systems this will run into an issue on
> external module compilation.
>
> /var/lib/dkms/dpdk-rte-kni/17.11.6/build/kni_net.c:40:10:
> fatal error: kni_fifo.h: No such file or directory
> #include <kni_fifo.h>
> ^~~~~~~~~~~~
>
> Like the includes to kni_dev.h this should be local as well.
>
> Signed-off-by: Christian Ehrhardt <
> christian.ehrhardt@canonical.com
> >
> ---
> lib/librte_eal/linuxapp/kni/kni_net.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linuxapp/kni/kni_net.c
> b/lib/librte_eal/linuxapp/kni/kni_net.c
> index db9f48989..1802f9d0b 100644
> --- a/lib/librte_eal/linuxapp/kni/kni_net.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c
> @@ -37,7 +37,7 @@
> #include <linux/delay.h>
>
> #include <exec-env/rte_kni_common.h>
> -#include <kni_fifo.h>
> +#include "kni_fifo.h"
>
> #include "compat.h"
> #include "kni_dev.h"
>
Acked-by: Luca Boccassi <bluca@debian.org>
--
Kind regards,
Luca Boccassi
prev parent reply other threads:[~2019-10-24 8:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 7:31 [dpdk-stable] [PATCH 0/1] 17.11.x kni build issue with kernels 5.3 Christian Ehrhardt
2019-10-24 7:31 ` [dpdk-stable] [PATCH 1/1] kni: fix build with kernel 5.3 Christian Ehrhardt
2019-10-24 8:05 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8d2ab7707436d4484ad29b530093899a20d4d8d.camel@debian.org \
--to=bluca@debian.org \
--cc=christian.ehrhardt@canonical.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).