[dpdk-stable] [PATCH 0/1] 17.11.x kni build issue with kernels 5.3

[dpdk-stable] [PATCH 0/1] 17.11.x kni build issue with kernels 5.3

[Christian Ehrhardt]

I submitted issues against kernel 5.4 a few days ago, now 17.11.x failed
against kernel 5.3. Reported as [1] I'm wondering why this triggers only
for 17.11.x but not 18.11.x (the related content seems the same), but
OTOH the fix seems trivial so I thought I submit it for either
acceptance into 17.11.x or for a discussion why it might be different on
18.11.x that might help to spot a different change that could be
backported from there.

[1]: https://bugs.launchpad.net/ubuntu/+source/dpdk/+bug/1849571

Christian Ehrhardt (1):
  kni: fix build with kernel 5.3

 lib/librte_eal/linuxapp/kni/kni_net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.23.0

[dpdk-stable] [PATCH 1/1] kni: fix build with kernel 5.3

[Christian Ehrhardt]

The include of kni_fifo should be local as kni provides it.
With newer kernels build systems this will run into an issue on
external module compilation.

/var/lib/dkms/dpdk-rte-kni/17.11.6/build/kni_net.c:40:10:
fatal error: kni_fifo.h: No such file or directory
 #include <kni_fifo.h>
          ^~~~~~~~~~~~

Like the includes to kni_dev.h this should be local as well.

Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
 lib/librte_eal/linuxapp/kni/kni_net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_eal/linuxapp/kni/kni_net.c b/lib/librte_eal/linuxapp/kni/kni_net.c
index db9f48989..1802f9d0b 100644
--- a/lib/librte_eal/linuxapp/kni/kni_net.c
+++ b/lib/librte_eal/linuxapp/kni/kni_net.c
@@ -37,7 +37,7 @@
 #include <linux/delay.h>
 
 #include <exec-env/rte_kni_common.h>
-#include <kni_fifo.h>
+#include "kni_fifo.h"
 
 #include "compat.h"
 #include "kni_dev.h"
-- 
2.23.0

Re: [dpdk-stable] [PATCH 1/1] kni: fix build with kernel 5.3

[Luca Boccassi]

On Thu, 2019-10-24 at 09:31 +0200, Christian Ehrhardt wrote:
> The include of kni_fifo should be local as kni provides it.
> With newer kernels build systems this will run into an issue on
> external module compilation.
> 
> /var/lib/dkms/dpdk-rte-kni/17.11.6/build/kni_net.c:40:10:
> fatal error: kni_fifo.h: No such file or directory
>  #include <kni_fifo.h>
>           ^~~~~~~~~~~~
> 
> Like the includes to kni_dev.h this should be local as well.
> 
> Signed-off-by: Christian Ehrhardt <
> christian.ehrhardt@canonical.com
> >
> ---
>  lib/librte_eal/linuxapp/kni/kni_net.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/linuxapp/kni/kni_net.c
> b/lib/librte_eal/linuxapp/kni/kni_net.c
> index db9f48989..1802f9d0b 100644
> --- a/lib/librte_eal/linuxapp/kni/kni_net.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c
> @@ -37,7 +37,7 @@
>  #include <linux/delay.h>
>  
>  #include <exec-env/rte_kni_common.h>
> -#include <kni_fifo.h>
> +#include "kni_fifo.h"
>  
>  #include "compat.h"
>  #include "kni_dev.h"
> 

Acked-by: Luca Boccassi <bluca@debian.org>

-- 
Kind regards,
Luca Boccassi