From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4964A32A1 for ; Thu, 24 Oct 2019 10:05:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B543D1DFEE; Thu, 24 Oct 2019 10:05:48 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 02A921DFEE for ; Thu, 24 Oct 2019 10:05:47 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id p4so24937780wrm.8 for ; Thu, 24 Oct 2019 01:05:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=SM65Fo+lD/fVtKjuTFmrLd+85qdiw4llwtyqxBl0bYo=; b=YAh/yDb4B6YxdlLXCl5oOZNlKTi55Ow2a+gEp4Bflw2O9E0ixZGFsxttrIccOGz/j7 xSqbC1Chk5njRAXakmP1iisE1WImgvK8Gu/PrnS+/BalDa0Yxt1qhDlCi0bEaDIeuWjD wAlmoQzkPUff08QKsstbDDRB4Pje2tAwnEVAbLnGc+BOCykSI/vMvSc0sY4AiVWv28w3 bGynEhbKCj+5wRbWhoRdoBVfVjgQPU7umOe40VS/xqhmXGmIPvI05PuCy043l+2xj/pR tRHSQnWqF9iLVJHnmWtiENx34lgyhu04Nt4Wl4e1hO81vU0wrADvijnRkYSBASEqEuyX iLug== X-Gm-Message-State: APjAAAXa/Bh7oRPPWCZbVRlvVqv53MGaIPpsmrIDAAA8CyiPgvKSG7OM 6UcgDGcCr/abIJNcvE0zbJ5j2pm8 X-Google-Smtp-Source: APXvYqzqqeISbiSeDjTD/UgjnXcTnY96urpb0ezAMoBja4NhIB6GVPjWd3UgJRaRwRaIwjv3kPuh1Q== X-Received: by 2002:a5d:4748:: with SMTP id o8mr2637755wrs.239.1571904346428; Thu, 24 Oct 2019 01:05:46 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id v20sm1456200wml.26.2019.10.24.01.05.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2019 01:05:45 -0700 (PDT) Message-ID: From: Luca Boccassi To: Christian Ehrhardt , dpdk stable Cc: Thomas Monjalon Date: Thu, 24 Oct 2019 09:05:44 +0100 In-Reply-To: <20191024073130.11217-2-christian.ehrhardt@canonical.com> References: <20191024073130.11217-1-christian.ehrhardt@canonical.com> <20191024073130.11217-2-christian.ehrhardt@canonical.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 1/1] kni: fix build with kernel 5.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Thu, 2019-10-24 at 09:31 +0200, Christian Ehrhardt wrote: > The include of kni_fifo should be local as kni provides it. > With newer kernels build systems this will run into an issue on > external module compilation. >=20 > /var/lib/dkms/dpdk-rte-kni/17.11.6/build/kni_net.c:40:10: > fatal error: kni_fifo.h: No such file or directory > #include > ^~~~~~~~~~~~ >=20 > Like the includes to kni_dev.h this should be local as well. >=20 > Signed-off-by: Christian Ehrhardt < > christian.ehrhardt@canonical.com > > > --- > lib/librte_eal/linuxapp/kni/kni_net.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_eal/linuxapp/kni/kni_net.c > b/lib/librte_eal/linuxapp/kni/kni_net.c > index db9f48989..1802f9d0b 100644 > --- a/lib/librte_eal/linuxapp/kni/kni_net.c > +++ b/lib/librte_eal/linuxapp/kni/kni_net.c > @@ -37,7 +37,7 @@ > #include > =20 > #include > -#include > +#include "kni_fifo.h" > =20 > #include "compat.h" > #include "kni_dev.h" >=20 Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi