This patch fixed the TX checksum value problem when enabled TSO in tunnel packets, because outer UDP checksum calculation depend on the TSO configuration. depend on patch: app/testpmd: enable GTP header parse and Tx checksum offload Fixes: 0f62d63593ed ("app/testpmd: support tunneled TSO in checksum engine") Cc: stable@dpdk.org Signed-off-by: Peng Huang <peng.huang@intel.com> --- app/test-pmd/csumonly.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c index e1cb7fb..a1775f4 100644 --- a/app/test-pmd/csumonly.c +++ b/app/test-pmd/csumonly.c @@ -478,6 +478,9 @@ struct simple_gre_hdr { if (info->outer_l4_proto != IPPROTO_UDP) return ol_flags; + if (tso_enabled) + ol_flags |= PKT_TX_TCP_SEG; + /* Skip SW outer UDP checksum generation if HW supports it */ if (tx_offloads & DEV_TX_OFFLOAD_OUTER_UDP_CKSUM) { ol_flags |= PKT_TX_OUTER_UDP_CKSUM; -- 1.8.3.1
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Peng Huang
> Sent: Thursday, October 24, 2019 10:38 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Ye, Xiaolong <xiaolong.ye@intel.com>; Xu, Ting
> <ting.xu@intel.com>; Huang, Peng <peng.huang@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix Tx checksum problem when TSO
> enabled
>
> This patch fixed the TX checksum value problem when enabled TSO in tunnel
> packets, because outer UDP checksum calculation depend on the TSO
> configuration.
>
> depend on patch:
> app/testpmd: enable GTP header parse and Tx checksum offload
>
> Fixes: 0f62d63593ed ("app/testpmd: support tunneled TSO in checksum engine")
> Cc: stable@dpdk.org
>
> Signed-off-by: Peng Huang <peng.huang@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com
On 10/24/2019 12:37 PM, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Peng Huang
>> Sent: Thursday, October 24, 2019 10:38 AM
>> To: Zhang, Qi Z <qi.z.zhang@intel.com>
>> Cc: dev@dpdk.org; Ye, Xiaolong <xiaolong.ye@intel.com>; Xu, Ting
>> <ting.xu@intel.com>; Huang, Peng <peng.huang@intel.com>; stable@dpdk.org
>> Subject: [dpdk-dev] [PATCH] app/testpmd: fix Tx checksum problem when TSO
>> enabled
>>
>> This patch fixed the TX checksum value problem when enabled TSO in tunnel
>> packets, because outer UDP checksum calculation depend on the TSO
>> configuration.
>>
>> depend on patch:
>> app/testpmd: enable GTP header parse and Tx checksum offload
>>
>> Fixes: 0f62d63593ed ("app/testpmd: support tunneled TSO in checksum engine")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Peng Huang <peng.huang@intel.com>
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com
>
Applied to dpdk-next-net/master, thanks.