From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Hernan Vargas <hernan.vargas@intel.com>,
dev@dpdk.org, gakhil@marvell.com, trix@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, stable@dpdk.org
Subject: Re: [PATCH v2 1/5] baseband/acc: fix memory barrier
Date: Fri, 7 Jun 2024 14:45:15 +0200 [thread overview]
Message-ID: <c91d80e6-4c20-4242-94bc-7300b0d4a439@redhat.com> (raw)
In-Reply-To: <20240502204548.236729-2-hernan.vargas@intel.com>
On 5/2/24 22:45, Hernan Vargas wrote:
> Moving memory barrier so that dequeue thread can be in sync with enqueue
> thread.
>
> Fixes: 32e8b7ea35dd ("baseband/acc100: refactor to segregate common code")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
> drivers/baseband/acc/acc_common.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/baseband/acc/acc_common.h b/drivers/baseband/acc/acc_common.h
> index fddeb0737b8b..e249f37e38fe 100644
> --- a/drivers/baseband/acc/acc_common.h
> +++ b/drivers/baseband/acc/acc_common.h
> @@ -1112,6 +1112,9 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n,
> req_elem_addr,
> (void *)q->mmio_reg_enqueue);
>
> + q->aq_enqueued++;
> + q->sw_ring_head += enq_batch_size;
> +
> rte_wmb();
>
> /* Start time measurement for enqueue function offload. */
> @@ -1122,8 +1125,6 @@ acc_dma_enqueue(struct acc_queue *q, uint16_t n,
>
> queue_stats->acc_offload_cycles += rte_rdtsc_precise() - start_time;
>
> - q->aq_enqueued++;
> - q->sw_ring_head += enq_batch_size;
> n -= enq_batch_size;
>
> } while (n);
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
prev parent reply other threads:[~2024-06-07 12:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240502204548.236729-1-hernan.vargas@intel.com>
2024-05-02 20:45 ` Hernan Vargas
2024-06-07 12:45 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c91d80e6-4c20-4242-94bc-7300b0d4a439@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hernan.vargas@intel.com \
--cc=nicolas.chautru@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).