From: "Yigit, Ferruh" <ferruh.yigit@linux.intel.com>
To: Matan Azrad <matan@mellanox.com>,
dev@dpdk.org, Bernard Iremonger <bernard.iremonger@intel.com>
Cc: Gaetan Rivet <gaetan.rivet@6wind.com>,
thomas@monjalon.net, stable@dpdk.org,
David Marchand <david.marchand@redhat.com>,
Jeff Guo <jia.guo@intel.com>, Qi Zhang <qi.z.zhang@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 2/2] app/testpmd: fix invalid port detaching
Date: Thu, 23 Jan 2020 13:19:31 +0000 [thread overview]
Message-ID: <c9e8cae1-0984-fc26-5e9b-6d71619ddb1d@linux.intel.com> (raw)
In-Reply-To: <1573548459-6931-2-git-send-email-matan@mellanox.com>
On 11/12/2019 8:47 AM, Matan Azrad wrote:
> The port was not validated before detaching.
>
> Ignore port detach operation when the port is not valid.
>
> Fixes: f8e5baa2662d ("app/testpmd: check not detaching device twice")
> Cc: thomas@monjalon.net
> Cc: stable@dpdk.org
>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> ---
> app/test-pmd/testpmd.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 4444346..370eefe 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -2545,6 +2545,9 @@ struct extmem_param {
>
> printf("Removing a device...\n");
>
> + if (port_id_is_invalid(port_id, ENABLED_WARN))
> + return;
> +
> dev = rte_eth_devices[port_id].device;
> if (dev == NULL) {
> printf("Device already removed\n");
>
The patch is already in 19.11 [1] but it is breaking the testpmd hotplug support.
Before 'detach_port_device()' called, the port has been stopped and closed [2],
which will make port fail from 'port_id_is_invalid()' check and the device
removal path never fully called.
The implication is, since device not detached, vfio request interrupt keeps
triggered continuously and re-starts the detach path, but because of the half
cleaned device it fails and app gets stuck with a continuous log [3].
I wonder if the actual hotplug has been tested with this patch, the commit log
is not clear about the motivation and implication of the patch, I am not clear
why this check is added but I am sending a patch soon to remove it back.
Regards,
ferruh
[1]
https://git.dpdk.org/dpdk/commit/?id=43d0e304980a1527bcac92dc679057b189e2545a
[2]
rmv_port_callback
stop_port(port_id);
close_port(port_id);
detach_port_device(port_id);
[3]
EAL: can not get port by device 0000:00:05.0!
EAL: can not get port by device 0000:00:05.0!
EAL: can not get port by device 0000:00:05.0!
EAL: can not get port by device 0000:00:05.0!
EAL: can not get port by device 0000:00:05.0!
EAL: can not get port by device 0000:00:05.0!
...
next prev parent reply other threads:[~2020-01-23 13:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 8:47 [dpdk-stable] [PATCH 1/2] bus/pci: fix driver detach clear Matan Azrad
2019-11-12 8:47 ` [dpdk-stable] [PATCH 2/2] app/testpmd: fix invalid port detaching Matan Azrad
2019-11-12 11:20 ` Iremonger, Bernard
2019-11-20 22:52 ` David Marchand
2020-01-23 13:19 ` Yigit, Ferruh [this message]
2020-01-23 14:05 ` [dpdk-stable] [dpdk-dev] " Matan Azrad
2020-01-23 14:48 ` Ferruh Yigit
2020-01-23 15:29 ` Matan Azrad
2020-01-23 18:14 ` Ferruh Yigit
2020-01-23 19:25 ` Matan Azrad
2020-01-24 16:28 ` Ferruh Yigit
2020-01-25 18:56 ` Matan Azrad
2020-02-03 15:58 ` Ferruh Yigit
2020-02-03 17:10 ` Matan Azrad
2020-02-12 13:49 ` Ferruh Yigit
2019-11-19 22:40 ` [dpdk-stable] [PATCH 1/2] bus/pci: fix driver detach clear Thomas Monjalon
2019-11-20 9:02 ` Matan Azrad
2019-11-20 9:47 ` [dpdk-stable] [PATCH v2] " Matan Azrad
2019-11-20 13:03 ` David Marchand
2019-11-20 13:44 ` Matan Azrad
2019-11-20 13:51 ` Thomas Monjalon
2019-11-20 17:22 ` David Marchand
2019-11-20 22:52 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9e8cae1-0984-fc26-5e9b-6d71619ddb1d@linux.intel.com \
--to=ferruh.yigit@linux.intel.com \
--cc=bernard.iremonger@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gaetan.rivet@6wind.com \
--cc=jia.guo@intel.com \
--cc=matan@mellanox.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).