* [PATCH] net/nfp: initialize the flbufsz
@ 2022-06-14 14:47 Peng Zhang
2022-06-15 10:14 ` [PATCH v2] " Peng Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Peng Zhang @ 2022-06-14 14:47 UTC (permalink / raw)
To: dev; +Cc: niklas.soderlund, Peng Zhang, stable, Chaoyong He
When the testpmd start-up, it will check MTU range,
if MTU > flubfsz, it will lead testpmd start fail.
Because the hw->flbufsz doesn't have the initialized
value, so it will lead the bug.
Fixes: 97a30c4d4c7b ("net/nfp: make sure MTU is never larger than mbuf size")
Cc: stable@dpdk.org
Signed-off-by: Peng Zhang <peng.zhang@corigine.com>
Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Signed-off-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
drivers/net/nfp/nfp_ethdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index 9166f65da3..1a9f7581a7 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -502,6 +502,7 @@ nfp_net_init(struct rte_eth_dev *eth_dev)
hw->cap = nn_cfg_readl(hw, NFP_NET_CFG_CAP);
hw->max_mtu = nn_cfg_readl(hw, NFP_NET_CFG_MAX_MTU);
hw->mtu = RTE_ETHER_MTU;
+ hw->flbufsz = RTE_ETHER_MTU;
/* VLAN insertion is incompatible with LSOv2 */
if (hw->cap & NFP_NET_CFG_CTRL_LSO2)
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] net/nfp: initialize the flbufsz
2022-06-14 14:47 [PATCH] net/nfp: initialize the flbufsz Peng Zhang
@ 2022-06-15 10:14 ` Peng Zhang
2022-06-17 15:31 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Peng Zhang @ 2022-06-15 10:14 UTC (permalink / raw)
To: dev; +Cc: niklas.soderlund, Peng Zhang, stable, Chaoyong He
When the testpmd start-up, it will check MTU range,
if MTU > flubfsz, it will lead testpmd start fail.
Because the hw->flbufsz doesn't have the initialized
value, so it will lead the bug.
Fixes: 97a30c4d4c7b ("net/nfp: make sure MTU is never larger than mbuf size")
Cc: stable@dpdk.org
Signed-off-by: Peng Zhang <peng.zhang@corigine.com>
Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
---
drivers/net/nfp/nfp_ethdev.c | 1 +
drivers/net/nfp/nfp_ethdev_vf.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c
index 9166f65da3..1a9f7581a7 100644
--- a/drivers/net/nfp/nfp_ethdev.c
+++ b/drivers/net/nfp/nfp_ethdev.c
@@ -502,6 +502,7 @@ nfp_net_init(struct rte_eth_dev *eth_dev)
hw->cap = nn_cfg_readl(hw, NFP_NET_CFG_CAP);
hw->max_mtu = nn_cfg_readl(hw, NFP_NET_CFG_MAX_MTU);
hw->mtu = RTE_ETHER_MTU;
+ hw->flbufsz = RTE_ETHER_MTU;
/* VLAN insertion is incompatible with LSOv2 */
if (hw->cap & NFP_NET_CFG_CTRL_LSO2)
diff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c
index 0034d68ea6..0781f34764 100644
--- a/drivers/net/nfp/nfp_ethdev_vf.c
+++ b/drivers/net/nfp/nfp_ethdev_vf.c
@@ -369,6 +369,7 @@ nfp_netvf_init(struct rte_eth_dev *eth_dev)
hw->cap = nn_cfg_readl(hw, NFP_NET_CFG_CAP);
hw->max_mtu = nn_cfg_readl(hw, NFP_NET_CFG_MAX_MTU);
hw->mtu = RTE_ETHER_MTU;
+ hw->flbufsz = RTE_ETHER_MTU;
/* VLAN insertion is incompatible with LSOv2 */
if (hw->cap & NFP_NET_CFG_CTRL_LSO2)
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] net/nfp: initialize the flbufsz
2022-06-15 10:14 ` [PATCH v2] " Peng Zhang
@ 2022-06-17 15:31 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2022-06-17 15:31 UTC (permalink / raw)
To: Peng Zhang, Chaoyong He; +Cc: niklas.soderlund, stable, dev
On 6/15/2022 11:14 AM, Peng Zhang wrote:
> When the testpmd start-up, it will check MTU range,
> if MTU > flubfsz, it will lead testpmd start fail.
> Because the hw->flbufsz doesn't have the initialized
> value, so it will lead the bug.
>
> Fixes: 97a30c4d4c7b ("net/nfp: make sure MTU is never larger than mbuf size")
> Cc:stable@dpdk.org
>
> Signed-off-by: Peng Zhang<peng.zhang@corigine.com>
> Signed-off-by: Chaoyong He<chaoyong.he@corigine.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-17 15:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-14 14:47 [PATCH] net/nfp: initialize the flbufsz Peng Zhang
2022-06-15 10:14 ` [PATCH v2] " Peng Zhang
2022-06-17 15:31 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).