From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <stable-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9EADCA04DD for <public@inbox.dpdk.org>; Tue, 10 Nov 2020 19:10:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4098D697C; Tue, 10 Nov 2020 19:10:02 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id DE6205AA6; Tue, 10 Nov 2020 19:09:54 +0100 (CET) IronPort-SDR: zMVLgHOv42r4fJXG2l0qN+wzy05AL/FUg8kgtBbHwGpyYNHAvn1gctovbrGkhhzX6WzmNlLs3Q pUPcQ1IsWinQ== X-IronPort-AV: E=McAfee;i="6000,8403,9801"; a="170181837" X-IronPort-AV: E=Sophos;i="5.77,467,1596524400"; d="scan'208";a="170181837" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 10:09:51 -0800 IronPort-SDR: kpTWhmeRoMCvvbPIsdDTg8ZW9OEHjC82RFzCqkSCpCSnEiuKOAA+KSce5RjsXE/R6MeAPwIDPU YUpUDaTElCtA== X-IronPort-AV: E=Sophos;i="5.77,467,1596524400"; d="scan'208";a="541432311" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.0.179]) ([10.252.0.179]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2020 10:09:49 -0800 To: Thomas Monjalon <thomas@monjalon.net> Cc: dev@dpdk.org, david.marchand@redhat.com, bruce.richardson@intel.com, stable@dpdk.org, Luca Boccassi <bluca@debian.org> References: <20201109210009.919129-1-thomas@monjalon.net> <ae0bedfd-06d9-10d3-54f9-df288dc6807a@intel.com> <3123620.zLnPt8Nx3Z@thomas> From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <ce92dfc5-3c23-2724-ca3a-4bc3229a37b9@intel.com> Date: Tue, 10 Nov 2020 18:09:45 +0000 MIME-Version: 1.0 In-Reply-To: <3123620.zLnPt8Nx3Z@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] [PATCH 1/1] devtools: fix build test config inheritance from env X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> Errors-To: stable-bounces@dpdk.org Sender: "stable" <stable-bounces@dpdk.org> On 11/10/2020 5:55 PM, Thomas Monjalon wrote: > 10/11/2020 18:18, Ferruh Yigit: >> On 11/9/2020 9:00 PM, Thomas Monjalon wrote: >>> PKG_CONFIG_PATH is specific to each target, so it must be empty >>> before configuring each build from the file according to DPDK_TARGET. >>> Inheriting a default PKG_CONFIG_PATH for all targets does not make sense >>> and is prone to confusion. > [...] >> In same run both 64bit and 32bit builds are done, > > Multiple targets can be built yes. > >> At least for my environment, >> for 64bit, PKG_CONFIG_PATH should be '/usr/local/lib64/pkgconfig/' >> for 32bit, PKG_CONFIG_PATH should be '/usr/lib/pkgconfig/' > > Not sure you need to set these values in PKG_CONFIG_PATH. > At least /usr/lib/pkgconfig/ is already set in PKG_CONFIG_LIBDIR. > > Let me rephrase the man page of pkg-config: > PKG_CONFIG_LIBDIR is the primary paths list > PKG_CONFIG_PATH is the secondary paths list > >> What should I set in the config file to support both? > > The standard paths for your 64-bit machine should be built-in > in your pkg-config. > The standard path for 32-bit is already set automatically > in devtools/test-meson-builds.sh. > Only additional specific paths should be set in a config file. > > What is a config file? It is loaded by devtools/load-devel-config: > - /etc/dpdk/devel.config (system-wide) > - or ~/.config/dpdk/devel.config (user config) > - or .develconfig (project directory config) > Personally I set all my configs in ~/.config/dpdk/devel.config. > Note that the same file is used to configure multiple tools. > > For each build, some variables are reset the variable DPDK_TARGET is set, > and the config file is sourced. > The typical values of DPDK_TARGET are: > - i386-pc-linux-gnu > - x86_64-pc-linux-gnu > - x86_64-w64-mingw32 > - aarch64-linux-gnu > - powerpc64le-linux-gcc > > TLDR, I assume you just want to set an additional 64-bit path, > so the config file should look like: > > if [ "$DPDK_TARGET" = x86_64-pc-linux-gnu ] ; then > export PKG_CONFIG_PATH=$PKG_CONFIG_PATH:/usr/local/lib64/pkgconfig > fi > > Thanks for the clarification. Standard paths seems should be covered already in current script, which I was trying to do with "export PKG_CONFIG_PATH=$CUSTOM_PKG_CONFIG_PATH" line in my patch, I may be mixed 'PKG_CONFIG_LIBDIR' vs 'PKG_CONFIG_PATH' usage, let me check it in my environment.