From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>, <dev@dpdk.org>
Cc: <stephen@networkplumber.org>, <thomas@monjalon.net>, <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] malloc: don't skip pad on free
Date: Thu, 19 Jul 2018 19:37:59 +0300 [thread overview]
Message-ID: <cec7b521-58cf-3784-ca6f-5d8cd901cf98@solarflare.com> (raw)
In-Reply-To: <038143a314345e9c5bf76b1287497a5c4c9f63ed.1531992860.git.anatoly.burakov@intel.com>
On 19.07.2018 12:42, Anatoly Burakov wrote:
> Previously, we were skipping erasing pad because we were
> expecting it to be freed when we were merging adjacent
> segments. However, if there were no adjacent segments to
> merge, we would've skipped erasing the pad, leaving non-zero
> memory in our free space.
>
> Fix this by including pad in the erasing unconditionally.
>
> Fixes: e43a9f52b7ff ("malloc: fix pad erasing")
> Cc: stable@dpdk.org
>
> Reported-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Many thanks, the patch fixes the problem I've observed.
Tested-by: Andrew Rybchenko <arybchenko@solarflare.com>
next prev parent reply other threads:[~2018-07-19 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 9:42 Anatoly Burakov
2018-07-19 16:37 ` Andrew Rybchenko [this message]
2018-07-20 9:27 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cec7b521-58cf-3784-ca6f-5d8cd901cf98@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).