Re: [dpdk-stable] patch 'app/testpmd: set fixed flag for exact link speed' has been queued to LTS release 18.11.2

[Andrew Rybchenko <arybchenko@solarflare.com>]

Hi Kevin,

The patch was rolled back recently in master since some Intel drivers
do not support fixed speed and it makes regressions.

Andrew.

On 5/8/19 1:14 PM, Kevin Traynor wrote:
> Hi,
>
> FYI, your patch has been queued to LTS release 18.11.2
>
> Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
> It will be pushed if I get no objections before 05/13/19. So please
> shout if anyone has objections.
>
> Also note that after the patch there's a diff of the upstream commit vs the
> patch applied to the branch. This will indicate if there was any rebasing
> needed to apply to the stable branch. If there were code changes for rebasing
> (ie: not only metadata diffs), please double check that the rebase was
> correctly done.
>
> Queued patches are on a temporary branch at:
> https://github.com/kevintraynor/dpdk-stable-queue
>
> This queued commit can be viewed at:
> https://github.com/kevintraynor/dpdk-stable-queue/commit/fee50d95b9f544f48487546cf597668ebfba6a6d
>
> Thanks.
>
> Kevin Traynor
>
> ---
>  From fee50d95b9f544f48487546cf597668ebfba6a6d Mon Sep 17 00:00:00 2001
> From: Andrew Rybchenko <arybchenko@solarflare.com>
> Date: Fri, 12 Apr 2019 14:12:33 +0100
> Subject: [PATCH] app/testpmd: set fixed flag for exact link speed
>
> [ upstream commit bdca79053b6aea504d02691d9319fa976062457f ]
>
> Setting exact link speed makes sense if auto-negotiation is
> disabled. Fixed flag is required to disable auto-negotiation.
>
> Fixes: 88fbedcd5e5a ("app/testpmd: move speed and duplex parsing in a function")
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
> ---
>   app/test-pmd/cmdline.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index f17ca3282..5d719a186 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -1430,15 +1430,15 @@ parse_and_check_speed_duplex(char *speedstr, char *duplexstr, uint32_t *speed)
>   		}
>   		if (!strcmp(speedstr, "1000")) {
> -			*speed = ETH_LINK_SPEED_1G;
> +			*speed = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_FIXED;
>   		} else if (!strcmp(speedstr, "10000")) {
> -			*speed = ETH_LINK_SPEED_10G;
> +			*speed = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_FIXED;
>   		} else if (!strcmp(speedstr, "25000")) {
> -			*speed = ETH_LINK_SPEED_25G;
> +			*speed = ETH_LINK_SPEED_25G | ETH_LINK_SPEED_FIXED;
>   		} else if (!strcmp(speedstr, "40000")) {
> -			*speed = ETH_LINK_SPEED_40G;
> +			*speed = ETH_LINK_SPEED_40G | ETH_LINK_SPEED_FIXED;
>   		} else if (!strcmp(speedstr, "50000")) {
> -			*speed = ETH_LINK_SPEED_50G;
> +			*speed = ETH_LINK_SPEED_50G | ETH_LINK_SPEED_FIXED;
>   		} else if (!strcmp(speedstr, "100000")) {
> -			*speed = ETH_LINK_SPEED_100G;
> +			*speed = ETH_LINK_SPEED_100G | ETH_LINK_SPEED_FIXED;
>   		} else if (!strcmp(speedstr, "auto")) {
>   			*speed = ETH_LINK_SPEED_AUTONEG;