From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 0A767A0096 for ; Wed, 8 May 2019 12:21:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A8ED42C2B; Wed, 8 May 2019 12:21:02 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id B5ED42C2B for ; Wed, 8 May 2019 12:21:01 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 2B7DAB4005B; Wed, 8 May 2019 10:21:00 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 8 May 2019 11:20:54 +0100 To: Kevin Traynor CC: Bernard Iremonger , dpdk stable References: <20190508101534.8984-1-ktraynor@redhat.com> <20190508101534.8984-11-ktraynor@redhat.com> From: Andrew Rybchenko Message-ID: Date: Wed, 8 May 2019 13:20:43 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190508101534.8984-11-ktraynor@redhat.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24598.003 X-TM-AS-Result: No-15.706500-8.000000-10 X-TMASE-MatchedRID: vbSD0OnL8/JHJXeB0puIo4GU23hVIa8hjLOy13Cgb4+qvcIF1TcLYOEt b6e4qSOWtVSr9oNVqLA5epvyAddOPRFyIYZe6FcSvHKClHGjjr1kBDPLxNH5BlpbYq2f4jz+mF+ coLHg6x8rP9WJ7q7tvnEkuxXv1mCjyGOiXr1rOL63UCG/IQp2PvioIsi7Sa0gw01zN1c0miL77e BDbq1tuEAvmWirB8hcEcINvsCuqCe9F7NKcWMllX84FZpy/6JVWuFm7TqL4eHJy653qMoIjxTIB 27oUoj5y5qIxv0h9i/hhLoXIby/KPJRA2JqAZKz2x/FmlC/aoyb/LTS0T1K1r/DPenuktW9LFlX Zd2HA7Dt80qCYQSwTc7r2cMl6mZFo27w8ee4WC+dOp1TjDrlaRwMMtF4a3g9+ZQPGkWiBBejxYy RBa/qJQPTK4qtAgwIoWiH8jJBtC9WdFebWIc3VmxlRJiH4397sHoDD1E9SYXy/Yivixt+oEmUn1 LCU7y/7Qpk9to/YhXOpqQ5OqaUthXcxy6dVim3c06sBany6fkfwliz6veE2F6T1O/dhgaR X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--15.706500-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24598.003 X-MDID: 1557310861-5Q4CvGqLjOjL Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-stable] patch 'app/testpmd: set fixed flag for exact link speed' has been queued to LTS release 18.11.2 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Kevin, The patch was rolled back recently in master since some Intel drivers do not support fixed speed and it makes regressions. Andrew. On 5/8/19 1:14 PM, Kevin Traynor wrote: > Hi, > > FYI, your patch has been queued to LTS release 18.11.2 > > Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. > It will be pushed if I get no objections before 05/13/19. So please > shout if anyone has objections. > > Also note that after the patch there's a diff of the upstream commit vs the > patch applied to the branch. This will indicate if there was any rebasing > needed to apply to the stable branch. If there were code changes for rebasing > (ie: not only metadata diffs), please double check that the rebase was > correctly done. > > Queued patches are on a temporary branch at: > https://github.com/kevintraynor/dpdk-stable-queue > > This queued commit can be viewed at: > https://github.com/kevintraynor/dpdk-stable-queue/commit/fee50d95b9f544f48487546cf597668ebfba6a6d > > Thanks. > > Kevin Traynor > > --- > From fee50d95b9f544f48487546cf597668ebfba6a6d Mon Sep 17 00:00:00 2001 > From: Andrew Rybchenko > Date: Fri, 12 Apr 2019 14:12:33 +0100 > Subject: [PATCH] app/testpmd: set fixed flag for exact link speed > > [ upstream commit bdca79053b6aea504d02691d9319fa976062457f ] > > Setting exact link speed makes sense if auto-negotiation is > disabled. Fixed flag is required to disable auto-negotiation. > > Fixes: 88fbedcd5e5a ("app/testpmd: move speed and duplex parsing in a function") > > Signed-off-by: Andrew Rybchenko > Acked-by: Bernard Iremonger > --- > app/test-pmd/cmdline.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index f17ca3282..5d719a186 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -1430,15 +1430,15 @@ parse_and_check_speed_duplex(char *speedstr, char *duplexstr, uint32_t *speed) > } > if (!strcmp(speedstr, "1000")) { > - *speed = ETH_LINK_SPEED_1G; > + *speed = ETH_LINK_SPEED_1G | ETH_LINK_SPEED_FIXED; > } else if (!strcmp(speedstr, "10000")) { > - *speed = ETH_LINK_SPEED_10G; > + *speed = ETH_LINK_SPEED_10G | ETH_LINK_SPEED_FIXED; > } else if (!strcmp(speedstr, "25000")) { > - *speed = ETH_LINK_SPEED_25G; > + *speed = ETH_LINK_SPEED_25G | ETH_LINK_SPEED_FIXED; > } else if (!strcmp(speedstr, "40000")) { > - *speed = ETH_LINK_SPEED_40G; > + *speed = ETH_LINK_SPEED_40G | ETH_LINK_SPEED_FIXED; > } else if (!strcmp(speedstr, "50000")) { > - *speed = ETH_LINK_SPEED_50G; > + *speed = ETH_LINK_SPEED_50G | ETH_LINK_SPEED_FIXED; > } else if (!strcmp(speedstr, "100000")) { > - *speed = ETH_LINK_SPEED_100G; > + *speed = ETH_LINK_SPEED_100G | ETH_LINK_SPEED_FIXED; > } else if (!strcmp(speedstr, "auto")) { > *speed = ETH_LINK_SPEED_AUTONEG;