From: Jeff Guo <jia.guo@intel.com>
To: Wei Zhao <wei.zhao1@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org, beilei.xing@intel.com
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: fix the security risk of wild pointer operation
Date: Fri, 15 May 2020 14:32:04 +0800 [thread overview]
Message-ID: <cff9de2d-d187-a936-c9db-1eaefec1a50f@intel.com> (raw)
In-Reply-To: <20200512151915.105152-1-wei.zhao1@intel.com>
hi, zhaowei
On 5/12/2020 11:19 PM, Wei Zhao wrote:
> In i40e PMD code of function i40e_res_pool_free(), if valid_entry is
> freed by "rte_free(valid_entry);" in the following code:
>
> if (prev != NULL) {
> ........................
>
> if (insert == 1) {
> LIST_REMOVE(valid_entry, next);
> rte_free(valid_entry);
> } else {
> rte_free(valid_entry);
> insert = 1;
> }
> }
>
> then the following code for pool update may still use the wild pointer
> "valid_entry":
>
> " pool->num_free += valid_entry->len;
> pool->num_alloc -= valid_entry>len;
> "
> it seems to be a security bug, we should avoid this risk.
>
> Cc: stable@dpdk.org
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 749d85f54..7f8ea5309 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -4973,6 +4973,9 @@ i40e_res_pool_free(struct i40e_res_pool_info *pool,
> }
>
> insert = 0;
> + pool->num_free += valid_entry->len;
> + pool->num_alloc -= valid_entry->len;
> +
Shouldn't the pool count update after the pool->free_list updated by
"LIST_INSERT_HEAD(&pool->free_list, valid_entry, next)"?
If so, you could use a variable to restore valid_entry->len at the
begin and use it update pool count and other place.
> /* Try to merge with next one*/
> if (next != NULL) {
> /* Merge with next one */
> @@ -5010,9 +5013,6 @@ i40e_res_pool_free(struct i40e_res_pool_info *pool,
> LIST_INSERT_HEAD(&pool->free_list, valid_entry, next);
> }
>
> - pool->num_free += valid_entry->len;
> - pool->num_alloc -= valid_entry->len;
> -
> return 0;
> }
>
next prev parent reply other threads:[~2020-05-15 6:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 15:19 [dpdk-stable] " Wei Zhao
2020-05-15 2:24 ` Zhao1, Wei
2020-05-15 6:32 ` Jeff Guo [this message]
2020-05-15 7:28 ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2020-05-18 5:24 ` Zhao1, Wei
2020-05-18 5:32 ` Ye Xiaolong
2020-05-18 5:10 ` [dpdk-stable] [PATCH v2] net/i40e: fix the core dump " Wei Zhao
2020-05-18 6:43 ` [dpdk-stable] [PATCH v3] " Wei Zhao
2020-05-18 7:43 ` [dpdk-stable] [PATCH v4] " Wei Zhao
2020-05-18 8:00 ` [dpdk-stable] [PATCH v5] " Wei Zhao
2020-05-18 8:45 ` Jeff Guo
2020-05-19 1:28 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cff9de2d-d187-a936-c9db-1eaefec1a50f@intel.com \
--to=jia.guo@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).