From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7914045E1E for ; Tue, 3 Dec 2024 18:55:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4FE394025D; Tue, 3 Dec 2024 18:55:03 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 5E2824025D for ; Tue, 3 Dec 2024 18:55:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733248500; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Q1ZpQ7/1oYJ3kuenNnVYn0Wxw6WmiJ216sRVPOGWHNk=; b=KxhN6VvtzVWt1n0Ve50wabM5vMKHR6ZCL1qqvlryVC4EQxwyV2CX4yt8d5Ccv5EXa5VExd VU8Hxsua+M42/5aDlYewCoQRoITw4s7pFOydDRi1pRZBqMAiHAb/qAXzFXt6792zS8DY47 UBRc6FxmDGBh3pGG/FzFa2wYDP2qwiM= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-541-nfkZFE31N8iUxcCc40DEUg-1; Tue, 03 Dec 2024 12:54:57 -0500 X-MC-Unique: nfkZFE31N8iUxcCc40DEUg-1 X-Mimecast-MFC-AGG-ID: nfkZFE31N8iUxcCc40DEUg Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-aa515925dd7so331595966b.3 for ; Tue, 03 Dec 2024 09:54:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733248496; x=1733853296; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q1ZpQ7/1oYJ3kuenNnVYn0Wxw6WmiJ216sRVPOGWHNk=; b=w9tkQk8+ZSyzq1ZMwiodvuErosqzZhuYgxELIKPq+Qh2m/ZEEeQhPoZFVoU6j5Y9s/ 3G21N7kzvQ0fwl5vSz2p/InBnBsF7N3WmJTsFISrYwKHwh2fhnaqe2IjkU1qgZ9Wn1qy whXrkQ1GTXAE1+jhR/kdwN4pZfC5HoSVOauYVylUpIoOprrA8GZ9+JI0Lbz4jJbvcE3c BpczdTC9NJjk/PnDR8MJS9jfyFZB4kEIkk6vTjEDYCQKKxcrye7fVG5RpIpND8AAhPmS Fc/nQ/kcyN4aUu3ogzd9Bt38n0FZ/SlrJPIt/EIg3u+KLObQ6WTAP1dYQaAwMlZhnB9+ RpTw== X-Forwarded-Encrypted: i=1; AJvYcCVoNK5LMTd2fhG9Cy7MJt1m9ZHUTmD+mkRocmRd+mfJrUk1oRletfd3A1WJB1g0GstRNvxrzjw=@dpdk.org X-Gm-Message-State: AOJu0YwFTYZ+JmPr0N4upLOHjXA1Pgwjp+04YcuF0sJtbv20qMhajv0g BlTuP5/zqCZtbU0FjD9B+WtR9w9dB5RFzXhLCkx0DtCCxoDlE+E6QGDrOaxtFR4a6mPYRsq86B2 eEVQVyuISvwfK7GwmodmVcKCW5nc4uTIxjAItKIkEOcHf X-Gm-Gg: ASbGncuIRWyhpET7gMhOx4pSFvLM0aODZxrmLKXq6qnPKAVnrTBqam9tfPBC/1JKtM2 uS8OQZVc7N5M+iCiATlaPg6o+AdTfV/MkjsuvFQrdPekTktAJzFFP8aC8IJhSz9tB0pzYepWDbQ u+p2VCiw8nxGUi22PEppOIQOxHZLT2AB9yYDqymF+DRKr4HrdUS3R6losvN/nGbzm4uw36cOzkD 9Qqx+0ftYesefsq7XIoiq6wpCsXh7Q7fBdmopY3N+38R13zdA== X-Received: by 2002:a17:906:18a9:b0:aa6:fc:8277 with SMTP id a640c23a62f3a-aa600fcbc59mr111134966b.45.1733248496169; Tue, 03 Dec 2024 09:54:56 -0800 (PST) X-Google-Smtp-Source: AGHT+IHQ2rfYekQFwzYZKJgKLCdpa9exnbm82QkqZn338sZPk5D8WSWIVrvfypu26BIvzB1vCpnM8A== X-Received: by 2002:a17:906:18a9:b0:aa6:fc:8277 with SMTP id a640c23a62f3a-aa600fcbc59mr111133766b.45.1733248495807; Tue, 03 Dec 2024 09:54:55 -0800 (PST) Received: from [192.168.0.36] ([78.17.46.22]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa5996c11e6sm640472866b.4.2024.12.03.09.54.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Dec 2024 09:54:55 -0800 (PST) Message-ID: Date: Tue, 3 Dec 2024 17:54:54 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 21.11] common/mlx5: fix error CQE handling for 128 bytes CQE From: Kevin Traynor To: Alexander Kozyrev , stable@dpdk.org Cc: Viacheslav Ovsiienko References: <20241127174839.1770671-1-akozyrev@nvidia.com> <4c30bab5-9f6f-4b68-a569-ab3e34cd27ad@redhat.com> Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: <4c30bab5-9f6f-4b68-a569-ab3e34cd27ad@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: qzjThcYiPTkChnoz01WrtApRQk0RHu_WPD88cMbGAa8_1733248496 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 03/12/2024 18:43, Kevin Traynor wrote: > On 27/11/2024 18:48, Alexander Kozyrev wrote: >> [ upstream commit 3cddeba0ca38b00c7dc646277484d08a4cb2d862 ] >> >> The completion queue element size can be independently configured >> to report either 64 or 128 bytes CQEs by programming cqe_sz parameter >> at CQ creation. This parameter depends on the cache line size and >> affects both regular CQEs and error CQEs. But the error handling >> assumes that an error CQE is 64 bytes and doesn't take the padding >> into consideration on platforms with 128-byte cache lines. >> Fix the error CQE size in all error handling routines in mlx5. >> > Hi Alexander, > > This is causing a build error [1] on windows in the crypto code [2]. > > ref > https://dpdkdashboard.iol.unh.edu/results/dashboard/testruns/logs/1475543/ > > I didn't spend time to analyse. If you have a fix I can apply, or else > we can drop the patch. > > thanks, > Kevin. > > [1] > ../drivers/crypto/mlx5/mlx5_crypto.c > ../drivers/crypto/mlx5/mlx5_crypto.c:480:52: error: incomplete > definition of type 'struct mlx5_err_cqe' > DRV_LOG(ERR, "CQE ERR:%x.\n", rte_be_to_cpu_32(cqe->syndrome)); > ~~~^ > [2] > mlx5_crypto_cqe_err_handle(struct mlx5_crypto_qp *qp, struct > rte_crypto_op *op) > { > const uint32_t idx = qp->ci & (qp->entries_n - 1); > volatile struct mlx5_err_cqe *cqe = (volatile struct mlx5_err_cqe *) > &qp->cq_obj.cqes[idx]; > > op->status = RTE_CRYPTO_OP_STATUS_ERROR; > qp->stats.dequeue_err_count++; > DRV_LOG(ERR, "CQE ERR:%x.\n", rte_be_to_cpu_32(cqe->syndrome)); > } > btw, the code that was run is ahead of the 21.11 branch. It is at: https://dpdk.org/git/dpdk-stable on branch 21.11-staging