patches for DPDK stable branches
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>,
	"Yang, SteveX" <stevex.yang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, SteveX" <stevex.yang@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3] net/i40e: fix set rss hash function invalid
Date: Mon, 21 Jun 2021 08:30:54 +0000
Message-ID: <d254d26e6f484e3c9d4ec9070828c776@intel.com> (raw)
In-Reply-To: <MN2PR11MB3807EA86FB428E6C5ACAA17BF70A9@MN2PR11MB3807.namprd11.prod.outlook.com>



> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xing, Beilei
> Sent: Monday, June 21, 2021 4:19 PM
> To: Yang, SteveX <stevex.yang@intel.com>; dev@dpdk.org
> Cc: Yang, SteveX <stevex.yang@intel.com>; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix set rss hash function invalid
> 
> 
> 
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Steve Yang
> > Sent: Monday, June 21, 2021 4:04 PM
> > To: dev@dpdk.org
> > Cc: Xing, Beilei <beilei.xing@intel.com>; Yang, SteveX
> > <stevex.yang@intel.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix set rss hash function
> > invalid
> >
> > i40e can support following rss hash function types: default/toeplitz,
> > symmetric toeplitz, and simple_xor. However, when filter engine parses
> > pattern action, it only supports symmetric toeplitz & default.
> >
> > Add simple_xor and toeplitz hash functions support when parsing
> > pattern action.
> >
> > Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Steve Yang <stevex.yang@intel.com>
> > ---
> > v3:
> >  - add Cc stable line.
> > v2:
> >  - add the fix line.
> >  - support simple_xor and toeplitz hash functions explicitly.
> >
> >  drivers/net/i40e/i40e_hash.c | 20 ++++++++++++++------
> >  1 file changed, 14 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/net/i40e/i40e_hash.c
> > b/drivers/net/i40e/i40e_hash.c index b1cb24f437..0cef21c88f 100644
> > --- a/drivers/net/i40e/i40e_hash.c
> > +++ b/drivers/net/i40e/i40e_hash.c
> > @@ -1105,13 +1105,21 @@ i40e_hash_parse_pattern_act(const struct
> > rte_eth_dev *dev,
> >  					  NULL,
> >  					  "RSS Queues not supported when pattern
> specified");
> >
> > -	if (rss_act->func ==
> > RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ)
> > +	switch (rss_act->func) {
> > +	case RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ:
> >  		rss_conf->symmetric_enable = true;
> > -	else if (rss_act->func != RTE_ETH_HASH_FUNCTION_DEFAULT)
> > -		return rte_flow_error_set(error, -EINVAL,
> > -
> > RTE_FLOW_ERROR_TYPE_ACTION_CONF,
> > -					  NULL,
> > -					  "Only symmetric TOEPLITZ
> > supported when pattern specified");
> > +		break;
> > +	case RTE_ETH_HASH_FUNCTION_DEFAULT:
> > +	case RTE_ETH_HASH_FUNCTION_TOEPLITZ:
> > +	case RTE_ETH_HASH_FUNCTION_SIMPLE_XOR:
> > +		break;
> > +	default:
> > +		return rte_flow_error_set(error, EINVAL,
> > +				RTE_FLOW_ERROR_TYPE_ACTION_CONF,
> > +				NULL,
> > +				"RSS hash function not supported "
> > +				"when pattern specified");
> > +	}
> >
> >  	if (!i40e_hash_validate_rss_types(rss_act->types))
> >  		return rte_flow_error_set(error, EINVAL,
> > --
> > 2.27.0
> 
> Acked-by: Beilei Xing <beilei.xing@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi


      reply	other threads:[~2021-06-21  8:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210611065457.988344-1-stevex.yang@intel.com>
2021-06-21  8:03 ` [dpdk-stable] " Steve Yang
2021-06-21  8:19   ` [dpdk-stable] [dpdk-dev] " Xing, Beilei
2021-06-21  8:30     ` Zhang, Qi Z [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d254d26e6f484e3c9d4ec9070828c776@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=stevex.yang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git