From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Yasufumi Ogawa <yasufum.o@gmail.com>, david.marchand@redhat.com
Cc: dev@dpdk.org, stable@dpdk.org,
Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
Subject: Re: [dpdk-stable] [PATCH v3 1/1] fbarray: get fbarrays from containerized secondary
Date: Mon, 22 Jul 2019 10:25:39 +0100 [thread overview]
Message-ID: <d3725e4c-0afe-2d7a-7074-84d555c8d04f@intel.com> (raw)
In-Reply-To: <99d2853d-f6f9-59f2-f853-0f9222e8cb5d@gmail.com>
On 12-Jul-19 3:22 AM, Yasufumi Ogawa wrote:
> On 2019/07/11 22:14, Burakov, Anatoly wrote:
>> On 11-Jul-19 12:57 PM, Yasufumi Ogawa wrote:
>>> On 2019/07/11 19:53, Burakov, Anatoly wrote:
>>>> On 11-Jul-19 11:31 AM, yasufum.o@gmail.com wrote:
>>>>> From: Yasufumi Ogawa <ogawa.yasufumi@lab.ntt.co.jp>
>>>>>
>>>> <...>
>>>>
>>>>> + if (getpid() == 1) {
>>>>> + FILE *hn_fp;
>>>>> + hn_fp = fopen("/etc/hostname", "r");
>>>>> + if (hn_fp == NULL) {
>>>>> + RTE_LOG(ERR, EAL,
>>>>> + "Cannot open '/etc/hostname' for secondary\n");
>>>>> + return -1;
>>>>> + }
>>>>> +
>>>>> + /* with docker, /etc/hostname just has one entry of
>>>>> hostname */
>>>>> + if (fscanf(hn_fp, "%s", proc_id) == EOF) {
>>>>
>>>> Apologies for not pointing this out earlier, but do i understand
>>>> correctly that there's no bounds checking here, and fscanf() will
>>>> write however many bytes it wants?
>>> I understand "%s" is not appropriate. hostname is 12 bytes char and I
>>> thought proc_id[16] is enough, but it is unsafe. In addition,
>>> hostname can be defined by user with docker's option, so it should be
>>> enough for user defined name.
>>>
>>> How do you think expecting max 32 chars of hostname and set boundary
>>> "%32s" as following?
>>>
>>> proc_id[33]; /* define proc id from hostname less than 33
>>> bytes. */
>>> ...
>>> if (fscanf(hn_fp, "%32s", proc_id) == EOF) {
>>>
>>
>> As long as it takes NULL-termination into account as well, it should
>> be OK. I can't recall off the top of my head if %32s includes NULL
>> terminator (probably not?).
> Do you agree if initialize with NULL chars to ensure proc_id is
> NULL-terminated? As tested on my environment, "%Ns" sets next of Nth
> char as NULL, but it seems more reliable.
> proc_id[33] = { 0 };
>
> Yasufumi
>
Yes, that should be OK.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2019-07-22 9:25 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 1:59 [dpdk-stable] [PATCH] " ogawa.yasufumi
2019-04-16 3:43 ` [dpdk-stable] [PATCH v2 0/1] Get " ogawa.yasufumi
2019-04-16 3:43 ` [dpdk-stable] [PATCH v2 1/1] fbarray: get " ogawa.yasufumi
2019-07-04 20:17 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2019-07-05 8:53 ` [dpdk-stable] " Burakov, Anatoly
2019-07-09 10:22 ` [dpdk-stable] [dpdk-dev] " Yasufumi Ogawa
2019-07-09 10:24 ` Burakov, Anatoly
2019-07-09 10:26 ` Burakov, Anatoly
2019-07-11 9:37 ` Yasufumi Ogawa
2019-07-11 9:43 ` Burakov, Anatoly
2019-07-11 10:31 ` [dpdk-stable] [PATCH v3 0/1] " yasufum.o
2019-07-11 10:31 ` [dpdk-stable] [PATCH v3 1/1] " yasufum.o
2019-07-11 10:53 ` Burakov, Anatoly
2019-07-11 11:57 ` Yasufumi Ogawa
2019-07-11 13:14 ` Burakov, Anatoly
2019-07-12 2:22 ` Yasufumi Ogawa
2019-07-22 1:06 ` Ogawa Yasufumi
2019-07-22 9:33 ` Burakov, Anatoly
2019-07-22 9:25 ` Burakov, Anatoly [this message]
2019-07-24 8:20 ` [dpdk-stable] [PATCH v4 0/1] " yasufum.o
2019-07-24 8:20 ` [dpdk-stable] [PATCH v4 1/1] " yasufum.o
2019-07-24 9:59 ` Burakov, Anatoly
2019-07-30 8:16 ` Thomas Monjalon
2019-07-30 9:18 ` Burakov, Anatoly
2019-07-31 5:48 ` Yasufumi Ogawa
2019-10-11 9:36 ` David Marchand
2019-10-25 15:36 ` David Marchand
2019-10-25 19:54 ` Yasufumi Ogawa
2019-10-26 16:15 ` David Marchand
2019-10-26 18:11 ` Yasufumi Ogawa
2019-10-28 8:07 ` [dpdk-stable] [PATCH v5 0/1] fbarray: fix duplicated fbarray file in secondary yasufum.o
2019-10-28 8:07 ` [dpdk-stable] [PATCH v5 1/1] " yasufum.o
2019-10-29 12:03 ` [dpdk-stable] [dpdk-dev] " Ananyev, Konstantin
2019-10-30 13:42 ` Yasufumi Ogawa
2019-10-30 19:00 ` Ananyev, Konstantin
2019-10-31 10:03 ` Yasufumi Ogawa
2019-10-31 10:32 ` Ananyev, Konstantin
2019-11-01 9:04 ` [dpdk-stable] [PATCH v6 0/1] " yasufum.o
2019-11-01 9:04 ` [dpdk-stable] [PATCH v6 1/1] " yasufum.o
2019-11-01 12:01 ` Ananyev, Konstantin
2019-11-04 10:20 ` Burakov, Anatoly
2019-11-05 10:13 ` David Marchand
2019-11-05 11:31 ` Burakov, Anatoly
2019-11-05 11:41 ` Ananyev, Konstantin
2019-11-06 10:37 ` Burakov, Anatoly
2019-11-08 3:19 ` Yasufumi Ogawa
2019-11-13 21:43 ` [dpdk-stable] [PATCH v7 0/1] " yasufum.o
2019-11-13 21:43 ` [dpdk-stable] [PATCH v7 1/1] " yasufum.o
2019-11-14 10:01 ` Burakov, Anatoly
2019-11-14 11:42 ` Yasufumi Ogawa
2019-11-14 12:27 ` David Marchand
2019-11-26 19:40 ` Yasufumi Ogawa
2019-11-27 10:26 ` Burakov, Anatoly
2019-11-14 12:55 ` David Marchand
2019-11-14 17:32 ` Ananyev, Konstantin
2023-06-13 16:51 ` [dpdk-dev] [PATCH] fbarray: get fbarrays from containerized secondary Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3725e4c-0afe-2d7a-7074-84d555c8d04f@intel.com \
--to=anatoly.burakov@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ogawa.yasufumi@lab.ntt.co.jp \
--cc=stable@dpdk.org \
--cc=yasufum.o@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).