From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A391EA09E4
	for <public@inbox.dpdk.org>; Mon, 26 Apr 2021 14:02:23 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 94770411BB;
	Mon, 26 Apr 2021 14:02:23 +0200 (CEST)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by mails.dpdk.org (Postfix) with ESMTP id 197AB40140;
 Mon, 26 Apr 2021 14:02:19 +0200 (CEST)
IronPort-SDR: vu4tPAvN2XbsH9TD6Qk2GPA67yOoUyA4kAIv/OlBpVZvTP2adJdtnfeXI2ab+m2ypE0PjoJIot
 /yyPLk4zkpIg==
X-IronPort-AV: E=McAfee;i="6200,9189,9965"; a="175804626"
X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="175804626"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 26 Apr 2021 05:02:17 -0700
IronPort-SDR: 8G3hfEfPi3gLt8iQ/qnUHr6dxmy3CYZqMp4SoeKhpCVOFwqKgVhtVdEUIHf0BpdEZldFuIJg45
 pj2FuZrbC/og==
X-IronPort-AV: E=Sophos;i="5.82,252,1613462400"; d="scan'208";a="429371585"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.240.23])
 ([10.213.240.23])
 by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 26 Apr 2021 05:02:07 -0700
To: Jiawen Wu <jiawenwu@trustnetic.com>,
 'Igor Russkikh' <igor.russkikh@aquantia.com>,
 'Pavel Belous' <pavel.belous@aquantia.com>,
 'Somalapuram Amaranath' <asomalap@amd.com>,
 'Ajit Khaparde' <ajit.khaparde@broadcom.com>,
 'Somnath Kotur' <somnath.kotur@broadcom.com>,
 'Hemant Agrawal' <hemant.agrawal@nxp.com>,
 'Sachin Saxena' <sachin.saxena@oss.nxp.com>, 'Jeff Guo' <jia.guo@intel.com>,
 'Haiyue Wang' <haiyue.wang@intel.com>, 'John Daley' <johndale@cisco.com>,
 'Hyong Youb Kim' <hyonkim@cisco.com>, "'Min Hu (Connor)'"
 <humin29@huawei.com>, 'Yisen Zhuang' <yisen.zhuang@huawei.com>,
 'Lijun Ou' <oulijun@huawei.com>, 'Beilei Xing' <beilei.xing@intel.com>,
 'Qiming Yang' <qiming.yang@intel.com>, 'Qi Zhang' <qi.z.zhang@intel.com>,
 'Andrew Boyer' <aboyer@pensando.io>, 'Jerin Jacob' <jerinj@marvell.com>,
 'Nithin Dabilpuram' <ndabilpuram@marvell.com>,
 'Kiran Kumar K' <kirankumark@marvell.com>, 'Rasesh Mody'
 <rmody@marvell.com>, 'Devendra Singh Rawat' <dsinghrawat@marvell.com>,
 'Andrew Rybchenko' <andrew.rybchenko@oktetlabs.ru>,
 'Jian Wang' <jianwang@trustnetic.com>,
 'Thomas Monjalon' <thomas@monjalon.net>,
 'Selwin Sebastian' <selwin.sebastian@amd.com>,
 'Chunsong Feng' <fengchunsong@huawei.com>,
 'Huisong Li' <lihuisong@huawei.com>, 'Jingjing Wu' <jingjing.wu@intel.com>,
 'Wenzhuo Lu' <wenzhuo.lu@intel.com>, 'Xiaoyun Li' <xiaoyun.li@intel.com>,
 'Alvin Zhang' <alvinx.zhang@intel.com>,
 'Shannon Nelson' <snelson@pensando.io>,
 'Alfredo Cardigliano' <cardigliano@ntop.org>,
 'Vamsi Attunuru' <vattunuru@marvell.com>, 'Yash Sharma'
 <ysharma@marvell.com>, 'Ivan Malov' <ivan.malov@oktetlabs.ru>,
 'Andrew Lee' <alee@solarflare.com>
Cc: dev@dpdk.org, stable@dpdk.org
References: <20210421162058.1352960-1-ferruh.yigit@intel.com>
 <006701d737e7$097eb1b0$1c7c1510$@trustnetic.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-User: ferruhy
Message-ID: <d50619e8-3b0f-bb42-5af9-4e701a8be7e1@intel.com>
Date: Mon, 26 Apr 2021 13:02:03 +0100
MIME-Version: 1.0
In-Reply-To: <006701d737e7$097eb1b0$1c7c1510$@trustnetic.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-stable] [PATCH] drivers/net: fix FW version get
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Sender: "stable" <stable-bounces@dpdk.org>

On 4/23/2021 3:19 AM, Jiawen Wu wrote:
> On April 22, 2021 12:21 AM, Ferruh Yigit wrote:
>> Fixes a few different things:
>> * Remove 'fw_version' NULL checks, it is allowed if the 'fw_size' is
>>   zero, 'fw_version' being NULL but 'fw_size' not zero condition checked
>>   in ethdev layer
>> * Be sure required buffer size is returned if provided one is not big
>>   enough, instead of returning success (0)
>> * Document in doxygen comment the '-EINVAL' is a valid return type
>> * Take into account that 'snprintf' can return negative value
>> * Cast length to 'size_t' to compare it with 'fw_size'
>>
>> Fixes: bb42aa9ffe4e ("net/atlantic: configure device start/stop")
>> Fixes: ff70acdf4299 ("net/axgbe: support reading FW version")
>> Fixes: e2652b0a20a0 ("net/bnxt: support get FW version")
>> Fixes: cf0fab1d2ca5 ("net/dpaa: support firmware version get API")
>> Fixes: 748eccb97cdc ("net/dpaa2: add support for firmware version 
>> get")
>> Fixes: b883c0644a24 ("net/e1000: add firmware version get")
>> Fixes: 293430677e9c ("net/enic: add handler to return firmware 
>> version")
>> Fixes: 1f5ca0b460cd ("net/hns3: support some device operations")
>> Fixes: bd5b86732bc7 ("net/hns3: modify format for firmware version")
>> Fixes: ed0dfdd0e976 ("net/i40e: add firmware version get")
>> Fixes: e31cb9a36298 ("net/ice: support FW version getting")
>> Fixes: 4f09bc55ac3d ("net/igc: implement device base operations")
>> Fixes: eec10fb0ce6b ("net/ionic: support FW version")
>> Fixes: 8b0b56574269 ("net/ixgbe: add firmware version get")
>> Fixes: 4d9f5b8adc02 ("net/octeontx2: add FW version get operation")
>> Fixes: f97b56f9f12e ("net/qede: support FW version query")
>> Fixes: 83fef46a22b2 ("net/sfc: add callback to retrieve FW version")
>> Fixes: bc84ac0fadef ("net/txgbe: support getting FW version")
>> Fixes: 21913471202f ("ethdev: add firmware version get")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> <...>
> 
> 
> For txgbe,
> Acked-by: Jiawen Wu <jiawenwu@trustnetic.com>
> 

Applied to dpdk-next-net/main, thanks.